From owner-dev-commits-src-branches@freebsd.org Sun Jan 31 01:08:50 2021 Return-Path: Delivered-To: dev-commits-src-branches@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id B72EA4FEEF5 for ; Sun, 31 Jan 2021 01:08:50 +0000 (UTC) (envelope-from marklmi@yahoo.com) Received: from sonic313-21.consmr.mail.gq1.yahoo.com (sonic313-21.consmr.mail.gq1.yahoo.com [98.137.65.84]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4DStJ14WMdz3mWr for ; Sun, 31 Jan 2021 01:08:49 +0000 (UTC) (envelope-from marklmi@yahoo.com) X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1612055327; bh=jISdPzuD7szaq8qjc29C+AIaHFiNzvsdFo2HxlWsWmY=; h=From:Subject:Date:To:From:Subject:Reply-To; b=jNCkcZ2ljWBUiMbO5NwMFTnxXTw6WZZuZG6LTrGmefo850cLpmDUvW8TWC+8JFE6v3Tg63Qzg2R+ojmBxHlnNvMhAIwQQHzQ5Oagwz60CAkoYSD7/JHcgBz8ECoC5/IHTMnPsUi/xFHIeVPsCRS04Z2skSVLCdbLlmUkII+UzxA7bs+eJaiJSyR6DlobXkw4bQQOiT6F14EZpNjX9BkNTjee0SMrrvW24MKnCqKy/eWkDyqikr7fHNekE33uEo9f+A4KEz9tpg3yrAcRftHO7OgavzQit7ajRt6wGbq60XeR1On0Q3tPNi1pe5GTTQol+VLMytzngfd167TMtWj7tg== X-YMail-OSG: EKzb0AEVM1nRhnBiQad62QXT2ieZZuLFhvNansnYO04.AKUmdTpxWQL5KR1pg6C liAjM.HU2f2__Kaxnj8iuPEgnaA8BSYR_XzA1VyhBK7Fo6lV2Wt8UUQE5olEUWwBPharpWxSO.VA N8ApEIHXSqbsUp8LsCAs0b2881si6d20MftUm14xVlXSy4s6dqvwvIw5FH42B9ZgU55acCbuAsco J7golt_2GnY9bZYfN.mlJf2t1T9JfdKyv9CprLJ6CFXgF987wOcXTV2BntV5HYmsnS4RXHy05xrG CNi2fdlQmuvoNFNCZDLIcOdDYXppqSkrsLH1E8fB5VfdvD1f0txXyXcq.xyhXnyXEEdar0iK8e2D Iz_y3Lr7kdwcGbFsFeloNkDW5vZ2qoQzZh4EG1wsW1CMIcYOVItsn81U14C.AP039P02yTfp2MQK CxBKMoVBMx415yX11Qc.MMr.YG.ftb6qoztB2ikwaH_PHmvha4tptCBVQIqoQDpbbY_MoQBa0EKR lBC5WkcFVUKOJm4SSH0xf_EIyHAk86QXPMzgmLKJq_38sI6LwsZFZNRX8BZ4l5X_GVwVGW3YLzsx DKPxUIUbQkF_a_HtWXI1yidQQAk12f7qqVcT2ueASQrDB.Ot5UU0Kl3pnQCNrMPKk8VyGsFvD8KJ n5oPhUDbJ4E8.PC9ozXMeKwOZ8nP9mhH_.2A8npWH.FqXT8A5YKN44NYryet7liqaXlKsi0IDo8v jWhajzLXhQOxpt7fWf1sVQQsAucpeSeo55jZWiDVPs8xePUqVZ5ij62S3rCHk9Nc48mBucty8_G9 jQtPyiUmJpOwTfBR4qtSgb2qgzWmgOrzExV0x4QRgFeJ7BtkGgZjbdC4UfYFbrs3ihDqDbqIE99e cy3FSEVSToaxAk4_dCKn3RkcbdnofAMMXTz818fYnCPccPUrPnTFZeYIhXXwl9XN6T_TlfcqZp5Y bSeqUc40HySA1bt7L.CsCOfA9I7EggQ0czg6ZqdWPy5ljyWC40nq6z9.QCjIyvSsxrI8K0eFWKKa fuhug.4dw_RS.nIsK5YH3Y1gOjRxVomgSeG6GiLK4eFTZIEEyc6Aelqu2DkxB3b9Ha8dcv.bKsql ZAdHZdfwlPoFVdEhf7ZpoO7Y.uRxxMLn379gN5w69WMT7tf6qOKfhe5LLd3IBR4SM30_SMMD.JG4 D4.Ol53pD3oSwbGEtif2See5bjF1LClKznJ5l.x4ojdtG9Do3Fm.qAqEwjXYlumQ2anf1kIjTXse 5fv3XcN2MtkYFsNVc3WBw3sXZ.8dWsy.blvPjQedmZog5TVrjDypRj5qxxUHMR4q.T49avgEzMfX M8WUpDBmEgeycMDTXvavPNwfL0J4PeyWL8pqUQFMVygW_BPEXg18rCbvAfPI4JX.42GdDehrbp7z 1MuMHdKHa_IezvsJKEaPMokccpcyl_6BgFvYgeiAgmlxCRrgEK0y7oMMkkdaKKgSwDaHeMzo2ZEh 7_.SOjKsKiSww8UZSZhl1Af1GSOrzYtEbH1Y_PEP91ojxL2H0xROCwoTbZCqh5LdP2cDw1Hr3JM9 wWxkQ2MbpMAmkix6GgHtsvdyp9kmBq_wSqxEl4qxoBeAq9lltHo.iTiV01aa9vzNlP2XzM_.5B8e WcALvMovHoNXDTBmTOYuaPqFuFnX5jQTuXMUBJnFz6.6Ez8lLKYn1YNiGg60f7nMHaK0WKhWZtIA wrfjSzY4H1dkXzpNC2DX0NY1ZQAldITZo.SA1ZIzLHZKv__lffVnZwCXiXkIdEvSEdZv6l1znHhp w14.twKkn2Y_yEH7R9jbYMp5ufRUsjXDIOp_W51rm2FX7IYCjr9N5UjEgLtR9yZG0yHOqZEEzQoY KpJ4s7SS2.Rr2CsaUIECpj_C1fW8YK34gtFzaNHJGZhmrhQuhdZb1U.JleG7b6VNPmxOOW6XPfge vPPeGOWvipzNikWItmy659FCF2PRAI_jGdg0OaQi3wuG6XvCyaMQbS6UpAdNG6wrLmEHpknn0oHJ 3wiajQ7cMloHVJpNVsUOkK3V.Gtytu3nvHwOM1JzLKnnkh6AF4pgRXbvCFQKLmG6YT8BTorvxGn7 8h4Hy86rxrY_1xcCiNFG1GOy6kyBKvUuK1jE0jmwBQXoPY0FJivNOBi5SbfeRTEgmxuRatkoG25G fstHKInrOc.i9QYpC2PsHpvYS7Hbdh7MmfQdL7YMCFEEHilHf2wq0xFMSY0kuRv7xxgKtWL3UkKy IMZOoe7tn.qizpL.aFcN8Qp9YM.T9CkPXWUh8CwyTTW5l5.uwDm4djjRZx9yA0FBwZjCYvTKvyKx uXAgDDlTCa0KgErMC9lUV.i4Oy19WJRVGqlPNiL.1VKaGWnsihfAUOitKMlEimsLspnlkyw4AvQ5 bfPaL2iRVi8NLWqOKxxGAPDyWT7hORIB42WaJpIQPTdjMyYHoahp_wGY9Do4rAqd7e.Yor2Jugh8 iH8dHmt4LalYo2Ut7g5WJONbUeRS3ODHoQW1IQgT.DKvU.chZFHa0o8h_c.gws0lU8Hazt4kGGR2 5NOrUM4wYHyRxWg-- Received: from sonic.gate.mail.ne1.yahoo.com by sonic313.consmr.mail.gq1.yahoo.com with HTTP; Sun, 31 Jan 2021 01:08:47 +0000 Received: by smtp407.mail.bf1.yahoo.com (VZM Hermes SMTP Server) with ESMTPA ID d99e560f086903acbb5b393b32d5afca; Sun, 31 Jan 2021 01:08:43 +0000 (UTC) From: Mark Millard Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.40.0.2.32\)) Subject: Re: git: 3708b615c354 - stable/12 - sh: Allow more scripts without #! Message-Id: <140C16CB-E1E5-49E9-979D-0C707E678CE2@yahoo.com> Date: Sat, 30 Jan 2021 17:08:40 -0800 To: jilles@stack.nl, dev-commits-src-branches@freebsd.org X-Mailer: Apple Mail (2.3654.40.0.2.32) References: <140C16CB-E1E5-49E9-979D-0C707E678CE2.ref@yahoo.com> X-Rspamd-Queue-Id: 4DStJ14WMdz3mWr X-Spamd-Bar: --- X-Spamd-Result: default: False [-3.50 / 15.00]; FREEMAIL_FROM(0.00)[yahoo.com]; MV_CASE(0.50)[]; TO_DN_NONE(0.00)[]; R_SPF_ALLOW(-0.20)[+ptr:yahoo.com]; DKIM_TRACE(0.00)[yahoo.com:+]; RCPT_COUNT_TWO(0.00)[2]; DMARC_POLICY_ALLOW(-0.50)[yahoo.com,reject]; NEURAL_HAM_SHORT(-1.00)[-1.000]; SUBJECT_ENDS_EXCLAIM(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; RCVD_TLS_LAST(0.00)[]; MIME_TRACE(0.00)[0:+]; FREEMAIL_ENVFROM(0.00)[yahoo.com]; ASN(0.00)[asn:36647, ipnet:98.137.64.0/20, country:US]; RBL_DBL_DONT_QUERY_IPS(0.00)[98.137.65.84:from]; DWL_DNSWL_NONE(0.00)[yahoo.com:dkim]; MID_RHS_MATCH_FROM(0.00)[]; ARC_NA(0.00)[]; R_DKIM_ALLOW(-0.20)[yahoo.com:s=s2048]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; FROM_HAS_DN(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; MIME_GOOD(-0.10)[text/plain]; SPAMHAUS_ZRD(0.00)[98.137.65.84:from:127.0.2.255]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[98.137.65.84:from]; RWL_MAILSPIKE_POSSIBLE(0.00)[98.137.65.84:from]; RCVD_COUNT_TWO(0.00)[2]; MAILMAN_DEST(0.00)[dev-commits-src-branches] X-BeenThere: dev-commits-src-branches@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commits to the stable branches of the FreeBSD src repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 31 Jan 2021 01:08:50 -0000 Jilles Tjoelker jilles at stack.nl wrote on Sat Jan 30 23:09:15 UTC 2021 : . . . > > >>> + * In order to reject common binary files such as PNG images, check > > >>> + * that there is a lowercase letter or expansion before the last > > >>> + * newline before the NUL character, in addition to the check for > > >>> + * the newline character suggested by POSIX. > . . . vs. an alternate description: > The loop continues until the first NUL byte and will return false (not > binary) when it encounters any newline after an ASCII lowercase letter, > '$' or '`'. I find the comment in the code much harder to derive the intent from. ALTERNATE (partial?) WORDING FOR CODE COMMENT? : In order to reject common binary files such as PNG images, reject (return false) when there is a lowercase letter or expansion anywhere before any newline that is before the first NUL character. END ALTERNATE WORDING === Mark Millard marklmi at yahoo.com ( dsl-only.net went away in early 2018-Mar)