Date: Wed, 23 Nov 2022 11:00:09 +0100 From: Baptiste Daroussin <bapt@FreeBSD.org> To: Jochen Neumeister <joneum@FreeBSD.org> Cc: Ryan Steinmetz <zi@FreeBSD.org>, ports-committers@FreeBSD.org, dev-commits-ports-all@FreeBSD.org, dev-commits-ports-main@FreeBSD.org Subject: Re: git: 1867f0afa761 - main - www/nginx: Update 3rd Party Modules: ip2location, ip2proxy Message-ID: <20221123100009.t37svlib2kzvn2nl@aniel.nours.eu> In-Reply-To: <58629f2e-5e5b-6598-f801-f14870ea0ed9@FreeBSD.org> References: <202211201906.2AKJ6Z7K081843@gitrepo.freebsd.org> <58629f2e-5e5b-6598-f801-f14870ea0ed9@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Nov 21, 2022 at 09:48:07AM +0100, Jochen Neumeister wrote: > Is it now allowed to edit the port without informing the maintainer? I think > we have rules here, right? > I can't find any PR or eMail where this update is requested. > Also, PORTREVISION was not pumped. > Hello everyone, joneum@ is right here! here we have 2 issues: 1/ A simple technical one: the package has changed and such it deserves a bump of portrevision. 2/ The other one, is the following, while we have a blanket for fixes and framework changes adaptations, it does not include upgrades even simple ones. And we have to at least send a heads up to the maintainear anyway. (Yes I know I sometime myself forget about the maintainer heads up and I am trying to fix myself) Also mistake can happen, because someone wants to go fast or for any $reason, if so, then it is important to be reactive. Here a bump of the portrevision should have been pushed quickly after the maintainer pointed at the error. Last acknowledging the issue is part of what we can expect from a committer. Best regards, Bapt
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20221123100009.t37svlib2kzvn2nl>