From owner-svn-ports-all@FreeBSD.ORG  Fri May 10 14:57:45 2013
Return-Path: <owner-svn-ports-all@FreeBSD.ORG>
Delivered-To: svn-ports-all@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 1033)
 id 8017B5A7; Fri, 10 May 2013 14:57:45 +0000 (UTC)
Date: Fri, 10 May 2013 14:57:45 +0000
From: Alexey Dokuchaev <danfe@FreeBSD.org>
To: Martin Wilke <miwi@FreeBSD.org>
Subject: Re: svn commit: r317806 - in head/archivers/unalz: . files
Message-ID: <20130510145745.GA22175@FreeBSD.org>
References: <201305101431.r4AEVE2h009902@svn.freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <201305101431.r4AEVE2h009902@svn.freebsd.org>
User-Agent: Mutt/1.5.21 (2010-09-15)
Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org,
 ports-committers@freebsd.org
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 10 May 2013 14:57:45 -0000

On Fri, May 10, 2013 at 02:31:14PM +0000, Martin Wilke wrote:
> New Revision: 317806
> URL: http://svnweb.freebsd.org/changeset/ports/317806
> 
> Log:
>   - Fix build
>   
>   PR:		178154
>   Submitted by:	Ports Fury

While most of the Kato's work are of rather high quality and quite accurate
with the details down to licensing issues, this particular change:

>  do-install:
> -	${INSTALL_PROGRAM} ${WRKSRC}/unalz ${PREFIX}/bin
> +	(cd ${WRKSRC} && ${INSTALL_PROGRAM} ${PORTNAME} ${PREFIX}/bin)

is gratuitous and should not have been committed.  I think I've previously
raise this concern with Kato's submissions before.  Not just it does not win
us anything here, it makes install(1) statement context-dependent and also
reduces readability thereof at the same time.

No matter how good is Kato (whoever they are), we should not handle their
patches blindly.

./danfe