From owner-svn-src-head@freebsd.org Mon Dec 28 10:49:41 2015 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 0E6DFA53AA8; Mon, 28 Dec 2015 10:49:41 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 829B61959; Mon, 28 Dec 2015 10:49:40 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from tom.home (kostik@localhost [127.0.0.1]) by kib.kiev.ua (8.15.2/8.15.2) with ESMTPS id tBSAnZtV057108 (version=TLSv1 cipher=DHE-RSA-CAMELLIA256-SHA bits=256 verify=NO); Mon, 28 Dec 2015 12:49:35 +0200 (EET) (envelope-from kostikbel@gmail.com) DKIM-Filter: OpenDKIM Filter v2.10.3 kib.kiev.ua tBSAnZtV057108 Received: (from kostik@localhost) by tom.home (8.15.2/8.15.2/Submit) id tBSAnZnh057107; Mon, 28 Dec 2015 12:49:35 +0200 (EET) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com using -f Date: Mon, 28 Dec 2015 12:49:35 +0200 From: Konstantin Belousov To: "Andrey V. Elsukov" Cc: Allan Jude , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r292788 - in head/sys: geom/part sys Message-ID: <20151228104935.GP3625@kib.kiev.ua> References: <201512271812.tBRICD3A044563@repo.freebsd.org> <5680F39D.8070002@yandex.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5680F39D.8070002@yandex.ru> User-Agent: Mutt/1.5.24 (2015-08-30) X-Spam-Status: No, score=-2.0 required=5.0 tests=ALL_TRUSTED,BAYES_00, DKIM_ADSP_CUSTOM_MED,FREEMAIL_FROM,NML_ADSP_CUSTOM_MED autolearn=no autolearn_force=no version=3.4.1 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on tom.home X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 28 Dec 2015 10:49:41 -0000 On Mon, Dec 28, 2015 at 11:32:29AM +0300, Andrey V. Elsukov wrote: > On 27.12.15 21:12, Allan Jude wrote: > > enum g_part_alias { > > G_PART_ALIAS_APPLE_BOOT, /* An Apple boot partition entry. */ > > + G_PART_ALIAS_APPLE_CORE_STORAGE,/* An Apple Core Storage partition. */ > > G_PART_ALIAS_APPLE_HFS, /* An HFS+ file system entry. */ > > G_PART_ALIAS_APPLE_LABEL, /* An Apple label partition entry. */ > > G_PART_ALIAS_APPLE_RAID, /* An Apple RAID partition entry. */ > > G_PART_ALIAS_APPLE_RAID_OFFLINE,/* An Apple RAID (offline) part entry.*/ > > G_PART_ALIAS_APPLE_TV_RECOVERY, /* An Apple TV recovery part entry. */ > > G_PART_ALIAS_APPLE_UFS, /* An Apple UFS partition entry. */ > > + G_PART_ALIAS_BIOS_BOOT, /* A GRUB 2 boot partition entry. */ > > + G_PART_ALIAS_CHROMEOS_FIRMWARE, /* A ChromeOS firmware part. entry. */ > > + G_PART_ALIAS_CHROMEOS_KERNEL, /* A ChromeOS Kernel part. entry. */ > > + G_PART_ALIAS_CHROMEOS_RESERVED, /* ChromeOS. Reserved for future use. */ > > + G_PART_ALIAS_CHROMEOS_ROOT, /* A ChromeOS root part. entry. */ > > This enum could be used by third-party kernel module and in general it > is not good to change the order of elements here. This can break `gpart > show` output for such modules. Just for the future. :) If the enum values are considered part of KBI, then explicit assignment of the enum values is much preferred.