From owner-svn-ports-all@freebsd.org Sat Jun 3 02:49:47 2017 Return-Path: Delivered-To: svn-ports-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 5D735B7C079; Sat, 3 Jun 2017 02:49:47 +0000 (UTC) (envelope-from koobs.freebsd@gmail.com) Received: from mail-pg0-x244.google.com (mail-pg0-x244.google.com [IPv6:2607:f8b0:400e:c05::244]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 2835C80367; Sat, 3 Jun 2017 02:49:47 +0000 (UTC) (envelope-from koobs.freebsd@gmail.com) Received: by mail-pg0-x244.google.com with SMTP id v18so236617pgb.3; Fri, 02 Jun 2017 19:49:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:reply-to:subject:to:references:cc:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=vnVw20YKp6L8Gii8JyToKOknJTd72Xmg///HH3ZBEVE=; b=kdWrKZJQgZ2OHHkfL9IfF4vNjv8VkvB/m92KjX1XwfynSSS9ODKpcgeqJnYlx+ycQH 3slNXPDfyD76lo2GKr0ZBsMfjTzl24Y3WQp1dCO/iljeh4LAtYS98s+hWfx7LicKES6O RM9ZtcDvOzJUMgTxMYuVssaSAchI75oGHiSDxEd9bnjxUXDBHbDCuyBAn6cyKmdkEPqC Bem2yLWfF4oYhOPhMMWU+rAMCwyW7Yvcy6ap0iWfpeZHaOef+8Gg7w9xN7sNWjx24pf9 YVs3CZG97qp6Yqni92e2qjyJD1hntZNxwOD2ePiapqsFAup/4YCQ9u9XxJVMHmKhvze5 Wyqw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:reply-to:subject:to:references:cc:from :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=vnVw20YKp6L8Gii8JyToKOknJTd72Xmg///HH3ZBEVE=; b=fTryMwnZ3vc0ejGAVgp1QUvhlf+j575ILZq+WxPOitCZ0m0hre9RlwsxOgOa0LwLwf kFy9LnbxgSPQR1Krw+keacgvKHQU/7CJ+g6t5s+e2YQNEu6sYuyPfl/W41LNV+o4uoPk 8n3i1Uqk1yRV5m+ZjuesMLDirsf9jblzQOwNui093lWTxT1O89xUqqjKIWB2mW1/gZy+ +lpyma+W+Yfh9Y3H0LlRq1GcgCtBu42gfFEkSohKtl4fcrfNHOV8ivDzVUqsvbeG3Zs5 5YrGuxWhsbQC5eOnushgqUIOKMj2+89vfEZzbRFeklYObfxary4Yzkj6FEHTlDLbxkGi H2mw== X-Gm-Message-State: AODbwcANpxcIBZqfny61kWNIFzIZV4z47YFrRcIEKIXb3nehTi1Ejz8D kcpTt7+EF6yRFYPTKNQ= X-Received: by 10.84.229.6 with SMTP id b6mr3140412plk.4.1496458186458; Fri, 02 Jun 2017 19:49:46 -0700 (PDT) Received: from ?IPv6:2001:44b8:31ae:7b01:2042:3e8:d7ce:9b9c? (2001-44b8-31ae-7b01-2042-03e8-d7ce-9b9c.static.ipv6.internode.on.net. [2001:44b8:31ae:7b01:2042:3e8:d7ce:9b9c]) by smtp.gmail.com with ESMTPSA id z69sm16665575pff.0.2017.06.02.19.49.44 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 02 Jun 2017 19:49:46 -0700 (PDT) Sender: Kubilay Kocak Reply-To: koobs@FreeBSD.org Subject: Re: svn commit: r442460 - in head: . Mk devel/qt5-core devel/qt5-qmake To: "Tobias C. Berner" , ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org References: <201706022003.v52K3CkH012011@repo.freebsd.org> Cc: FreeBSD Ports Security Team From: Kubilay Kocak Message-ID: Date: Sat, 3 Jun 2017 12:45:13 +1000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:54.0) Gecko/20100101 Thunderbird/54.0a2 MIME-Version: 1.0 In-Reply-To: <201706022003.v52K3CkH012011@repo.freebsd.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-AU Content-Transfer-Encoding: 7bit X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 03 Jun 2017 02:49:47 -0000 On 6/3/17 6:03 AM, Tobias C. Berner wrote: > Author: tcberner > Date: Fri Jun 2 20:03:12 2017 > New Revision: 442460 > URL: https://svnweb.freebsd.org/changeset/ports/442460 > > Log: > Do not use gold linker for Qt5 ports. > > gold linker from binutils 2.28 may produce duplicate library > symbols, which makes shared libraries created with it not usable > with conventional ld linker. > > PR: 218187 > Submitted by: amdmi3 Is quarterly affected by this? Can/should this be MFH'd? > Modified: > head/Mk/bsd.qt.mk > head/UPDATING > head/devel/qt5-core/Makefile > head/devel/qt5-qmake/Makefile > > Modified: head/Mk/bsd.qt.mk > ============================================================================== > --- head/Mk/bsd.qt.mk Fri Jun 2 19:56:07 2017 (r442459) > +++ head/Mk/bsd.qt.mk Fri Jun 2 20:03:12 2017 (r442460) > @@ -147,7 +147,9 @@ CONFIGURE_ARGS+=-nomake examples -nomake tests \ > . if ${ARCH} == i386 && empty(MACHINE_CPU:Msse2) > CONFIGURE_ARGS+=-no-sse2 > . endif > - > +# Work around a bug in current binutils, where the gold linker creates > +# duplicate symbols. See pr 218187. Disable the gold-linker for Qt5 ports. > +CONFIGURE_ARGS+= -no-use-gold-linker > . endif > > . if defined(WANT_QT_DEBUG) || defined(WITH_DEBUG) > > Modified: head/UPDATING > ============================================================================== > --- head/UPDATING Fri Jun 2 19:56:07 2017 (r442459) > +++ head/UPDATING Fri Jun 2 20:03:12 2017 (r442460) > @@ -5,6 +5,27 @@ they are unavoidable. > You should get into the habit of checking this file for changes each time > you update your ports collection, before attempting any port upgrades. > > +20170602: > + AFFECTS: users of Qt 5 in presence of binutils > + AUTHOR: amdmi3@FreeBSD.org > + > + gold linker from binutils 2.28 may produce duplicate library > + symbols, which makes shared libraries created with it not usable > + with conventional ld linker. > + > + This affects Qt, as qt5-qmake will detect gold and use it to build > + Qt libraries. Broken libQt5Core will be produced and ports which > + depend on it will then fail to link with the following errors: > + > + ...lib/libQt5Core.so:(.dynamic+0x27ac8): multiple definition of `__bss_start at Qt_5' > + ...lib/libQt5Core.so:(.dynamic+0x27ac8): first defined here > + ...lib/libQt5Core.so:(.dynamic+0x27ac8): multiple definition of `_edata at Qt_5' > + ...lib/libQt5Core.so:(.dynamic+0x27ac8): first defined here > + ...lib/libQt5Core.so:(.dynamic+0x2b2d0): multiple definition of `_end at Qt_5' > + > + Qt5 was fixed to ignore gold. If you see these errors, you > + need to rebuild qt5-qmake, then all qt5-* ports. > + > 20170529: > AFFECTS: users of sysutils/dsbmd > AUTHOR: mk@freeshell.de > > Modified: head/devel/qt5-core/Makefile > ============================================================================== > --- head/devel/qt5-core/Makefile Fri Jun 2 19:56:07 2017 (r442459) > +++ head/devel/qt5-core/Makefile Fri Jun 2 20:03:12 2017 (r442460) > @@ -2,6 +2,7 @@ > > PORTNAME= core > DISTVERSION= ${QT5_VERSION} > +PORTREVISION= 1 > CATEGORIES= devel > PKGNAMEPREFIX= qt5- > > > Modified: head/devel/qt5-qmake/Makefile > ============================================================================== > --- head/devel/qt5-qmake/Makefile Fri Jun 2 19:56:07 2017 (r442459) > +++ head/devel/qt5-qmake/Makefile Fri Jun 2 20:03:12 2017 (r442460) > @@ -2,7 +2,7 @@ > > PORTNAME= qmake > DISTVERSION= ${QT5_VERSION} > -PORTREVISION= 2 > +PORTREVISION= 3 > CATEGORIES= devel > PKGNAMEPREFIX= qt5- > >