From owner-freebsd-current Wed Aug 16 23:47:27 2000 Delivered-To: freebsd-current@freebsd.org Received: from ywing.creative.net.au (ywing.creative.net.au [203.56.168.34]) by hub.freebsd.org (Postfix) with ESMTP id 0CECA37B63F; Wed, 16 Aug 2000 23:47:21 -0700 (PDT) (envelope-from adrian@ywing.creative.net.au) Received: (from adrian@localhost) by ywing.creative.net.au (8.9.3/8.9.3) id IAA08196; Thu, 17 Aug 2000 08:55:24 +0200 (CEST) (envelope-from adrian) Date: Thu, 17 Aug 2000 08:55:24 +0200 From: Adrian Chadd To: Poul-Henning Kamp Cc: freebsd-current@FreeBSD.ORG Subject: Re: Patch test & review: vop_stdaccess() Message-ID: <20000817085524.A7177@ywing.creative.net.au> References: <53850.966458102@critter> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2i In-Reply-To: <53850.966458102@critter>; from phk@FreeBSD.ORG on Wed, Aug 16, 2000 at 10:35:02PM +0200 Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG On Wed, Aug 16, 2000, Poul-Henning Kamp wrote: > > Please test and review this patch: > > http://phk.freebsd.dk/patch/vop_stdaccess.patch > > This patch creates a centralized function "vop_stdaccess()" which > does the "canonical" permission check on a vnode. > > This code was duplicated in 5 filesystems and morphed in a 6th. > > Files touched: > > Index: fs/hpfs/hpfs_vnops.c > Index: isofs/cd9660/cd9660_vnops.c > Index: kern/vfs_default.c > Index: miscfs/kernfs/kernfs_vnops.c > Index: msdosfs/msdosfs_vnops.c > Index: ntfs/ntfs_vnops.c > Index: sys/vnode.h > Index: ufs/ufs/ufs_vnops.c > > Linecount: removes: 243 adds: 79 net change: -164 I reviewed this last night and it looks good. Perhaps someone with credential clue could suggest a change to the cred_uid == 0 check .. ? Adrian -- Adrian Chadd Now 17-year-olds can't play a _video game_ because its called violent - and real violence is still called dinner. -- jamie@mccarthy.org To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message