From nobody Sun Oct 5 22:36:10 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4cfy1T3k7Pz6BrdX for ; Sun, 05 Oct 2025 22:36:29 +0000 (UTC) (envelope-from mjguzik@gmail.com) Received: from mail-ed1-x533.google.com (mail-ed1-x533.google.com [IPv6:2a00:1450:4864:20::533]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4cfy1S6crZz3MtH for ; Sun, 05 Oct 2025 22:36:28 +0000 (UTC) (envelope-from mjguzik@gmail.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-ed1-x533.google.com with SMTP id 4fb4d7f45d1cf-637dbabdb32so8379623a12.2 for ; Sun, 05 Oct 2025 15:36:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1759703782; x=1760308582; darn=freebsd.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=7kwyuGzQawjGSDuyVHFe71G07XlS6rwfIYSmjjrAWA8=; b=gka8iNZ4SnRhn7KCfoKAuFOjMX9X/ieFmwGBq5Tfggd/yEQpVU7jaq3lxY2YaQRHU8 EXQewxoeYV6X7rJmdjFyojQki6Ot1tk9US6f9uk+FJU/928MKHeKEs9NWI/78au0qAyd NHmkr3kAitAwXbecrZ/MuulEnj9YJZmKp33wHwbUGaZmLnngUQZdi8w3Z1QDo8K5GAYV UrOf5lHrgvNzupuqXyqOIPwZzC5lPU5qNNSJeGBCS09lmJgG2olGET2HZGqieeMaP6Yd 8iXbskmShdv4Yy8mBzhR9dQmISgJ3CAKqaDHBUrDBsAJO3ZsMuU/r24VaNS+ftVUwHNW wBbg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1759703782; x=1760308582; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=7kwyuGzQawjGSDuyVHFe71G07XlS6rwfIYSmjjrAWA8=; b=nc/hv/SnD0DR5srJ8c0yTiWnp7RcsvUTy3mZiRs/aR3owX264OBYfdxicvAFZUjwVu OxyElsf0H1v1k2LQb8xLTBztvoT4wxPlhT6nK9aMR+5nUezxwXrOWwB6zgVBg5byKS0z /PkiY4UUQA692Vpjje7lr2q8QC/wsnt1z8zdrIp+juUMFy0sutD2tv1Yjkn/TBfzo8wt I45gPsHa0Hm4TLzldZIb0Um2P1Vy7yAuoxiuNz96Ea8rNQ1i8BaUP+eyUH7WfZtL+lQ7 moCXNcrTeqwkCsapq12oWVibLS/IRlq1NGvK8yCEyIjcWTRs3W59zUavPmLmkrm1Af/L 9ZyQ== X-Forwarded-Encrypted: i=1; AJvYcCWF3jcC0CQUQ9YuWCgudMD0JSD94p+GbNHJsh8/YHEKDe47SWNOmkwzD45pafFlmCTkGkh7bHkffDsPACoELD/ESIVAsA==@freebsd.org X-Gm-Message-State: AOJu0Yy436p9bK6VkKha2NS2btUHTv1Y+8OyRYPdMS+wR48ZzffjZnnh Dw75w2qc+aDD6zO2Gt55NJXCQX9mx08GYiZGkD8O6Wo5i8Fl3Vrml3FJa/UVIx7tP+xLMXJ/e8/ ghZD3+6XlTiXpqXP7Nfdr8Oy/EjQXJL4t+Q== X-Gm-Gg: ASbGnctrLF3FCDSdypYnj5GZLFOEQvsXEjELsaZKj25ZO4EX3RWjPZ6zeCq34lLFpRw +0KBzSVRX3wZkQibxhItp8aCK1m5O9MUh3olVS6bSVUSZaeU7kiieQpr/vnoCRMWOx5OLX7njWR PfHcDN0tkViCnRslsPOvDvGSLP0a12aym/IjNS+aK/ooKztOF99zT53mi6ygjuWZ/JQzocJ7jTh EgKCT1ghaQU9ySP9SyEhJdR4IBH+5pOw/NcuKZpy3gPYN6W+/1JUvjTqdFVGHE= X-Google-Smtp-Source: AGHT+IF76adS1uJ1NyISLYc2Bq+61rui+Xx0xclMUYoQAqdfS15OuBLskIs76I5VoBk1MahdXsutzwX4Bt8EM2nvf68= X-Received: by 2002:a05:6402:2354:b0:637:f374:eeda with SMTP id 4fb4d7f45d1cf-6393491e97cmr11848451a12.20.1759703782347; Sun, 05 Oct 2025 15:36:22 -0700 (PDT) List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 References: <202510052122.595LM1mb099170@gitrepo.freebsd.org> In-Reply-To: From: Mateusz Guzik Date: Mon, 6 Oct 2025 00:36:10 +0200 X-Gm-Features: AS18NWAYr_Nux_tfrXX-tIOup3A2oeYEf543OzX1TJ4GZ_AxlHlqFz2NEGl1GBs Message-ID: Subject: Re: git: b1de02c415de - main - vfs offset: fix assertion failure in face of racing ffofset and setfl locking To: Konstantin Belousov Cc: Mateusz Guzik , src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:2a00:1450::/32, country:US] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Rspamd-Queue-Id: 4cfy1S6crZz3MtH I'll take care of it on Wednesday On Sun, Oct 5, 2025 at 11:56=E2=80=AFPM Konstantin Belousov wrote: > > On Sun, Oct 05, 2025 at 09:22:01PM +0000, Mateusz Guzik wrote: > > The branch main has been updated by mjg: > > > > URL: https://cgit.FreeBSD.org/src/commit/?id=3Db1de02c415de5df2d24d8021= 827634fc095b7a26 > > > > commit b1de02c415de5df2d24d8021827634fc095b7a26 > > Author: Mateusz Guzik > > AuthorDate: 2025-10-05 17:03:54 +0000 > > Commit: Mateusz Guzik > > CommitDate: 2025-10-05 21:21:34 +0000 > > > > vfs offset: fix assertion failure in face of racing ffofset and set= fl locking > > > > Both use the same 16 bit var to store their locked and waiters bits= , > > then this in file_v_unlock: > > > > state =3D atomic_load_16(flagsp); > > if ((state & lock_wait_bit) =3D=3D 0 && > > atomic_cmpset_rel_16(flagsp, state, state & ~lock_bit)) > > return; > > > > can fail if for example foffset is being unlocked while setfl is ge= tting > > locked. > > > > Afterwards the code assumes there are blocked waiters on foffset. > > > > Reviewed by: kib, markj > > Sponsored by: Rubicon Communications, LLC ("Netgate") > > Differential Revision: https://reviews.freebsd.org/D52915 > > This should be merged both to stable/15 and 14.