From owner-svn-ports-all@freebsd.org Fri Dec 9 18:19:00 2016 Return-Path: Delivered-To: svn-ports-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id E6A2BC6F5DC; Fri, 9 Dec 2016 18:19:00 +0000 (UTC) (envelope-from r.c.ladan@gmail.com) Received: from mail-wj0-x232.google.com (mail-wj0-x232.google.com [IPv6:2a00:1450:400c:c01::232]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 7949A197; Fri, 9 Dec 2016 18:19:00 +0000 (UTC) (envelope-from r.c.ladan@gmail.com) Received: by mail-wj0-x232.google.com with SMTP id tk12so21243424wjb.3; Fri, 09 Dec 2016 10:19:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:subject:to:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding; bh=XHxjChcg+y7HU4+mXhdagTXHIL1IKw+zNaD+psm9GMw=; b=FF2lGuCz7fDjy6CgaDJ/EtWXbDBx1fl2aBoTBqYXf+PX7DW7MWhK/vb7BHqiE288Aj C5mCVvYcZgiauWxnYAAXIFeKhIEfgFoIUyGkls92Dfr9QQN6lPiAwQ4+okE8jZS9lo/o 988+09OXnuC1XjRLAqlu6iF2iSZjP3sVjcb2ms590JwXTpcHgNmqzayZLu2dNvmB5D17 REdATz6PHxufMswk7j9RBgLSxr6/2rP5Gr0s4qlkvzytHjCogzy2OGL5EFlRfwcDw57g pV5FQfKYo6+pNVjruAvI0nUSL7IedR8g/gCKvhQBRB6s6G312gIquIh2gNjIwPE1SWq9 WSAg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:subject:to:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=XHxjChcg+y7HU4+mXhdagTXHIL1IKw+zNaD+psm9GMw=; b=ifvtu4b2RYg4ZCQ1LF6wczSwF/r7aB7i6cEwmsORuB388yI/2tvJxsC/w7eH/av5Xt Pg0s4RRmKsSNsz7YBM2qRinyM7PSR6uIX6hEL9HYrHGlLrkHSqW51Ln607/ctk0RXfSA aGxIFAvRkz9IuuZqTEExlHZX/KaxfNJRrucuzfmSjIykdDJs3uJh8xvyF4GOCcfy9u0W PlGvPtGFFr+JGZ2h5+22xUlgxwvSH/fhs6zdXER9QVc1H5u8zx5kFaSLUjcAaWUOP1fC BGYhbaj8B1rJn/sy58KJgjKERq+HYzWVMPRqsbjCLc88LpDIWA2KDa3exPOxOUwUzyHm Knhw== X-Gm-Message-State: AKaTC02hXJ+65T6cuuAh2ULg9XIZHldEJ7TZmfxn5G7id3N57DeAL+qLB6JpHJDlFVSXpg== X-Received: by 10.194.125.43 with SMTP id mn11mr32529219wjb.14.1481307538195; Fri, 09 Dec 2016 10:18:58 -0800 (PST) Received: from ?IPv6:2001:980:d7ed:1:3265:ecff:fe8f:d3ec? ([2001:980:d7ed:1:3265:ecff:fe8f:d3ec]) by smtp.googlemail.com with ESMTPSA id c202sm10919458wme.1.2016.12.09.10.18.57 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 09 Dec 2016 10:18:57 -0800 (PST) Sender: =?UTF-8?Q?Ren=C3=A9_Ladan?= Subject: Re: svn commit: r428154 - head/www/py-formalchemy To: koobs@FreeBSD.org, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org References: <201612082012.uB8KCqUv054897@repo.freebsd.org> From: =?UTF-8?Q?Ren=c3=a9_Ladan?= Message-ID: <94d945c8-f839-6d60-2279-a0f65c41a0ab@freebsd.org> Date: Fri, 9 Dec 2016 19:18:56 +0100 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 09 Dec 2016 18:19:01 -0000 On 09-12-2016 05:09, Kubilay Kocak wrote: > On 9/12/2016 7:12 AM, Rene Ladan wrote: >> PORTNAME= formalchemy >> -PORTVERSION= 1.3.3 >> -PORTREVISION= 2 >> +PORTVERSION= 1.5.1 > PyPI (CHEESESHOP) has 1.5.5 OK > https://pypi.python.org/pypi/FormAlchemy > >> CATEGORIES= www python >> -MASTER_SITES= GOOGLE_CODE >> +#MASTER_SITES= https://github.com/FormAlchemy/formalchemy > This can be removed (but switch this to CHEESESHOP instead given it has > a later version) Yeah, the commented out line crept in. >> PKGNAMEPREFIX= ${PYTHON_PKGNAMEPREFIX} >> DISTNAME= FormAlchemy-${DISTVERSION} >> >> @@ -14,11 +13,11 @@ COMMENT= Toolkit for creating HTML form >> >> LICENSE= MIT > There is a LICENSE_FILE (COPYRIGHT.TXT) in WKRSRC (both PyPI and > Github), please add it when one exists there. Sure, but I didn't touch this part... >> >> -BROKEN= Unfetchable (google code has gone away) >> -DEPRECATED= Broken, depends on expired py-sqlalchemy06 >> -EXPIRATION_DATE= 2016-12-08 >> +USE_GITHUB= yes >> +GH_ACCOUNT= FormAlchemy >> +GH_TAGNAME= v${PORTVERSION} > Use DISTVERSIONPREFIX=v instead of this (when using USE_GITHUB) and tags > begin with 'v'. Indeed, DISTVERSIONPREFIX is more generic, but GH_TAGNAME happened to turn up earlier when looking to fix the port. I should somehow remember this... >> >> -BUILD_DEPENDS= ${PYTHON_PKGNAMEPREFIX}sqlalchemy06>=0.4.5:databases/py-sqlalchemy06 \ >> +BUILD_DEPENDS= ${PYTHON_PKGNAMEPREFIX}sqlalchemy10>=0.4.5:databases/py-sqlalchemy10 \ >> ${PYTHON_PKGNAMEPREFIX}Tempita>=0.4:textproc/py-Tempita \ >> ${PYTHON_PKGNAMEPREFIX}webhelpers>=0.6.4:www/py-webhelpers > None of these are BUILD_DEPENDS (ie; setup.py:setup_requires) [1] > >> RUN_DEPENDS:= ${BUILD_DEPENDS} > * They are all RUN_DEPENDS (ie; setup.py:install_requires) [1] > * MarkupSafe and six are missing from RUN_DEPENDS [1] > > [1] setup.py: install_requires=['SQLAlchemy', 'Tempita', 'WebHelpers2', > 'WebOb', 'MarkupSafe', 'six'], > > See also: https://github.com/FormAlchemy/formalchemy/issues/69 as a > backported commit may be required. > All the above was unmodified by the update, which was primarily done to save the port from removal because it had an expired dependency and mastersite. Feel free to fix, or send in a PR. René