From owner-svn-src-head@FreeBSD.ORG  Mon Oct 27 16:20:39 2014
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id B71E8715;
 Mon, 27 Oct 2014 16:20:39 +0000 (UTC)
Received: from f10.opsec.eu (f10.opsec.eu [IPv6:2001:14f8:200:4::2])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 70066D55;
 Mon, 27 Oct 2014 16:20:39 +0000 (UTC)
Received: from pi by f10.opsec.eu with local (Exim 4.84 (FreeBSD))
 (envelope-from <pi@FreeBSD.org>)
 id 1Xin22-0003p5-QK; Mon, 27 Oct 2014 17:20:34 +0100
Date: Mon, 27 Oct 2014 17:20:34 +0100
From: Kurt Jaeger <pi@FreeBSD.org>
To: Bruce Evans <brde@optusnet.com.au>
Subject: Re: svn commit: r273734 - head/bin/dd
Message-ID: <20141027162034.GN1492@f10.opsec.eu>
References: <201410271138.s9RBcHrA002447@svn.freebsd.org>
 <20141028005225.S2013@besplex.bde.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20141028005225.S2013@besplex.bde.org>
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
 src-committers@freebsd.org, Kurt Jaeger <pi@freebsd.org>
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.18-1
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 27 Oct 2014 16:20:39 -0000

Hi!

> > Log:
> >  bin/dd: Fix incorrect casting of arguments
[...]
> Both of these work correctly in my version (with a relatively small patch
> and no breakage of other cases).  (I actually typed large values as -1
> and 11111111111111111111111111.  -1 means (uintmax_t)-1 although this
> is undocumented and now broken).

So, given this detailed review, should I revert the change ?

-- 
pi@FreeBSD.org         +49 171 3101372                6 years to go !