From owner-freebsd-current@FreeBSD.ORG Tue Sep 13 17:53:50 2005 Return-Path: X-Original-To: current@freebsd.org Delivered-To: freebsd-current@FreeBSD.ORG Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E876F16A41F for ; Tue, 13 Sep 2005 17:53:50 +0000 (GMT) (envelope-from jmg@hydrogen.funkthat.com) Received: from hydrogen.funkthat.com (gate.funkthat.com [69.17.45.168]) by mx1.FreeBSD.org (Postfix) with ESMTP id 85AB543D45 for ; Tue, 13 Sep 2005 17:53:48 +0000 (GMT) (envelope-from jmg@hydrogen.funkthat.com) Received: from hydrogen.funkthat.com (localhost.funkthat.com [127.0.0.1]) by hydrogen.funkthat.com (8.13.3/8.13.3) with ESMTP id j8DHrl4J070791; Tue, 13 Sep 2005 10:53:47 -0700 (PDT) (envelope-from jmg@hydrogen.funkthat.com) Received: (from jmg@localhost) by hydrogen.funkthat.com (8.13.3/8.13.3/Submit) id j8DHri80070790; Tue, 13 Sep 2005 10:53:44 -0700 (PDT) (envelope-from jmg) Date: Tue, 13 Sep 2005 10:53:44 -0700 From: John-Mark Gurney To: Lonnie VanZandt Message-ID: <20050913175344.GO793@funkthat.com> Mail-Followup-To: Lonnie VanZandt , current@freebsd.org References: <200509131000.12719.lonnie.vanzandt@ngc.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200509131000.12719.lonnie.vanzandt@ngc.com> User-Agent: Mutt/1.4.2.1i X-Operating-System: FreeBSD 5.4-RELEASE-p6 i386 X-PGP-Fingerprint: B7 EC EF F8 AE ED A7 31 96 7A 22 B3 D8 56 36 F4 X-Files: The truth is out there X-URL: http://resnet.uoregon.edu/~gurney_j/ X-Resume: http://resnet.uoregon.edu/~gurney_j/resume.html Cc: current@freebsd.org Subject: Re: opt_netgraph in netgraph/netgraph.h? X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: John-Mark Gurney List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Sep 2005 17:53:51 -0000 Lonnie VanZandt wrote this message on Tue, Sep 13, 2005 at 10:00 -0600: > Sometime between 5.4 RC3 and 5.4 STABLE, netgraph/netgraph.h went from version > 1.43.2.5 to 1.43.2.10. In doing so, an include of "opt_netgraph.h" was added > to that file. This causes code including netgraph/netgraph.h, on my system, > to fail to compile since opt_netgraph.h isn't in the include path. > > When a kernel conf file doesn't have "options NETGRAPH" the generated > opt_netgraph.h file is empty. With "options NETGRAPH" the file simply > contains "#define NETGRAPH 1". So, either way, the file isn't hard to create > - but I need to know where it should reside in the "@" hierarchy. > > Does anyone (say julian@) know? And, just for curiousity sake, does anyone > know which update step I probably overlooked which led to the breakage on my > platform? The opt_*.h files are automaticly created by config... Sometimes you just need to rerun config before building your kernel... If it fails building the module, then the module's Makefile needs to be fixed to create the opt_*.h files as necessary... -- John-Mark Gurney Voice: +1 415 225 5579 "All that I will do, has been done, All that I have, has not."