From nobody Mon Mar 3 16:56:58 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Z64jR2d2qz5pnKH; Mon, 03 Mar 2025 16:56:59 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Z64jQ4G2Tz46Bd; Mon, 03 Mar 2025 16:56:58 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1741021018; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=ldRH4fVbBKAevMCwLuqnCl4WifpK5Y8qUfSAbZc+S6c=; b=Kwx4/Tgf8ObBIYIrIetX78n1LxHL52cLgu82G5BsYnoUES5cFuuxB1QXQ3WQFaIbXC2GoL oxs/bREMaW6720L+DH976DAMqdxggRzEyA2XwQM1kPu8QOuL/V3RkHNgBWedUhKTcUmc6w YwoZqZ4W04+buiGDn6+QcD3ByoU04g6CCebNkFGrL+bsrQF0/egRKuzYr2VaQ6WRKoq/gH KiSWZ3A55s1fL/H1MjHp4l1/dm6Gho6xrWHIwr/LnSINLX100gGzxX/CmoWUQtArv3lECX ea5O0WkDiqB0DeioEwrIjuYjstrYO6/ByMQ87J2QXYcMe2sj2HDmG3km/Yj88Q== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1741021018; a=rsa-sha256; cv=none; b=axtlTDP4GnXnnzdtibEKk/g5tRT75rO4hpiRPaLrpgz/bsVm9qxfZr/fn4iqhOO9lD8h2A WJuf38iIwDOCaxOuQBLTyXhLjCEMM/UcHATBAGZQR2MFQwOqrv42EFBEnKKk4eqcxwrGEi DVqwHXxA995ABbmXb85xTvOkfkw6W1u6RqWiO2DyHL4BFXay/fo93CJt4dWNjZ2ZkCwaD4 0gQTTGXzja0WDkhgJxYkrnh0gSXqYkbYwSM7x+fww2e9P/gaC71aVWDee0z6GPRqiq9fA4 5iNhdVtlk1JqkCEgenZttc2x580/+L/fzUNGLJh680aZ+Z93oaR548SFY8eaCg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1741021018; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=ldRH4fVbBKAevMCwLuqnCl4WifpK5Y8qUfSAbZc+S6c=; b=njPd1/t243wlkpLtF2KvE68HgFwW3otkOiOC3/OCVp4Go62+FMFYepUc1Yh36wL0y8Fz/G HKhWcqPc0nX0PDqtWfoDFUSJqscny229HPdlcZ+wdqh9axAxRsJucxFGTeEWCzXg3bKqTR KmfWxq7C0IwrOgGW5HmHkVHINf+iUKyo8tOm/WEnOWF9u/QwS3hV+Dp8POjQf/PudbwLd+ Oc6asFfeE1/cdZUtp+R+XTptt0kcdrmt+LLycfSEhYX33OyARySzPapKHt6VEccFEOX/+8 w2iL8Wujby4emU0LzQYA1eBi4hGtqgYR6zqu16kZLIuDe0mKdPkRyqispB/PDw== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4Z64jQ36rJzwtk; Mon, 03 Mar 2025 16:56:58 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 523Guwcq083689; Mon, 3 Mar 2025 16:56:58 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 523GuwAQ083686; Mon, 3 Mar 2025 16:56:58 GMT (envelope-from git) Date: Mon, 3 Mar 2025 16:56:58 GMT Message-Id: <202503031656.523GuwAQ083686@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: John Baldwin Subject: git: 939bcd2c20b4 - stable/14 - cpu_set_upcall / linux_clone_thread: Remove calls to cpu_thread_clean List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: jhb X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: 939bcd2c20b42f550c7b89a52a105bfbbb8b5db1 Auto-Submitted: auto-generated The branch stable/14 has been updated by jhb: URL: https://cgit.FreeBSD.org/src/commit/?id=939bcd2c20b42f550c7b89a52a105bfbbb8b5db1 commit 939bcd2c20b42f550c7b89a52a105bfbbb8b5db1 Author: John Baldwin AuthorDate: 2025-01-03 16:03:08 +0000 Commit: John Baldwin CommitDate: 2025-03-03 16:56:20 +0000 cpu_set_upcall / linux_clone_thread: Remove calls to cpu_thread_clean This is intended to clean state of a thread at the end of its lifecycle during wait(), not the beginning of its life cycle. Reviewed by: kib Sponsored by: AFRL, DARPA Differential Revision: https://reviews.freebsd.org/D48023 (cherry picked from commit 0e742cc77454d0872ac2f6e7fd755b6d0322b711) --- sys/amd64/amd64/vm_machdep.c | 10 ---------- sys/compat/linux/linux_fork.c | 2 -- sys/i386/i386/vm_machdep.c | 10 ---------- 3 files changed, 22 deletions(-) diff --git a/sys/amd64/amd64/vm_machdep.c b/sys/amd64/amd64/vm_machdep.c index 9e77ac7af2d7..36001bc5b5b6 100644 --- a/sys/amd64/amd64/vm_machdep.c +++ b/sys/amd64/amd64/vm_machdep.c @@ -617,16 +617,6 @@ int cpu_set_upcall(struct thread *td, void (*entry)(void *), void *arg, stack_t *stack) { - - /* - * Do any extra cleaning that needs to be done. - * The thread may have optional components - * that are not present in a fresh thread. - * This may be a recycled thread so make it look - * as though it's newly allocated. - */ - cpu_thread_clean(td); - #ifdef COMPAT_FREEBSD32 if (SV_PROC_FLAG(td->td_proc, SV_ILP32)) { /* diff --git a/sys/compat/linux/linux_fork.c b/sys/compat/linux/linux_fork.c index 4ce3bc192b4e..1c9189162a09 100644 --- a/sys/compat/linux/linux_fork.c +++ b/sys/compat/linux/linux_fork.c @@ -301,8 +301,6 @@ linux_clone_thread(struct thread *td, struct l_clone_args *args) else em->child_clear_tid = NULL; - cpu_thread_clean(newtd); - linux_set_upcall(newtd, args->stack); PROC_LOCK(p); diff --git a/sys/i386/i386/vm_machdep.c b/sys/i386/i386/vm_machdep.c index e05791967fba..d252438dc186 100644 --- a/sys/i386/i386/vm_machdep.c +++ b/sys/i386/i386/vm_machdep.c @@ -492,16 +492,6 @@ int cpu_set_upcall(struct thread *td, void (*entry)(void *), void *arg, stack_t *stack) { - - /* - * Do any extra cleaning that needs to be done. - * The thread may have optional components - * that are not present in a fresh thread. - * This may be a recycled thread so make it look - * as though it's newly allocated. - */ - cpu_thread_clean(td); - /* * Set the trap frame to point at the beginning of the entry * function.