From owner-svn-src-head@freebsd.org Mon Jun 22 01:10:40 2020 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 5EBC933A661; Mon, 22 Jun 2020 01:10:40 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: from mail-qk1-x741.google.com (mail-qk1-x741.google.com [IPv6:2607:f8b0:4864:20::741]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 49qrv34Dv1z3gdB; Mon, 22 Jun 2020 01:10:39 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: by mail-qk1-x741.google.com with SMTP id e11so4889626qkm.3; Sun, 21 Jun 2020 18:10:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=b2GGEV2q1hpsnW5HsZYfl6k0p5QqxHN8l8/hlAxAq6E=; b=AKOj04QNFfWpkDJyxrfAh1W0H/pIQzUvfgUUvlg8ia69q8o56A22I3J/o9YScROW3c KDuOUBbts+3jIAlj33O20T2z+wKU6R4KHw2GzMInVTkVYR/5x9W0kNqW9GS8wi5cJXeM G5td12Ru0UNjhCJWkje0Rn14RF528JdFI16fPFerzHJKL2ggSO6dGiJaf/znwFeC7Efl +1i0iH3dK7zHEMHw78mg1oNfu8PA5gbQyZrU+lPovQi90Us19BBHU4hYDmfm+l3FUi7M ibeFk6iXGT6VnTxytPiUjA5zs/h87cVAEa+OWr2Q/L851/j6IK+LrN0Jg+AU5epHInR+ jwgQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to; bh=b2GGEV2q1hpsnW5HsZYfl6k0p5QqxHN8l8/hlAxAq6E=; b=L2XsM9vVO8mg491u3P7heGf3Kpph/Vwm6T7UE3pOe5UVvffgM+hhYNJg0ZU9RHZedd lKVlO0UxqcU2SsSWZMDOQv/JDf7MgsFhsmkPi3TNXfMICQWWEOO7ZO79ELizj07PziIJ FnF4DUtl8zuB5x3OmEz3AlzYnOcUoOw0iL1nRTeVTwJu+0LCEyy8Ju559O1ZYhmJY7jP TmS1d5Kvd8j+8aRRoXC1bJ8bS8EdPTl2z2JzBi3ig+j6iaGN1Ea0s3QxPF/pHnN8hRKx OC6hWDkIz8iRRIBirS7sjcbOL5GbeZ2QnPAMyOl/KN8vMV9JtiUO5WFxKYBQMjjLhsHQ AJAA== X-Gm-Message-State: AOAM531XAerOfNbUmUmUp4PzPn1ohuVT6AQK3OaWo+1WGTTL3OWtlpRX Y2tiLVyxWILnabvzdRZI4P+o7u7IuMY= X-Google-Smtp-Source: ABdhPJyEN+NrvJtd4vqvQqbt7orVTbRA/1jxabeF+O1QxI/wYaJDwRP6ZnWvlqNUAaimhC295Cymgw== X-Received: by 2002:a37:6150:: with SMTP id v77mr13648170qkb.173.1592788238172; Sun, 21 Jun 2020 18:10:38 -0700 (PDT) Received: from raichu (bras-base-toroon0560w-grc-20-184-147-206-12.dsl.bell.ca. [184.147.206.12]) by smtp.gmail.com with ESMTPSA id w45sm6507294qtj.51.2020.06.21.18.10.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 21 Jun 2020 18:10:37 -0700 (PDT) Sender: Mark Johnston Date: Sun, 21 Jun 2020 21:10:35 -0400 From: Mark Johnston To: John Baldwin Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r362338 - in head: share/man/man4 sys/conf sys/kern sys/netinet sys/netinet6 sys/netipsec sys/netpfil/pf Message-ID: <20200622011035.GG85944@raichu> References: <202006181932.05IJWZYH009560@repo.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 49qrv34Dv1z3gdB X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20161025 header.b=AKOj04QN; dmarc=none; spf=pass (mx1.freebsd.org: domain of markjdb@gmail.com designates 2607:f8b0:4864:20::741 as permitted sender) smtp.mailfrom=markjdb@gmail.com X-Spamd-Result: default: False [-2.26 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20161025]; NEURAL_HAM_MEDIUM(-1.00)[-0.997]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4000::/36:c]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; MID_RHS_NOT_FQDN(0.50)[]; DMARC_NA(0.00)[freebsd.org]; TO_DN_SOME(0.00)[]; NEURAL_HAM_LONG(-1.04)[-1.037]; RCVD_COUNT_THREE(0.00)[3]; DKIM_TRACE(0.00)[gmail.com:+]; NEURAL_HAM_SHORT(-0.53)[-0.530]; RCVD_IN_DNSWL_NONE(0.00)[2607:f8b0:4864:20::741:from]; FORGED_SENDER(0.30)[markj@freebsd.org,markjdb@gmail.com]; RECEIVED_SPAMHAUS_PBL(0.00)[184.147.206.12:received]; MIME_TRACE(0.00)[0:+]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; FROM_NEQ_ENVFROM(0.00)[markj@freebsd.org,markjdb@gmail.com]; RCVD_TLS_ALL(0.00)[] X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 22 Jun 2020 01:10:40 -0000 On Fri, Jun 19, 2020 at 08:33:35AM -0700, John Baldwin wrote: > On 6/18/20 12:32 PM, Mark Johnston wrote: > > Author: markj > > Date: Thu Jun 18 19:32:34 2020 > > New Revision: 362338 > > URL: https://svnweb.freebsd.org/changeset/base/362338 > > > > Log: > > Add the SCTP_SUPPORT kernel option. > > > > This is in preparation for enabling a loadable SCTP stack. Analogous to > > IPSEC/IPSEC_SUPPORT, the SCTP_SUPPORT kernel option must be configured > > in order to support a loadable SCTP implementation. > > > > Discussed with: tuexen > > MFC after: 2 weeks > > Sponsored by: The FreeBSD Foundation > > Do you want to add similar handling to sys/conf/config.mk that we have > for IPsec? Also, do we want to avoid building sctp.ko if it is in the > kernel like we do for ipsec.ko and/or only build it if the kernel contains > SCTP_SUPPORT? (For ipsec.ko we had to do that as it wouldn't compile, not > sure if the same is true for sctp.ko) Sorry for the delay. I think we do indeed want similar handling in config.mk, I will work on it. It is probably also reasonable to avoid compiling sctp.ko when SCTP_SUPPORT is not defined, though I can't see a reason that wouldn't work today since SCTP_SUPPORT is not used in any headers.