From owner-freebsd-current@freebsd.org Mon Aug 1 13:31:18 2016 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 8251EBAA307 for ; Mon, 1 Aug 2016 13:31:18 +0000 (UTC) (envelope-from gljennjohn@gmail.com) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id 5EDA412AF for ; Mon, 1 Aug 2016 13:31:18 +0000 (UTC) (envelope-from gljennjohn@gmail.com) Received: by mailman.ysv.freebsd.org (Postfix) id 5DD4CBAA303; Mon, 1 Aug 2016 13:31:18 +0000 (UTC) Delivered-To: current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 5D7CCBAA301 for ; Mon, 1 Aug 2016 13:31:18 +0000 (UTC) (envelope-from gljennjohn@gmail.com) Received: from mail-wm0-x244.google.com (mail-wm0-x244.google.com [IPv6:2a00:1450:400c:c09::244]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id DEF5812A7; Mon, 1 Aug 2016 13:31:17 +0000 (UTC) (envelope-from gljennjohn@gmail.com) Received: by mail-wm0-x244.google.com with SMTP id x83so26159720wma.3; Mon, 01 Aug 2016 06:31:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:cc:subject:message-id:in-reply-to:references:reply-to :mime-version:content-transfer-encoding; bh=2fCFMhcAAdI3fbfZdCHLVZRwpEeMI/rbEYiD4FtXnN4=; b=qHyhz6BVe6vlaSioDrABSPgkZjT6ejwXhpqRn64Hkr3Vvx/8nmWdTE1ScpkAevnk08 5vPJRcVyABvTOLAHuHbIZE+zh7K/Xj3S/duGGYaDK0fbTLI7+oZA+EWiRlG9Jd/qDLwK hVFlcBlMhJqAInERFcb4I/gOwEFNlnBaCZ19RYfHfJaS0lkZtkDme/NLglSgBDzCXbYE 7qj+cDl+Yht6HxDcjB+WE9Yj3IVcZW/t0AJOGFEymfYzJ6NUCoC4RTWgpWe/XwhgMNdp /YaK0Sfu/lrZpYSaFbopkvK5UxK6S8sUGw/U+5n/K7CPTmZw3Q6knonPvKRESsqooCEd wpGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:reply-to:mime-version:content-transfer-encoding; bh=2fCFMhcAAdI3fbfZdCHLVZRwpEeMI/rbEYiD4FtXnN4=; b=M3MbeBWsWIHIah8ALLTrvFUqsDpnTCJBqvC2H+IzDfJZSoAUOPBGRTjh049CQWi3qi iss5Sq7CQT0Rwrt/6EULkr88n82uS1h5Rf4aXfk05go8OPx+IJ3MOmZynuszoTSi7UxJ f3Hl59FJwZn0VZ063OwzbXiv6SzA7ccEJosu7AYwxSxG2dEYNlUVgjF9OblJpl9OebWX Z43EKXJSfpMRumuHCG/XzXoj7+Vj1aa9KYrCo19rzOw6I80YAlTu1bKshoP8b3sq5RqH Rcow2sXw9hMcQfxCgjea0Jq/batm0qCV5eHaBGldAunOGaB/FYdWHqkX9uxH5cehjDAy ni2A== X-Gm-Message-State: AEkooutcsoZp6oM7KcFsGZlaH5NMtt0/GZXV5jQDHGBtsHgFxz5lgoiyu/Mro/NO+vn0BA== X-Received: by 10.28.131.199 with SMTP id f190mr14083305wmd.30.1470058275265; Mon, 01 Aug 2016 06:31:15 -0700 (PDT) Received: from ernst.home (p578E09C6.dip0.t-ipconnect.de. [87.142.9.198]) by smtp.gmail.com with ESMTPSA id n2sm30660998wjd.1.2016.08.01.06.31.13 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 01 Aug 2016 06:31:14 -0700 (PDT) Date: Mon, 1 Aug 2016 15:31:11 +0200 From: Gary Jennejohn To: John Baldwin Cc: current@freebsd.org Subject: Re: EARLY_AP_STARTUP hangs during boot Message-ID: <20160801153111.5e59d3ce@ernst.home> In-Reply-To: <20160801093434.410032f4@ernst.home> References: <20160516122242.39249a54@ernst.home> <8097239.52FCHCROUA@ralph.baldwin.cx> <20160731112914.58bd9765@ernst.home> <1944919.bPt123bEA6@ralph.baldwin.cx> <20160801093434.410032f4@ernst.home> Reply-To: gljennjohn@gmail.com X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.29; amd64-portbld-freebsd11.0) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 01 Aug 2016 13:31:18 -0000 On Mon, 1 Aug 2016 09:34:34 +0200 Gary Jennejohn wrote: > On Sun, 31 Jul 2016 14:22:35 -0700 > John Baldwin wrote: > > > On Sunday, July 31, 2016 11:29:14 AM Gary Jennejohn wrote: > > > On Sat, 30 Jul 2016 12:03:59 -0700 > > > John Baldwin wrote: > > > > > > > On Saturday, July 30, 2016 09:44:22 AM Gary Jennejohn wrote: > > > > > On Fri, 29 Jul 2016 13:17:42 -0700 > > > > > John Baldwin wrote: > > > > > > > > > > > On Thursday, July 28, 2016 12:31:31 AM Gary Jennejohn wrote: > > > > > > > Well, now I know that ULE is a prerequiste for EARLY_AP_STARTUP! I > > > > > > > wasn't aware of that. I prefer BSD and that's the scheduler I did > > > > > > > the first tests with. > > > > > > > > > > > > > > But with the ULE scheduler the system comes up all the way. > > > > > > > > > > > > > > It would be nice if the BSD scheduler could also be modified to > > > > > > > work with EARLY_AP_STARTUP. > > > > > > > > > > > > I wasn't able to reproduce your hang with 4BSD, but I think I see a > > > > > > possible problem. Try this: > > > > > > > > > > > > diff --git a/sys/kern/sched_4bsd.c b/sys/kern/sched_4bsd.c > > > > > > index 7de56b6..d53331a 100644 > > > > > > --- a/sys/kern/sched_4bsd.c > > > > > > +++ b/sys/kern/sched_4bsd.c > > > > > > @@ -327,7 +327,6 @@ maybe_preempt(struct thread *td) > > > > > > * - The current thread has a higher (numerically lower) or > > > > > > * equivalent priority. Note that this prevents curthread from > > > > > > * trying to preempt to itself. > > > > > > - * - It is too early in the boot for context switches (cold is set). > > > > > > * - The current thread has an inhibitor set or is in the process of > > > > > > * exiting. In this case, the current thread is about to switch > > > > > > * out anyways, so there's no point in preempting. If we did, > > > > > > @@ -348,7 +347,7 @@ maybe_preempt(struct thread *td) > > > > > > ("maybe_preempt: trying to run inhibited thread")); > > > > > > pri = td->td_priority; > > > > > > cpri = ctd->td_priority; > > > > > > - if (panicstr != NULL || pri >= cpri || cold /* || dumping */ || > > > > > > + if (panicstr != NULL || pri >= cpri /* || dumping */ || > > > > > > TD_IS_INHIBITED(ctd)) > > > > > > return (0); > > > > > > #ifndef FULL_PREEMPTION > > > > > > @@ -1127,7 +1126,7 @@ forward_wakeup(int cpunum) > > > > > > if ((!forward_wakeup_enabled) || > > > > > > (forward_wakeup_use_mask == 0 && forward_wakeup_use_loop == 0)) > > > > > > return (0); > > > > > > - if (!smp_started || cold || panicstr) > > > > > > + if (!smp_started || panicstr) > > > > > > return (0); > > > > > > > > > > > > forward_wakeups_requested++; > > > > > > > > > > > > > > > > Thanks, but with this patch the kernel hangs in exactly the same > > > > > place as before - after the HPET output. > > > > > > > > > > Maybe I'm missing some kernel option which ULE works around, or > > > > > something like that. > > > > > > > > Hmm, ok. Please add KTR_RUNQ and KTR_SMP to the KTR masks, that is > > > > 'options KTR_COMPILE=(KTR_PROC|KTR_RUNQ|KTR_SMP)' and > > > > 'options KTR_MASK=(KTR_PROC|KTR_RUNQ|KTR_SMP)' > > > > > > > > Please also add this patch (on top of the previous patch): > > > > > > > > diff --git a/sys/kern/sched_4bsd.c b/sys/kern/sched_4bsd.c > > > > index 2973a23..bab2278 100644 > > > > --- a/sys/kern/sched_4bsd.c > > > > +++ b/sys/kern/sched_4bsd.c > > > > @@ -1278,6 +1278,8 @@ sched_add(struct thread *td, int flags) > > > > KASSERT(td->td_flags & TDF_INMEM, > > > > ("sched_add: thread swapped out")); > > > > > > > > + CTR2(KTR_PROC, "sched_add: thread %d (%s)", td->td_tid, > > > > + sched_tdname(td)); > > > > KTR_STATE2(KTR_SCHED, "thread", sched_tdname(td), "runq add", > > > > "prio:%d", td->td_priority, KTR_ATTR_LINKED, > > > > sched_tdname(curthread)); > > > > diff --git a/sys/x86/x86/cpu_machdep.c b/sys/x86/x86/cpu_machdep.c > > > > index f07b97e..1f418f1 100644 > > > > --- a/sys/x86/x86/cpu_machdep.c > > > > +++ b/sys/x86/x86/cpu_machdep.c > > > > @@ -440,6 +440,7 @@ cpu_idle_wakeup(int cpu) > > > > return (0); > > > > if (*state == STATE_MWAIT) > > > > *state = STATE_RUNNING; > > > > + CTR1(KTR_PROC, "cpu_idle_wakeup: wokeup CPU %d", cpu); > > > > return (1); > > > > } > > > > > > > > (I haven't tried compiling it, you might have to add the sys/ktr.h > > > > header to cpu_machdep.c if it doesn't build.) > > > > > > > > Hopefully we will get some better trace messages before it hangs > > > > with this added info. The root issue seems to be that 4BSD is > > > > pinning thread0 to some other CPU (due to sched_bind that happens > > > > inside of bus_bind_intr() when the HPET driver pins IRQs to CPUs) > > > > and that other CPU isn't waking up to realize it needs to run thread0. > > > > > > > > > > It compiled with no changes needed. > > > > > > Even though I set MAXCPU to a mere 2, the boot still hadn't > > > completed after 90 minutes and I broke it off. I still have > > > the kernel, so I can try it another time when I have less need > > > for my FreeBSD box. > > > > Did you have the KTR options enabled from before? I don't expect this > > to fix the issue, this is more about getting better debug info when it > > hangs. > > > > Yes, all the options from before were enabled. Maybe I should have > disabled KTR_VERBOSE=1? I'll try it without that. > KTR_VERBOSE=1 is necessary. OK, after about 5 hours it landed in an infinite loop emitting: cpu_0 ipi_cpu: cpu: 1 to 5 ipi: 2 (my CPU has 6 cores) -- Gary Jennejohn