Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 15 Feb 2023 04:26:21 +0000
From:      Alexey Dokuchaev <danfe@freebsd.org>
To:        Cy Schubert <Cy.Schubert@cschubert.com>
Cc:        Jan Beich <jbeich@freebsd.org>, Cy Schubert <cy@freebsd.org>, ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org
Subject:   Re: git: 57a30ab234a9 - main - net/tcpview: Fix build with LLVM15
Message-ID:  <Y%2Bxe7dWF724URxsK@FreeBSD.org>
In-Reply-To: <20230212033839.6259B28E@slippy.cwsent.com>
References:  <202302111441.31BEf32w000463@gitrepo.freebsd.org> <ilg8-nsea-wny@FreeBSD.org> <20230212033839.6259B28E@slippy.cwsent.com>

next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, Feb 11, 2023 at 07:38:39PM -0800, Cy Schubert wrote:
> ...
> The exact error, due to -Wint-conversion now being the default in LLVM15 --
> https://reviews.llvm.org/D129881.
> 
> detail-domain.c:449:13: error: incompatible pointer to integer conversion returning 'void *' from a function with result type 'int' [-Wint-conversion]
>             return NULL;
>                    ^~~~

So why not fix the broken code rather than suppress the useful warning?
New strict Clang already revealed several real bugs in various ports,
thus I encourage everyone not to silence the compiler, but examine and
address the actual problem with the code.

> Previously there would have been an exp-run prior to a new LLVM import
> allowing for better planning and staging than the current react mode.

There was an exp-run (PR 265425), but apparently dim@ concentrated on
trying to fix relatively high-profile ports which unblock N [other]
ports, so many affected leaf ports got under his radar.

./danfe



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Y%2Bxe7dWF724URxsK>