Date: Sat, 21 Aug 2004 17:15:22 +0200 (CEST) From: Stefan Walter <sw@gegenunendlich.de> To: FreeBSD-gnats-submit@FreeBSD.org Cc: hendrik@scholz.net Subject: ports/70774: [PATCH] multimedia/transcode: fix modfps filter Message-ID: <20040821151522.D43263B3A@kyuzo.dunkelkammer.void> Resent-Message-ID: <200408211520.i7LFK4rW042951@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 70774
>Category: ports
>Synopsis: [PATCH] multimedia/transcode: fix modfps filter
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: change-request
>Submitter-Id: current-users
>Arrival-Date: Sat Aug 21 15:20:04 GMT 2004
>Closed-Date:
>Last-Modified:
>Originator: Stefan Walter
>Release: FreeBSD 5.2-CURRENT i386
>Organization:
Infinity Approximation Task Force
>Environment:
System: FreeBSD kyuzo.dunkelkammer.void 5.2-CURRENT FreeBSD 5.2-CURRENT #0: Wed Jul 28 20:21:17 CEST 2004
>Description:
Transcode's modfps filter is currently not usable, as there is no
lrint() function on FreeBSD. When trying to use the filter ('-J
modfps'), you get the following warning:
[transcode] warning : loading filter module /usr/local/lib/transcode/filter_modfps.so failed
[transcode] warning : /usr/local/lib/transcode/filter_modfps.so: Undefined symbol "lrint"
The attached patch works around the problem and makes it possible to use
the filter. It is acquired from NetBSD's pkgsrc:
http://cvsweb.netbsd.org/bsdweb.cgi/pkgsrc/multimedia/transcode/patches/patch-av?rev=1.1&content-type=text/x-cvsweb-markup
(Tested exclusively on a FreeBSD-CURRENT that's a few weeks old, with
gcc 3.3.3.)
Port maintainer (hendrik@scholz.net) is cc'd.
Generated with FreeBSD Port Tools 0.50
>How-To-Repeat:
>Fix:
--- transcode-0.6.12_1.patch begins here ---
diff -ruN --exclude=CVS /usr/ports/multimedia/transcode.old/files/patch-filter:filter_modfps.c /usr/ports/multimedia/transcode/files/patch-filter:filter_modfps.c
--- /usr/ports/multimedia/transcode.old/files/patch-filter:filter_modfps.c Thu Jan 1 01:00:00 1970
+++ /usr/ports/multimedia/transcode/files/patch-filter:filter_modfps.c Sat Aug 21 14:12:41 2004
@@ -0,0 +1,16 @@
+--- filter/filter_modfps.c.old Sat Aug 21 13:11:20 2004
++++ filter/filter_modfps.c Sat Aug 21 13:13:33 2004
+@@ -77,6 +77,13 @@
+ #include "framebuffer.h"
+ #include "optstr.h"
+
++#if !defined(HAVE_LRINTF)
++static inline long int lrint(double x)
++{
++ return (long)(rint(x));
++}
++#endif
++
+ static int show_results=0;
+
+ /*-------------------------------------------------
--- transcode-0.6.12_1.patch ends here ---
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20040821151522.D43263B3A>