From owner-cvs-all Mon Oct 2 20:54:35 2000 Delivered-To: cvs-all@freebsd.org Received: from sasami.jurai.net (sasami.jurai.net [63.67.141.99]) by hub.freebsd.org (Postfix) with ESMTP id 1AF3237B502; Mon, 2 Oct 2000 20:54:31 -0700 (PDT) Received: from localhost (winter@localhost) by sasami.jurai.net (8.9.3/8.8.7) with ESMTP id XAA68739; Mon, 2 Oct 2000 23:54:30 -0400 (EDT) Date: Mon, 2 Oct 2000 23:54:29 -0400 (EDT) From: "Matthew N. Dodd" To: Takahashi Yoshihiro Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/release/sysinstall devices.c src/sys/conf files.pc98 src/sys/dev/snc dp83932.c dp83932reg.h dp83932subr.c dp83932subr.h dp83932var.h if_snc.c if_snc_cbus.c if_snc_pccard.c if_sncreg.h if_sncvar.h src/sys/modules Makefile ... In-Reply-To: <200010021427.HAA16733@freefall.freebsd.org> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG On Mon, 2 Oct 2000, Takahashi Yoshihiro wrote: > Added NEC PC-9801-83, 84, PC-9801-103, 104, PC-9801N-25 and PC-9801N-J02R > support which use National Semiconductor DP8393X (SONIC) as ethernet > controller. Currently, this driver is used on only PC-98. if_sn.c:snc_alloc_{port,memory,irq}() all need fixing in their handling of the failure case of bus_alloc_resource(). You can't rely on bus_get_resource()/bus_get_resource_start() to do the right thing if bus_alloc_resource() has already failed. You -must- check the return of bus_get_resource()/bus_get_resource_start(). I'd suggest punting as the failure case only prints out a cosmetic "this didn't work" message. -- | Matthew N. Dodd | '78 Datsun 280Z | '75 Volvo 164E | FreeBSD/NetBSD | | winter@jurai.net | 2 x '84 Volvo 245DL | ix86,sparc,pmax | | http://www.jurai.net/~winter | This Space For Rent | ISO8802.5 4ever | To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message