From owner-freebsd-current@freebsd.org Wed Sep 12 14:33:24 2018 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id CDCC11094FBA for ; Wed, 12 Sep 2018 14:33:24 +0000 (UTC) (envelope-from gelraen.ua@gmail.com) Received: from mail-lf1-x12e.google.com (mail-lf1-x12e.google.com [IPv6:2a00:1450:4864:20::12e]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 3BBD384F4B for ; Wed, 12 Sep 2018 14:33:24 +0000 (UTC) (envelope-from gelraen.ua@gmail.com) Received: by mail-lf1-x12e.google.com with SMTP id m26-v6so1914301lfb.0 for ; Wed, 12 Sep 2018 07:33:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=zcv9iHDTs9ls2gOzrtNnrCJyEgXNcK8BqyvH8+1lyxs=; b=LHVl8bJeKb87nc7j3FGLEbzkBIJBi5JpR4X9z3sW9kjHLh1Hk6dPRQair3WazLJ/FC ucOXXahlxPB+A4eYpmH3qH5DwUdf4qCPFOBK8oYVILv7WsaeC+c2ZBJ/5cjCTwii0BaH 4lqCEgQ/A9/zTwgb1PbIOiUPqXSAMYQZG8Ma7nbT1wwCilWGVjnqVRtMRqSmaRS563TK qyX/kZfypHnX+WVBtqFs/EzaJh0c66JC591ptEw6q8FU48bOFmP2jE6ShjIrIicW6GD7 zXtzVkNn9BRZfzuknvPVsaMX0CdsPZ4apzhsazNA2bOb2C+8s1/cArFtXeDC5DwQqxbv FcOg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=zcv9iHDTs9ls2gOzrtNnrCJyEgXNcK8BqyvH8+1lyxs=; b=j05rP111hCKijw0DDs4TluTrGF2T1OCXjMOT3UMpAyQSUoE81eAJz2DQgWVQ64JQw3 t9tEGTDG313JJhDgepv0nQt7hX1J1OAHLpYaHI30FNTSfnAyFwf7nAeMKnSgZFo9F19a WtkahM1d3V/Eg3ZzNzgKZRGP/r2V9aYxosf/M8UTOHhHlScdO2bE9aaGyX9vSIggPHMB UiEtYNOpcuOnk106gPgq19HamKGaxCsTMAo3svh7/S+8Z30oHzcKoUzh6rR8nREG48cn DD1jxjXcCbwMfq5rFitZ93n0gewyGLsa4eOc5XlI4xj+sqBe8RHxzcBnurrCSuSVF8fs Xxww== X-Gm-Message-State: APzg51BYarXH79XIWmpC6rs6C3hmy9lKfUGB5rmxEIv/IfVWJdFjguay dRgMZ6XnAeUlVB4UVcZekjEeWEYrsHGXBVb8gzI= X-Google-Smtp-Source: ANB0VdaEHL94nkcudimgexZgx5ciZ24y1atEcbdCPPFmZTxbsxnfqM0dZ/efVaasLmW08040sSYXTrF8BM2y92dsLe0= X-Received: by 2002:a19:c646:: with SMTP id w67-v6mr1818919lff.108.1536762802766; Wed, 12 Sep 2018 07:33:22 -0700 (PDT) MIME-Version: 1.0 References: <72380894-6f0c-30e9-b755-d79a8a38a1eb@gmail.com> In-Reply-To: <72380894-6f0c-30e9-b755-d79a8a38a1eb@gmail.com> From: Max Ignatenko Date: Wed, 12 Sep 2018 15:33:10 +0100 Message-ID: Subject: Re: r336876 breaks sysutils/acpi_call To: theron.tarigo@gmail.com Cc: freebsd-current X-Mailman-Approved-At: Wed, 12 Sep 2018 16:03:24 +0000 Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.27 X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 12 Sep 2018 14:33:25 -0000 Hi, Sorry for a late reply! First of all, thank you for taking time to investigate and even providing a fix (https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=230993) ! Your patch makes perfect sense to me and modifying userspace memory from kernel is indeed something I didn't consider to be a problem at the time. Second, I'm not actively participating in FreeBSD community and development at the moment, and if you're willing to take over sysutils/acpi_call - I'll be happy to cooperate. Otherwise, I'll try to take time to incorporate your fix in the few upcoming weeks. On Sun, 26 Aug 2018 at 04:51, Theron wrote: > > A recent change in CURRENT has sysutils/acpi_call reliably cause a > kernel panic when run on a Dell XPS laptop system. I bisected this to > r336876: Use SMAP on amd64. I would have thought that this is a simple > compatibility problem requiring only a port update, except that the same > kernel and acpi_call on different hardware are not affected. On the > problematic system, the kernel module loads without incident; it is when > executing ACPI commands, even normally harmless operations such as > requesting read-only constants, that the system freeze occurs. ACPI > functionality seems otherwise unaffected. > > Kernel debugging console and crash dumps are also broken on this system > (I suspect due to Intel graphics) however it is an unrelated problem, > and is only an excuse for my inability to provide any further crash > information. > > Having already bisected to the breaking commit, is there anything else I > should do to improve the chances this problem gets fixed, or are there > any hardware compatibility notes I may have missed? > > Theron >