From owner-freebsd-current@FreeBSD.ORG  Fri Aug 13 15:36:12 2004
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 02DE816A4CE
	for <freebsd-current@freebsd.org>;
	Fri, 13 Aug 2004 15:36:12 +0000 (GMT)
Received: from dan.emsphone.com (dan.emsphone.com [199.67.51.101])
	by mx1.FreeBSD.org (Postfix) with ESMTP id A2ECB43D1F
	for <freebsd-current@freebsd.org>;
	Fri, 13 Aug 2004 15:36:11 +0000 (GMT)
	(envelope-from dan@dan.emsphone.com)
Received: (from dan@localhost)
	by dan.emsphone.com (8.12.11/8.12.11) id i7DFa83N087884;
	Fri, 13 Aug 2004 10:36:08 -0500 (CDT)
	(envelope-from dan)
Date: Fri, 13 Aug 2004 10:36:07 -0500
From: Dan Nelson <dnelson@allantgroup.com>
To: Ilker Ozupak <ilkerozupak@yahoo.com>
Message-ID: <20040813153607.GF4198@dan.emsphone.com>
References: <200408131332.09164.ilkerozupak@yahoo.com>
	<20040813104934.GL87690@submonkey.net>
	<200408131436.12750.ilkerozupak@yahoo.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <200408131436.12750.ilkerozupak@yahoo.com>
X-OS: FreeBSD 5.2-CURRENT
X-message-flag: Outlook Error
User-Agent: Mutt/1.5.6i
cc: Ceri Davies <ceri@submonkey.net>
cc: freebsd-current@freebsd.org
Subject: Re: suid bit sshd
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 13 Aug 2004 15:36:12 -0000

In the last episode (Aug 13), Ilker Ozupak said:
> On Friday 13 August 2004 13:49, you wrote:
> > On Fri, Aug 13, 2004 at 01:31:52PM +0300, Ilker Ozupak wrote:
> > > sshd is not installed as setuid even make.conf modified according
> > > to docs. the fallowing output is just after install[kernel|world]
> > > and mergemaster
> > >
> > > <output>
> > > [root@pascal]:/usr/src $ ls -l /usr/sbin/sshd
> > > - -r-xr-xr-x  1 root  wheel  173480 Aug 13 12:24 /usr/sbin/sshd
> > > [root@pascal]:/usr/src $ grep SUID_SSH /etc/make.conf
> > > ENABLE_SUID_SSH=        true
> >
> > That controls whether /usr/bin/ssh gets a setuid bit or not.  You're
> > looking at the wrong binary.
>
> it is not setuid
> 
> [root@pascal]:~ $ ls -l /usr/bin/ssh
> - -r-xr-xr-x  2 root  wheel  95260 Aug 13 12:24 /usr/bin/ssh

That's because rev 1.19 of secure/usr.bin/ssh/Makefile accidentally
removed the install code that checks for ENABLE_SUID_SSH.  Apply this
patch and it will work again:

Index: /usr/src/secure/usr.bin/ssh/Makefile
===================================================================
RCS file: /home/ncvs/src/secure/usr.bin/ssh/Makefile,v
retrieving revision 1.28
diff -u -r1.28 Makefile
--- /usr/src/secure/usr.bin/ssh/Makefile	26 Feb 2004 11:26:46 -0000	1.28
+++ /usr/src/secure/usr.bin/ssh/Makefile	2 Jun 2004 06:39:33 -0000
@@ -2,6 +2,9 @@
 #
 
 PROG=	ssh
+.if defined(ENABLE_SUID_SSH)
+BINMODE=4555
+.endif
 CFLAGS+=-I${SSHDIR}
 LINKS=	${BINDIR}/ssh ${BINDIR}/slogin
 MAN=	ssh.1 ssh_config.5

 
-- 
	Dan Nelson
	dnelson@allantgroup.com