From owner-freebsd-acpi@FreeBSD.ORG Mon Feb 18 11:18:38 2008 Return-Path: Delivered-To: freebsd-acpi@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 37A5016A4C1 for ; Mon, 18 Feb 2008 11:18:38 +0000 (UTC) (envelope-from avg@icyb.net.ua) Received: from falcon.cybervisiontech.com (falcon.cybervisiontech.com [217.20.163.9]) by mx1.freebsd.org (Postfix) with ESMTP id E45DC13C45B for ; Mon, 18 Feb 2008 11:18:36 +0000 (UTC) (envelope-from avg@icyb.net.ua) Received: from localhost (localhost [127.0.0.1]) by falcon.cybervisiontech.com (Postfix) with ESMTP id 2385543D7FB for ; Mon, 18 Feb 2008 13:18:35 +0200 (EET) X-Virus-Scanned: Debian amavisd-new at falcon.cybervisiontech.com Received: from falcon.cybervisiontech.com ([127.0.0.1]) by localhost (falcon.cybervisiontech.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 9EPRF1qGmc1F for ; Mon, 18 Feb 2008 13:18:35 +0200 (EET) Received: from [10.2.1.87] (gateway.cybervisiontech.com.ua [88.81.251.18]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by falcon.cybervisiontech.com (Postfix) with ESMTP id 63D0543D681 for ; Mon, 18 Feb 2008 13:18:34 +0200 (EET) Message-ID: <47B96989.6070008@icyb.net.ua> Date: Mon, 18 Feb 2008 13:18:33 +0200 From: Andriy Gapon User-Agent: Thunderbird 2.0.0.9 (X11/20080123) MIME-Version: 1.0 To: freebsd-acpi@freebsd.org Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: acpi_throttle: quirk based on pci info X-BeenThere: freebsd-acpi@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: ACPI and power management development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Feb 2008 11:18:38 -0000 While looking for something else I accidentally noticed that acpi_throttle has one quirk for some early revisions of PIIX4 chipset and the quirk is enabled based on PCI info. I have a newer revision of PIIX4 so the quirk is not applicable in my case. Nevertheless I noticed that acpi_throttle is initialized before PCI bus driver, so when it calls pci_find_device() it always returns NULL and quirk is not applied. At least this is what I see in dmesg on my machine. I am reporting this for the sake of code correctness and also out of curiosity about how such ordering issues are handled. -- Andriy Gapon