From owner-cvs-src@FreeBSD.ORG Tue Jul 29 01:47:14 2008 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 801201065674 for ; Tue, 29 Jul 2008 01:47:14 +0000 (UTC) (envelope-from pyunyh@gmail.com) Received: from rv-out-0506.google.com (rv-out-0506.google.com [209.85.198.236]) by mx1.freebsd.org (Postfix) with ESMTP id 47B888FC0A for ; Tue, 29 Jul 2008 01:47:14 +0000 (UTC) (envelope-from pyunyh@gmail.com) Received: by rv-out-0506.google.com with SMTP id b25so5732692rvf.43 for ; Mon, 28 Jul 2008 18:47:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:received:received:date:from :to:cc:subject:message-id:reply-to:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=TG43mezzmAOUWLJv3sbKuErk6JNoOlTLBDyC2Yhc4Xg=; b=WklM8rnZ5dmwLofNEVeupMENJs9QThdxbt7WfYQWWc8/7CFLUoeuh5emTleiI489GG C1UVBHu8jRGwl+sdqqTtQjPlro2VOg/R6iLRttMl6v12ltOfTckIIqdexXIM4mflT826 /2LGqC2B8oo2pXCB4OHRhCEKGbwOKh1+ztwNU= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=date:from:to:cc:subject:message-id:reply-to:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; b=SwlOFnUnRlCtz5MNATn97EPRHFNcokAoAWijjG4hbtmk5/NL8EnSYF8M4MdACc7mel dB6J1znU44GvSInYX7mf/Ofgd+vy4C7xHTDCWk2VXq0zTyrMLSZqEoMDYapYVPGqn7uF MhspMOjqjI9RjjmUfF7ybRhm3BMy/f4s4c4FQ= Received: by 10.141.83.15 with SMTP id k15mr2687982rvl.74.1217294307668; Mon, 28 Jul 2008 18:18:27 -0700 (PDT) Received: from michelle.cdnetworks.co.kr ( [211.53.35.84]) by mx.google.com with ESMTPS id f21sm21413727rvb.0.2008.07.28.18.18.24 (version=TLSv1/SSLv3 cipher=RC4-MD5); Mon, 28 Jul 2008 18:18:26 -0700 (PDT) Received: from michelle.cdnetworks.co.kr (localhost.cdnetworks.co.kr [127.0.0.1]) by michelle.cdnetworks.co.kr (8.13.5/8.13.5) with ESMTP id m6T1GGDF096614 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 29 Jul 2008 10:16:16 +0900 (KST) (envelope-from pyunyh@gmail.com) Received: (from yongari@localhost) by michelle.cdnetworks.co.kr (8.13.5/8.13.5/Submit) id m6T1GEk6096613; Tue, 29 Jul 2008 10:16:14 +0900 (KST) (envelope-from pyunyh@gmail.com) Date: Tue, 29 Jul 2008 10:16:14 +0900 From: Pyun YongHyeon To: Peter Jeremy Message-ID: <20080729011614.GA96129@cdnetworks.co.kr> References: <200805270154.m4R1sjAn023638@repoman.freebsd.org> <20080728191208.GA40936@server.vk2pj.dyndns.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20080728191208.GA40936@server.vk2pj.dyndns.org> User-Agent: Mutt/1.4.2.1i Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org, Pyun YongHyeon Subject: Re: cvs commit: src/sys/conf NOTES files src/sys/modules Makefile src/sys/modules/jme Makefile X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: pyunyh@gmail.com List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 29 Jul 2008 01:47:14 -0000 On Tue, Jul 29, 2008 at 05:12:08AM +1000, Peter Jeremy wrote: > [A bit late but I only just noticed] > On 2008-May-27 01:54:45 +0000, Pyun YongHyeon wrote: > >yongari 2008-05-27 01:54:45 UTC > > > > FreeBSD src repository > > > > Modified files: > > sys/conf NOTES files > > sys/modules Makefile > > Added files: > > sys/modules/jme Makefile > > Log: > > Hook up jme(4) to the build. > > > > Revision Changes Path > > 1.1492 +1 -0 src/sys/conf/NOTES > ... > > Whilst you have included a comment about jme(4) in NOTES, there is no > associated 'device jme' line. All other NIC drivers have both a comment > line and an actual device line apart from msk(4) and stge(4) (both of > which you also committed). > > This bug has been carried through in your MFCs. > > Could you please update NOTES to include both lines for all three devices > in all relevant branches so ensure that LINT builds include these devices. > Done. I'll make sure to MFC the change. Thanks for pointing out! -- Regards, Pyun YongHyeon