From owner-svn-src-user@FreeBSD.ORG Tue Apr 27 19:47:39 2010 Return-Path: Delivered-To: svn-src-user@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id C706B106567F; Tue, 27 Apr 2010 19:47:39 +0000 (UTC) (envelope-from kmacy@FreeBSD.org) Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:4f8:fff6::2c]) by mx1.freebsd.org (Postfix) with ESMTP id B7B958FC1D; Tue, 27 Apr 2010 19:47:39 +0000 (UTC) Received: from svn.freebsd.org (localhost [127.0.0.1]) by svn.freebsd.org (8.14.3/8.14.3) with ESMTP id o3RJldWg004954; Tue, 27 Apr 2010 19:47:39 GMT (envelope-from kmacy@svn.freebsd.org) Received: (from kmacy@localhost) by svn.freebsd.org (8.14.3/8.14.3/Submit) id o3RJldRU004952; Tue, 27 Apr 2010 19:47:39 GMT (envelope-from kmacy@svn.freebsd.org) Message-Id: <201004271947.o3RJldRU004952@svn.freebsd.org> From: Kip Macy Date: Tue, 27 Apr 2010 19:47:39 +0000 (UTC) To: src-committers@freebsd.org, svn-src-user@freebsd.org X-SVN-Group: user MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Cc: Subject: svn commit: r207290 - user/kmacy/head_page_lock_2/sys/vm X-BeenThere: svn-src-user@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the experimental " user" src tree" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 27 Apr 2010 19:47:39 -0000 Author: kmacy Date: Tue Apr 27 19:47:39 2010 New Revision: 207290 URL: http://svn.freebsd.org/changeset/base/207290 Log: add missed unlocks in vm_object_clean Modified: user/kmacy/head_page_lock_2/sys/vm/vm_object.c Modified: user/kmacy/head_page_lock_2/sys/vm/vm_object.c ============================================================================== --- user/kmacy/head_page_lock_2/sys/vm/vm_object.c Tue Apr 27 19:45:16 2010 (r207289) +++ user/kmacy/head_page_lock_2/sys/vm/vm_object.c Tue Apr 27 19:47:39 2010 (r207290) @@ -844,6 +844,7 @@ vm_object_page_clean(vm_object_t object, * page (i.e. had to sleep) and always unlocks p. */ tscan += vm_object_page_collect_flush(object, p, curgeneration, pagerflags); + vm_page_unlock(p); } /* @@ -920,17 +921,21 @@ again: /* Always unlocks p. */ n = vm_object_page_collect_flush(object, p, curgeneration, pagerflags); - if (n == 0) + if (n == 0) { + vm_page_unlock(p); goto rescan; + } - if (object->generation != curgeneration) + if (object->generation != curgeneration) { + vm_page_unlock(p); goto rescan; - + } /* * Try to optimize the next page. If we can't we pick up * our (random) scan where we left off. */ if (msync_flush_flags & MSYNC_FLUSH_SOFTSEQ) { + vm_page_unlock(p); if ((p = vm_page_lookup(object, pi + n)) != NULL) goto again; }