From owner-freebsd-fs@freebsd.org Sun Jan 13 23:56:16 2019 Return-Path: Delivered-To: freebsd-fs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 240E2148D20A for ; Sun, 13 Jan 2019 23:56:16 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id 9BBF69727D for ; Sun, 13 Jan 2019 23:56:15 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.ysv.freebsd.org (Postfix) id 5F2BD148D209; Sun, 13 Jan 2019 23:56:15 +0000 (UTC) Delivered-To: fs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 3CBAE148D208 for ; Sun, 13 Jan 2019 23:56:15 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.ysv.freebsd.org (mxrelay.ysv.freebsd.org [IPv6:2001:1900:2254:206a::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.ysv.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id D0CCA9727B for ; Sun, 13 Jan 2019 23:56:14 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.ysv.freebsd.org (Postfix) with ESMTPS id F403ABABD for ; Sun, 13 Jan 2019 23:56:13 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id x0DNuDLr027829 for ; Sun, 13 Jan 2019 23:56:13 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id x0DNuDKr027828 for fs@FreeBSD.org; Sun, 13 Jan 2019 23:56:13 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: fs@FreeBSD.org Subject: [Bug 234906] kernel panic: softdep_setup_inomapdep: dependency 0xfffff80107d15c00 for newinode already exists Date: Sun, 13 Jan 2019 23:56:14 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 12.0-RELEASE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: cem@freebsd.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: fs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 13 Jan 2019 23:56:16 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D234906 --- Comment #16 from Conrad Meyer --- Re secondary panic, we drop UMP lock around setup_inomapdep, but that shoul= d be ok because we still hold the CG buf exclusively -- no one else should be ab= le to allocate the same inode number. I think the panic could be explained by the inode being allocated but unreferenced in the CG bitmap. Possibly due to violation of ordering constraints implied by the first panic =E2=80=94 e.g., inode and directory = entry written, but CG bitmap stale. Or perhaps dirent is stale. Or possibly due= to write-cache enabled disk (which is another way SU ordering constraints can = be violated). But the handle_written_bmsafemap <-> softdep_setup_inomapdep li= nk is suspicious to me and I suspect they are directly related. I would guess CG bitmap accuracy is enforced for non-SU filesystems by a mo= re thorough fsck on dirty mount, but might be mistaken. On non-SU we would not hit this panic because the inodedep would not exist, of course. But we wou= ld hit 'ffs_valloc: dup alloc' shortly afterwards when we noticed the dinode w= as already initialized. Either way, (as far as I can tell) path lookup does not confirm that an ino= de referred to by a directory entry is actually allocated in the CG bitmap. I= t is simply assumed to be consistent. So you might have an active UFS vnode with that inode number with inodedeps for a variety of reasons, and some thread comes along and tries to create a file; that number is free in the CG bitma= p, so the second thread acquires it; and then the creating thread collides with the existing softdep work. I don't know of a good way to fix the secondary panic. A good next step would be to determine if your drives have write caching disabled, and if the drive model is known to respect that bit or not. --=20 You are receiving this mail because: You are the assignee for the bug.=