From owner-cvs-all@FreeBSD.ORG Mon Feb 18 14:26:30 2008 Return-Path: Delivered-To: cvs-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 8B3A216A46E; Mon, 18 Feb 2008 14:26:30 +0000 (UTC) (envelope-from yar@comp.chem.msu.su) Received: from comp.chem.msu.su (comp.chem.msu.su [158.250.32.97]) by mx1.freebsd.org (Postfix) with ESMTP id EF52B13C50C; Mon, 18 Feb 2008 14:26:29 +0000 (UTC) (envelope-from yar@comp.chem.msu.su) Received: from comp.chem.msu.su (localhost [127.0.0.1]) by comp.chem.msu.su (8.13.4/8.13.4) with ESMTP id m1IEQR1D066648; Mon, 18 Feb 2008 17:26:27 +0300 (MSK) (envelope-from yar@comp.chem.msu.su) Received: (from yar@localhost) by comp.chem.msu.su (8.13.4/8.13.4/Submit) id m1IEQQIB066643; Mon, 18 Feb 2008 17:26:26 +0300 (MSK) (envelope-from yar) Date: Mon, 18 Feb 2008 17:26:26 +0300 From: Yar Tikhiy To: Dag-Erling Sm??rgrav Message-ID: <20080218142626.GI30694@comp.chem.msu.su> References: <200802141704.m1EH4VL4099009@repoman.freebsd.org> <86y79i5syt.fsf@ds4.des.no> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <86y79i5syt.fsf@ds4.des.no> User-Agent: Mutt/1.5.9i Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern vfs_mount.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Feb 2008 14:26:30 -0000 On Mon, Feb 18, 2008 at 01:50:34PM +0100, Dag-Erling Sm??rgrav wrote: > Yar Tikhiy writes: > > Log: > > In the new order of things dictated by nmount(2), a read-only mount > > is to be requested via a "ro" option. At the same time, MNT_RDONLY > > is gradually becoming an indicator of the current state of the FS > > instead of a command flag. Today passing MNT_RDONLY alone to the > > kernel's mount machinery will lead to various glitches. (See the > > PRs for examples.) > > > > Therefore mount the root FS with a "ro" option instead of the > > MNT_RDONLY flag. (Note that MNT_RDONLY still is added to the mount > > flags internally, by vfs_donmount(), if "ro" was specified.) > > Can you guarantee that this will not f*** up the bootp / dhcp + nfsroot > case? There are dragons in that code which were decidedly not funny to > track down and fix. Indeed; or, as a Russian proverb has it, "Just don't touch the sh*t, and it won't stink". :-) But, fortunately, I've just had a chance to test this WRT the NFS_ROOT case. Thank Daemon, that code path is much clearer now than it used to be in the 4.4BSD days. -- Yar