Date: Thu, 15 Jul 2021 16:38:53 +0200 From: Guido Falsi <madpilot@FreeBSD.org> To: Alexey Dokuchaev <danfe@freebsd.org> Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: dc9bf7d64926 - main - net/asterisk*: Add aarch64 support Message-ID: <81bc6b76-7b74-9990-d7dc-54ca14b0ee4f@FreeBSD.org> In-Reply-To: <YO%2BYP1TDjq6MruvC@FreeBSD.org> References: <202107141033.16EAX60T044972@gitrepo.freebsd.org> <YO%2BYP1TDjq6MruvC@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 15/07/21 04:06, Alexey Dokuchaev wrote: > On Wed, Jul 14, 2021 at 10:33:06AM +0000, Guido Falsi wrote: >> commit dc9bf7d649260fd6c1d3310b2077c3c98cd19c6a >> >> net/asterisk*: Add aarch64 support >> >> User testing reports asterisk compiles and works fine on aarch64. >> >> ... >> EXPIRATION_DATE=2021-10-24 >> >> -ONLY_FOR_ARCHS= amd64 armv6 armv7 i386 powerpc powerpc64 powerpc64le sparc64 >> +ONLY_FOR_ARCHS= aarch64 amd64 armv6 armv7 i386 powerpc powerpc64 powerpc64le sparc64 > > I think ONLY_FOR_ARCHS here clearly outlived its purpose and can just > be removed. It arguably misses MIPS, but we aren't promising much for > that tier anyways, and this harness just gets in the way of those who > know that they're doing. After all, there shouldn't be anything > inherently architecture-specific about the telephony toolkit, but even > if there is, individual BROKEN_$arch would be more appropriate. > The fact that mips is not included is exactly the reason I did not remove ONLY_FOR_ARCHS. If what you say is the general consensus I'll be quite happy to get rid of it. For the record, asterisk used to fail on many architectures due to some C language constructs it uses which were not supported by older compilers in some cases, especially for more exotic architectures still using older compilers or less supported by the compilers being used. I guess this compiler mix situation is not an issue anymore. -- Guido Falsi <madpilot@FreeBSD.org>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?81bc6b76-7b74-9990-d7dc-54ca14b0ee4f>