From owner-svn-src-all@freebsd.org Sat Feb 17 15:02:12 2018 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id DCDA9F16137; Sat, 17 Feb 2018 15:02:11 +0000 (UTC) (envelope-from byond.lenox@gmail.com) Received: from mail-lf0-f43.google.com (mail-lf0-f43.google.com [209.85.215.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 31AFE8359F; Sat, 17 Feb 2018 15:02:10 +0000 (UTC) (envelope-from byond.lenox@gmail.com) Received: by mail-lf0-f43.google.com with SMTP id f137so7705410lfe.4; Sat, 17 Feb 2018 07:02:10 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=eLkoXLAi8i+56rbZPNHGbvYi8vt8xvk8s4LzVje2YJA=; b=QApZxyIZBlw082I8wVZAVQorRZj+3rH/1HII7cN8mmu+lM0Wgqs0C82nCfKbuXodzw +AOkD4/V0ATImMhO/uXBha3Jjshdnq6WZT1XKks4WwbQYvpLuR+zp0clK951MnLgvYZX 8nnU5YCE6UrKdgUMzIRvpOAzLqBBf22TKYa/IZy9RdOl/bNOsPAWaVNSYmvkN4xKT6qS 215OHDzn/S4i5G0NZXPl+ow7N8eb4KqLq7qK3xbtXqlsWFIUMM3VqOqAb6Ql0jVvNvr9 3uVC6I/jjpdlLwT274ycVnRzavTH4DzE0+h52ybu69cZ2PMDt1mp44BRRPlGIZN3ciZp VGIQ== X-Gm-Message-State: APf1xPBeoEP6airBZ+zNjSq9uHaWAWAPiaIbl34RyXrUskQ81yN5kgCc VqHFGNVwsPudn9hNOlKiEkN/8vFU X-Google-Smtp-Source: AH8x224/+BVlhpnnYXoag2fsi2tgAh73HDG7l7uCBWq3rIrd09K0IsD+Uv6fidAwVfxPSNYaQkcqHg== X-Received: by 10.46.73.81 with SMTP id b17mr6696870ljd.122.1518879729119; Sat, 17 Feb 2018 07:02:09 -0800 (PST) Received: from mail-lf0-f51.google.com (mail-lf0-f51.google.com. [209.85.215.51]) by smtp.gmail.com with ESMTPSA id b27sm2775018ljb.84.2018.02.17.07.02.08 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 17 Feb 2018 07:02:08 -0800 (PST) Received: by mail-lf0-f51.google.com with SMTP id q69so7691061lfi.10; Sat, 17 Feb 2018 07:02:08 -0800 (PST) X-Received: by 10.46.44.8 with SMTP id s8mr6109234ljs.51.1518879728640; Sat, 17 Feb 2018 07:02:08 -0800 (PST) MIME-Version: 1.0 Received: by 10.46.106.8 with HTTP; Sat, 17 Feb 2018 07:02:07 -0800 (PST) Received: by 10.46.106.8 with HTTP; Sat, 17 Feb 2018 07:02:07 -0800 (PST) In-Reply-To: References: <201802171430.w1HEUdxO059087@repo.freebsd.org> <201802171439.w1HEdZD5068048@pdx.rh.CN85.dnsmgr.net> From: Kyle Evans Date: Sat, 17 Feb 2018 09:02:07 -0600 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r329457 - head/stand/lua To: rgrimes@freebsd.org Cc: src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.25 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 17 Feb 2018 15:02:12 -0000 On Feb 17, 2018 8:39 AM, "Rodney W. Grimes" wrote: [ Charset UTF-8 unsupported, converting... ] > Author: kevans > Date: Sat Feb 17 14:30:39 2018 > New Revision: 329457 > URL: https://svnweb.freebsd.org/changeset/base/329457 > > Log: > stand/lua: dumpModules => lsModules > > rgrimes@ notes that this behavior is more befitting of the latter name than > the former, and I'm inclined to agree. > > Reported by: rgrimes > > Modified: > head/stand/lua/config.lua > > Modified: head/stand/lua/config.lua > ============================================================ ================== > --- head/stand/lua/config.lua Sat Feb 17 13:32:29 2018 (r329456) > +++ head/stand/lua/config.lua Sat Feb 17 14:30:39 2018 (r329457) > @@ -37,7 +37,7 @@ function config.setKey(k, n, v) > modules[k][n] = v; > end > > -function config.dumpModules() > +function config.lsModules() > print("== Dumping modules"); ^^^^^^^ I was more after this word :) > for k, v in pairs(modules) do > print(k, v.load); > > (apologies for the broken quoting, no longer near a reasonable mail client) Feel free to change it- I personally believe it's pretty obvious from the context once you see this message that these things are being dumped out to the console. It wasn't necessarily obvious from the name of the function that this was the case. Either way, this is purely a debugging aide while I was trying to figure out why it wasn't loading modules on kernel change. I don't really care much about the output as long as it still tells me just as much as it does now. As an aside, for anyone interested that reads this far, it's still handling module_path wrong but in a more subtle way. Every kernel change prepends the kernel path to module_path, and we keep building on this. Eventually you'd end up with: "/boot/kernel.GENERIC;/boot/kernel;..." So it may fallback to another kernel path for modules that may or may not match the current kernel version.