From owner-freebsd-current@FreeBSD.ORG Mon Mar 16 20:10:02 2009 Return-Path: Delivered-To: current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 2880E106564A for ; Mon, 16 Mar 2009 20:10:02 +0000 (UTC) (envelope-from cokane@FreeBSD.org) Received: from mail-out1.fuse.net (mail-out1.fuse.net [216.68.8.175]) by mx1.freebsd.org (Postfix) with ESMTP id 8C4F78FC08 for ; Mon, 16 Mar 2009 20:10:01 +0000 (UTC) (envelope-from cokane@FreeBSD.org) X-CNFS-Analysis: v=1.0 c=1 a=xgXaKvvpysUA:10 a=VdK7-obbqX0A:10 a=6I5d2MoRAAAA:8 a=9JIfFU07cOActQEztE4A:9 a=jFviNGBfAntndDSzbhwA:7 a=qHTR4_ig4OAGKh3fuVcu4ElAeKQA:4 a=XF7b4UCPwd8A:10 a=SV7veod9ZcQA:10 a=eWPWW3wkdogB2q3AEgUA:9 a=zWMAHbQ1mdvlIKah-WtNAcKbzRUA:4 a=rPt6xJ-oxjAA:10 X-CM-Score: 0 X-Scanned-by: Cloudmark Authority Engine Authentication-Results: gwout1 smtp.mail=cokane@FreeBSD.org; spf=softfail Received-SPF: softfail (gwout1: transitional domain FreeBSD.org does not designate 74.215.227.9 as permitted sender) Received: from [74.215.227.9] ([74.215.227.9:50488] helo=discordia) by gwout1 (envelope-from ) (ecelerity 2.2.2.37 r(28805/28810M)) with ESMTP id 0F/37-27669-39EAEB94; Mon, 16 Mar 2009 15:55:00 -0400 Received: by discordia (Postfix, from userid 103) id C273E35A7E4; Mon, 16 Mar 2009 15:54:59 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.1.8-gr1 (2007-02-13) on discordia X-Spam-Level: X-Spam-Status: No, score=-4.3 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.1.8-gr1 Received: from [172.31.1.6] (unknown [172.31.1.6]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by discordia (Postfix) with ESMTP id E214435A7E3; Mon, 16 Mar 2009 15:54:52 -0400 (EDT) From: Coleman Kane To: Sam Leffler In-Reply-To: <49BC1C66.7030400@freebsd.org> References: <1236937253.2282.0.camel@localhost> <49BAEA9F.8020302@incunabulum.net> <49BB0D3E.2020306@incunabulum.net> <49BC1C66.7030400@freebsd.org> Content-Type: multipart/signed; micalg="pgp-sha1"; protocol="application/pgp-signature"; boundary="=-jfxLpbIN2j5WK690VAs3" Organization: FreeBSD Project Date: Mon, 16 Mar 2009 15:53:30 -0400 Message-Id: <1237233210.84180.20.camel@localhost> Mime-Version: 1.0 X-Mailer: Evolution 2.24.5 FreeBSD GNOME Team Port Cc: Bruce Simpson , current@freebsd.org, freebsd-net Subject: Re: IGMP+WiFi panic on recent kernel - in igmp_fasttimo() X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 Mar 2009 20:10:02 -0000 --=-jfxLpbIN2j5WK690VAs3 Content-Type: text/plain Content-Transfer-Encoding: quoted-printable The crash that I am seeing (using if_ndis) occurs in igmp_fasttimo... This patch doesn't fix that, I'll get more info as soon as I can. On Sat, 2009-03-14 at 14:06 -0700, Sam Leffler wrote: > This patches avoids the crash. Not sure how ifma_protospec is supposed=20 > to be handled so I'm not committing it. >=20 > Sam >=20 > plain text document attachment (mcast.patch) > Index: in.c > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > --- in.c (revision 189750) > +++ in.c (working copy) > @@ -1040,7 +1040,8 @@ > */ > IF_ADDR_LOCK(ifp); > TAILQ_FOREACH(ifma, &ifp->if_multiaddrs, ifma_link) { > - if (ifma->ifma_addr->sa_family !=3D AF_INET) > + if (ifma->ifma_addr->sa_family !=3D AF_INET || > + ifma->ifma_protospec =3D=3D NULL) > continue; > inm =3D (struct in_multi *)ifma->ifma_protospec; > LIST_INSERT_HEAD(&purgeinms, inm, inm_link); > Index: igmp.c > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > --- igmp.c (revision 189750) > +++ igmp.c (working copy) > @@ -623,7 +623,8 @@ > if (igi->igi_version =3D=3D IGMP_VERSION_3) { > IF_ADDR_LOCK(ifp); > TAILQ_FOREACH(ifma, &ifp->if_multiaddrs, ifma_link) { > - if (ifma->ifma_addr->sa_family !=3D AF_INET) > + if (ifma->ifma_addr->sa_family !=3D AF_INET || > + ifma->ifma_protospec =3D=3D NULL) > continue; > inm =3D (struct in_multi *)ifma->ifma_protospec; > if (inm->inm_state =3D=3D IGMP_LEAVING_MEMBER) { > _______________________________________________ > freebsd-current@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-current > To unsubscribe, send any mail to "freebsd-current-unsubscribe@freebsd.org= " --=20 Coleman Kane --=-jfxLpbIN2j5WK690VAs3 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (FreeBSD) iEYEABECAAYFAkm+rjIACgkQcMSxQcXat5ceLwCeKuZZnl8aE59M5vaukNPp2Atk yPYAn0kq9fciOvjO/vKZj+8zh6qxsTXL =hjdk -----END PGP SIGNATURE----- --=-jfxLpbIN2j5WK690VAs3--