Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 23 Jul 2012 17:25:58 -0700
From:      Garrett Cooper <yanegomi@gmail.com>
To:        Warner Losh <imp@bsdimp.com>
Cc:        svn-src-head@freebsd.org, Alexey Dokuchaev <danfe@freebsd.org>, Gleb Smirnoff <glebius@freebsd.org>, src-committers@freebsd.org, svn-src-all@freebsd.org
Subject:   Re: svn commit: r238672 - head/sys/dev/sdhci
Message-ID:  <CAGH67wQGd6xWGPW4S=GYss-bjmxdY1AWjHZcBbO3v1yW_3qLsg@mail.gmail.com>
In-Reply-To: <523C5041-527B-4DBC-85E1-4AE846B014E6@bsdimp.com>
References:  <201207211407.q6LE7h9P042318@svn.freebsd.org> <20120721153026.GA8640@FreeBSD.org> <20120723071227.GE85230@FreeBSD.org> <CAGH67wR4aug9mF=UDc6w6AuiDyE0LQ7d38ffGDqtWQ_jRt0uKw@mail.gmail.com> <523C5041-527B-4DBC-85E1-4AE846B014E6@bsdimp.com>

next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Jul 23, 2012 at 5:07 PM, Warner Losh <imp@bsdimp.com> wrote:
>
> On Jul 23, 2012, at 1:28 AM, Garrett Cooper wrote:
>
>> On Mon, Jul 23, 2012 at 12:12 AM, Gleb Smirnoff <glebius@freebsd.org> wr=
ote:
>>> On Sat, Jul 21, 2012 at 03:30:26PM +0000, Alexey Dokuchaev wrote:
>>> A> On Sat, Jul 21, 2012 at 02:07:43PM +0000, Gleb Smirnoff wrote:
>>> A> > Author: glebius
>>> A> > Date: Sat Jul 21 14:07:43 2012
>>> A> > New Revision: 238672
>>> A> > URL: http://svn.freebsd.org/changeset/base/238672
>>> A> >
>>> A> > Log:
>>> A> >   Fix typo in comment, should be MHz here.
>>> A>
>>> A> That's nice, but...
>>> A>
>>> A> > @@ -364,7 +364,7 @@ sdhci_lower_frequency(device_t dev)
>>> A> >
>>> A> >    /*
>>> A> >     * Some SD/MMC cards don't work with the default base
>>> A> > -   * clock frequency of 200MHz.  Lower it to 50Hz.
>>> A> > +   * clock frequency of 200MHz. Lower it to 50MHz.
>>> A>
>>> A> ... Why losing 2-space break after a sentence (per what we are gener=
ally
>>> A> adhering and AFAIR is suggested by Chicago Style Guide)?
>>>
>>> Never heard about this rule. Sorry.
>>
>>    Actually, English spacing is discouraged in more recent texts; it
>> was encouraged during the late 19th century up until the late 20th
>> century according to ye great wikipedia [1], but I've read several
>> other articles in the past decade that suggest that the English
>> spacing convention be completely abolished.
>>    FWIW, I'd just follow surrounding style like style(9) suggests. No
>> reason for fighting over an extra byte per sentence in a source file
>> (unless you consider how much added bandwidth / disk space those
>> precious bytes can consume :)...).
>> Thanks,
>> -Garrett
>>
>> 1. http://en.wikipedia.org/wiki/History_of_sentence_spacing#French_and_E=
nglish_spacing
>
> Double spacing is the one true way I learned how to type in school.  Sinc=
e the 1980's though, things have changed and many advocate single spaces.  =
However, that's for folks with fancy variable pitch font and such.  For fix=
ed-witdh fonts, 2 is still preferred in some circles, including ours.

    And now that I look at style(9), there are subtleties that
demonstrate this in the roff generated text:

=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D

     FreeBSD source tree.  It is also a guide for the preferred userland co=
de
                                       ^^
     style.  Many of the style rules are implicit in the examples.  Be care=
ful
             ^^
                       ^^
     to check the examples before assuming that style is silent on an issue=
.

=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D

    I wish this point was more explicit, but like style(9), there are
other unspoken rules that should/must be adhered to.
Thanks,
-Garrett



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAGH67wQGd6xWGPW4S=GYss-bjmxdY1AWjHZcBbO3v1yW_3qLsg>