From owner-svn-src-all@FreeBSD.ORG Tue Jul 24 00:25:59 2012 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id CBCEC1065670; Tue, 24 Jul 2012 00:25:59 +0000 (UTC) (envelope-from yanegomi@gmail.com) Received: from mail-yx0-f182.google.com (mail-yx0-f182.google.com [209.85.213.182]) by mx1.freebsd.org (Postfix) with ESMTP id 351798FC08; Tue, 24 Jul 2012 00:25:59 +0000 (UTC) Received: by yenl8 with SMTP id l8so7181869yen.13 for ; Mon, 23 Jul 2012 17:25:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; bh=+udzsrLp67vEtbA8dENSFoGi3R6yka2ekXII2BwBoQA=; b=BH1wovVYNnfHO5JZDBnGkD8c9UJtvB18trAqiHlWoI4fRcka+fQHyB9OOl/ST1hcVp BRzzcGRvJskF22baxkHkcJWgzb9a3EdFOf7YYmA126a+3MJlfRkDt5wyP/EkBiSCF+YV GMibHJUbuEYHCPiNWA3No0dpGAcTdMUxHAa6xfCmv6KihHkt61FJ5xMOp2ruJGDH+V9U lgc9FlG7TdCjgG0SHzOMC01/Dpukvf7XKeQdnxy/b3+uzU1UxqiFJluMgviO+1mGdsaq 7ochf0WfO5z15lbW6SK3Can5TwwjnQLjNIXGw/e3EIQqBOZLomtoB16Bds5eOJX8ojKa fuiQ== MIME-Version: 1.0 Received: by 10.236.153.39 with SMTP id e27mr16791410yhk.130.1343089558749; Mon, 23 Jul 2012 17:25:58 -0700 (PDT) Received: by 10.76.84.7 with HTTP; Mon, 23 Jul 2012 17:25:58 -0700 (PDT) In-Reply-To: <523C5041-527B-4DBC-85E1-4AE846B014E6@bsdimp.com> References: <201207211407.q6LE7h9P042318@svn.freebsd.org> <20120721153026.GA8640@FreeBSD.org> <20120723071227.GE85230@FreeBSD.org> <523C5041-527B-4DBC-85E1-4AE846B014E6@bsdimp.com> Date: Mon, 23 Jul 2012 17:25:58 -0700 Message-ID: From: Garrett Cooper To: Warner Losh Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Cc: svn-src-head@freebsd.org, Alexey Dokuchaev , Gleb Smirnoff , src-committers@freebsd.org, svn-src-all@freebsd.org Subject: Re: svn commit: r238672 - head/sys/dev/sdhci X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Jul 2012 00:26:00 -0000 On Mon, Jul 23, 2012 at 5:07 PM, Warner Losh wrote: > > On Jul 23, 2012, at 1:28 AM, Garrett Cooper wrote: > >> On Mon, Jul 23, 2012 at 12:12 AM, Gleb Smirnoff wr= ote: >>> On Sat, Jul 21, 2012 at 03:30:26PM +0000, Alexey Dokuchaev wrote: >>> A> On Sat, Jul 21, 2012 at 02:07:43PM +0000, Gleb Smirnoff wrote: >>> A> > Author: glebius >>> A> > Date: Sat Jul 21 14:07:43 2012 >>> A> > New Revision: 238672 >>> A> > URL: http://svn.freebsd.org/changeset/base/238672 >>> A> > >>> A> > Log: >>> A> > Fix typo in comment, should be MHz here. >>> A> >>> A> That's nice, but... >>> A> >>> A> > @@ -364,7 +364,7 @@ sdhci_lower_frequency(device_t dev) >>> A> > >>> A> > /* >>> A> > * Some SD/MMC cards don't work with the default base >>> A> > - * clock frequency of 200MHz. Lower it to 50Hz. >>> A> > + * clock frequency of 200MHz. Lower it to 50MHz. >>> A> >>> A> ... Why losing 2-space break after a sentence (per what we are gener= ally >>> A> adhering and AFAIR is suggested by Chicago Style Guide)? >>> >>> Never heard about this rule. Sorry. >> >> Actually, English spacing is discouraged in more recent texts; it >> was encouraged during the late 19th century up until the late 20th >> century according to ye great wikipedia [1], but I've read several >> other articles in the past decade that suggest that the English >> spacing convention be completely abolished. >> FWIW, I'd just follow surrounding style like style(9) suggests. No >> reason for fighting over an extra byte per sentence in a source file >> (unless you consider how much added bandwidth / disk space those >> precious bytes can consume :)...). >> Thanks, >> -Garrett >> >> 1. http://en.wikipedia.org/wiki/History_of_sentence_spacing#French_and_E= nglish_spacing > > Double spacing is the one true way I learned how to type in school. Sinc= e the 1980's though, things have changed and many advocate single spaces. = However, that's for folks with fancy variable pitch font and such. For fix= ed-witdh fonts, 2 is still preferred in some circles, including ours. And now that I look at style(9), there are subtleties that demonstrate this in the roff generated text: =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D FreeBSD source tree. It is also a guide for the preferred userland co= de ^^ style. Many of the style rules are implicit in the examples. Be care= ful ^^ ^^ to check the examples before assuming that style is silent on an issue= . =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D I wish this point was more explicit, but like style(9), there are other unspoken rules that should/must be adhered to. Thanks, -Garrett