From owner-dev-commits-ports-all@freebsd.org  Fri Jul 23 12:03:31 2021
Return-Path: <owner-dev-commits-ports-all@freebsd.org>
Delivered-To: dev-commits-ports-all@mailman.nyi.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.nyi.freebsd.org (Postfix) with ESMTP id 723D36717FA
 for <dev-commits-ports-all@mailman.nyi.freebsd.org>;
 Fri, 23 Jul 2021 12:03:31 +0000 (UTC)
 (envelope-from adamw@freebsd.org)
Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256
 client-signature RSA-PSS (4096 bits) client-digest SHA256)
 (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 4GWSdb03jYz4XDd
 for <dev-commits-ports-all@freebsd.org>; Fri, 23 Jul 2021 12:03:30 +0000 (UTC)
 (envelope-from adamw@freebsd.org)
Received: from mail-wr1-f45.google.com (mail-wr1-f45.google.com
 [209.85.221.45])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK))
 (Authenticated sender: adamw/mail)
 by smtp.freebsd.org (Postfix) with ESMTPSA id 9DC8D72B4
 for <dev-commits-ports-all@freebsd.org>; Fri, 23 Jul 2021 12:03:30 +0000 (UTC)
 (envelope-from adamw@freebsd.org)
Received: by mail-wr1-f45.google.com with SMTP id r2so2142681wrl.1
 for <dev-commits-ports-all@freebsd.org>; Fri, 23 Jul 2021 05:03:30 -0700 (PDT)
X-Gm-Message-State: AOAM530LIb78FDQzVS4V4AwDdzqGsieMM+C7uNx3/nwRtkoUWNP5OSly
 fa1SDkLsBUzXVs466SINhNO4rrITW91x9A22reb3ww==
X-Google-Smtp-Source: ABdhPJwisGU7baZq6muaMsLYbqV8R4jXHa7OS+EURijQ1i6jTO4ofNiPmj/vVbV0kUD1TbFJ93Rz58Y+k5roCWq9chg=
X-Received: by 2002:adf:e40e:: with SMTP id g14mr5116715wrm.413.1627041809242; 
 Fri, 23 Jul 2021 05:03:29 -0700 (PDT)
MIME-Version: 1.0
References: <202107231135.16NBZX7C062107@gitrepo.freebsd.org>
 <YPqvsWHdUzCvEo/O@FreeBSD.org>
In-Reply-To: <YPqvsWHdUzCvEo/O@FreeBSD.org>
From: Adam Weinberger <adamw@freebsd.org>
Date: Fri, 23 Jul 2021 06:03:13 -0600
X-Gmail-Original-Message-ID: <CAP7rwchfsr1zi2+ykfgf6h6PE3Q2-1j+M1_6h2UKMnkKsPLGpA@mail.gmail.com>
Message-ID: <CAP7rwchfsr1zi2+ykfgf6h6PE3Q2-1j+M1_6h2UKMnkKsPLGpA@mail.gmail.com>
Subject: Re: git: 5ff464b1945d - main - bsd.port.mk: Fix typo
To: Alexey Dokuchaev <danfe@freebsd.org>
Cc: Adam Weinberger <adamw@freebsd.org>,
 ports-committers <ports-committers@freebsd.org>, 
 dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org
Content-Type: text/plain; charset="UTF-8"
X-Content-Filtered-By: Mailman/MimeDel 2.1.34
X-BeenThere: dev-commits-ports-all@freebsd.org
X-Mailman-Version: 2.1.34
Precedence: list
List-Id: Commit messages for all branches of the ports repository
 <dev-commits-ports-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/dev-commits-ports-all>, 
 <mailto:dev-commits-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/dev-commits-ports-all/>
List-Post: <mailto:dev-commits-ports-all@freebsd.org>
List-Help: <mailto:dev-commits-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/dev-commits-ports-all>, 
 <mailto:dev-commits-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 23 Jul 2021 12:03:31 -0000

On Fri, Jul 23, 2021 at 6:01 AM Alexey Dokuchaev <danfe@freebsd.org> wrote:

> On Fri, Jul 23, 2021 at 11:35:33AM +0000, Adam Weinberger wrote:
> > commit 5ff464b1945dac6628d87319f6bd1106761b3ba9
> >
> >     bsd.port.mk: Fix typo
> >
> > @@ -2246,7 +2246,7 @@ PKG_COMPRESSION_FORMAT?=        ${PKG_SUFX:S/.//}
> >  .else
> >  .if defined(PKG_SUFX)
> >  PKG_COMPRESSION_FORMAT?=     ${PKG_SUFX:S/.//}
> > -WARNING+= "PKG_SUFX is defined, if should be replaced with
> PKG_COMPRESSION_FORMAT"
> > +WARNING+= "PKG_SUFX is defined, it should be replaced with
> PKG_COMPRESSION_FORMAT"
>
> I've also thought that it was a typo and fixed it, but then bapt@ reverted
> this part of the change.  You might want to check with him what's going on.
>

Ah, there could be a bigger patch coming. Thanks, Alexey!

# Adam


-- 
Adam Weinberger
adamw@adamw.org // adamw@FreeBSD.org
https://www.adamw.org