From owner-dev-commits-ports-all@freebsd.org  Wed Sep 29 18:17:28 2021
Return-Path: <owner-dev-commits-ports-all@freebsd.org>
Delivered-To: dev-commits-ports-all@mailman.nyi.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.nyi.freebsd.org (Postfix) with ESMTP id B7F8A67903E;
 Wed, 29 Sep 2021 18:17:28 +0000 (UTC)
 (envelope-from danfe@freebsd.org)
Received: from freefall.freebsd.org (freefall.freebsd.org [96.47.72.132])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256
 client-signature RSA-PSS (4096 bits) client-digest SHA256)
 (Client CN "freefall.freebsd.org", Issuer "R3" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 4HKPjh4Zmvz4fcq;
 Wed, 29 Sep 2021 18:17:28 +0000 (UTC)
 (envelope-from danfe@freebsd.org)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim;
 t=1632939448;
 h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
 in-reply-to:in-reply-to:references:references;
 bh=woqf3s5IUrrIOvXMWxAai/7nBZyMGEH5oCid5/Vo4tQ=;
 b=dMaRwZP7tkEUMmq/XRkN4U5H7Nywm6UHRcXBOodWURzXhGyfE898LA/oAqD8Z094N5PpYF
 RNEqKo6CPncFTeHSDjR6LsiZNJM6KoP7GkvR3zUu5wTcy/yU7MiZS/1ZAUV2pp8OiT7W6m
 BHAR80LMuh51nh9+QwOvfAis3AH31r27h+YV08N/j1OP7HtJjpyArlmsSxmJS2MEPkb5FX
 YuSh1N3AvtdBaIe7MIUdXNyGlCn+66AeNrCY0sN1JVVQ6MFz5WIJBOaoFp+3zM8GTz/Cbp
 GkVdtwHYafdWX7ue2/vBOHi5+0dVtvRaSOBHlWTUG9dJt5ik8x6xVCgtS2MEHQ==
Received: by freefall.freebsd.org (Postfix, from userid 1033)
 id 8AF16129CF; Wed, 29 Sep 2021 18:17:28 +0000 (UTC)
Date: Wed, 29 Sep 2021 18:17:28 +0000
From: Alexey Dokuchaev <danfe@freebsd.org>
To: Koichiro Iwao <meta@freebsd.org>
Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org,
 dev-commits-ports-main@freebsd.org
Subject: Re: git: 4886d3afe2ed - main - x11-fm/mucommander: unbreak
Message-ID: <YVStuIrF780IhE3r@FreeBSD.org>
References: <202109291154.18TBssAe054689@gitrepo.freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <202109291154.18TBssAe054689@gitrepo.freebsd.org>
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org;
 s=dkim; t=1632939448;
 h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
 in-reply-to:in-reply-to:references:references;
 bh=woqf3s5IUrrIOvXMWxAai/7nBZyMGEH5oCid5/Vo4tQ=;
 b=lGr7YxgpBIFSS00RyguC+cyjfbVgSIdOmLw+h43hnAgT8B8/n+jRqx8ujBJLSQG8EW7ozE
 CM/sZcYZ6Q7GLpr2+aOdGKpJrNK0jJs843O+dDNxiNWLDzb0jkjwgQdqu/cf9rdQSoKrGS
 JcFxOCePp/0sYR79iO3gwRqUrO7BZ0Us43TPQwcpS1HMEMxrMsLZfTaAj1RaK8c5+EGZ8F
 P6F6VZL4x5D3kkMksN1M/x0fCSLpThJwu6H/2AVylrNiBPeuVwOf0IuBml+aN/dvsaoFyf
 n8Kt0FRlyJ5MnO+Qa7Gubzf6actDedB/kYbu8N6b29zDH93KBj7duRcxAbiiKQ==
ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1632939448; a=rsa-sha256; cv=none;
 b=Ygl/wVneSuuxs8S8MrAFoNlZzoCQ7vhlz6flCXd5Mlw1pD8LCUb+B6jJXV5NwprlVJ/9/n
 kXo9SD6hiZMvJ4cnvyiitmod1G3dF1wb9Mw10wEaSiFb7AUiDLRV3dplJT+Y5MqsciZLJS
 1zq/ZMldcFdtgYveA9NcMQUcrtiuF6lm9HdCevPDP0z48kL+tgDenqD83uvb6QR9lcKpsu
 QL8GUYKj7xSOeyeVj3VUQFtuYfZn2j6gowaas2DsMywc5eh/SEh2c0uqCbGNiAXrxcAJ+6
 epDpVL3tpubTM5LJCBg1jv6d4/SI4Xp6HmLnITQrkBWxtDJoejEvP1JyrcTNiQ==
ARC-Authentication-Results: i=1;
	mx1.freebsd.org;
	none
X-BeenThere: dev-commits-ports-all@freebsd.org
X-Mailman-Version: 2.1.34
Precedence: list
List-Id: Commit messages for all branches of the ports repository
 <dev-commits-ports-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/dev-commits-ports-all>, 
 <mailto:dev-commits-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/dev-commits-ports-all/>
List-Post: <mailto:dev-commits-ports-all@freebsd.org>
List-Help: <mailto:dev-commits-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/dev-commits-ports-all>, 
 <mailto:dev-commits-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 29 Sep 2021 18:17:28 -0000

On Wed, Sep 29, 2021 at 11:54:54AM +0000, Koichiro Iwao wrote:
> commit 4886d3afe2edc47f40839f972a1891c0dbd64d65
> 
>     x11-fm/mucommander: unbreak
>     
> ...
> @@ -28,7 +26,7 @@ OPTIONS_DEFINE=	DOCS
>  
>  do-install:
>  	@${MKDIR} ${STAGEDIR}${DATADIR}
> -	${INSTALL_DATA} ${WRKSRC}/mucommander.jar ${STAGEDIR}${DATADIR}
> +	${INSTALL_DATA} ${WRKSRC}/mucommander-0.9.5.jar ${STAGEDIR}${DATADIR}/mucommander.jar

It's generally a bad idea to hardcode version numbers in targets recipes,
as it would have to be changed upon next update.  Why not use something
like ${PORTVERSION:R} instead, in this particular case?

./danfe