From owner-svn-src-head@freebsd.org Fri Aug 17 16:18:05 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id D676210743F5; Fri, 17 Aug 2018 16:18:05 +0000 (UTC) (envelope-from cse.cem@gmail.com) Received: from mail-io0-f178.google.com (mail-io0-f178.google.com [209.85.223.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 6DC628692D; Fri, 17 Aug 2018 16:18:05 +0000 (UTC) (envelope-from cse.cem@gmail.com) Received: by mail-io0-f178.google.com with SMTP id m4-v6so7360184iop.3; Fri, 17 Aug 2018 09:18:05 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:reply-to:in-reply-to:references :from:date:message-id:subject:to:cc; bh=xyTHSq6kPNtlgVFJ+tb/wA/pvYJolklyMrGqfxrDrds=; b=OT7wAvU7PSczh7A8SkAlRY0+5UUFeQvR5xXTEY+bhpWpvpAQjYCKJKVhehOff0UxgU E2dxJlSf96L+TP9YTenHwrinsE0Nayi89Z/bPqyDiu+UbdVRnn+1wGcORb0QknlKR+Eh /XgdGxQAodRfkl81YgRQt+pz3iPON5fWoXbbCgHsrKg+EdY5ADxXLi6EozHMM7K81GrH RHEaDOhJS1WgfQOjvmin/EzkykiwkO4uA6O5PiqqbZqxPcBMT0Byi5kY0S/YQcXndY0n 7axSfua7GcxkBO7XraKBkc98iiRidZ1mWqDfETqTVUQT9i+q1wyMYOUewnwhBVLV9EYB 12FA== X-Gm-Message-State: APzg51BDmaN4qqp3Hyi88sSocKSyrHeqEO4IixmsO6OTbZ18QdSQxvct RHWn7paBg1uR1U7IyOTTM99LBvHK X-Google-Smtp-Source: ANB0VdbDRUvlVyKt9bggKaUXJM8XakdERqdpver6O+Mh/OY63EGOelIiwO/FMcl4FnojaKBtjaGvdw== X-Received: by 2002:a6b:e508:: with SMTP id y8-v6mr7928502ioc.285.1534522679630; Fri, 17 Aug 2018 09:17:59 -0700 (PDT) Received: from mail-it0-f42.google.com (mail-it0-f42.google.com. [209.85.214.42]) by smtp.gmail.com with ESMTPSA id z6-v6sm1552965iti.19.2018.08.17.09.17.58 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 17 Aug 2018 09:17:59 -0700 (PDT) Received: by mail-it0-f42.google.com with SMTP id s7-v6so11980601itb.4; Fri, 17 Aug 2018 09:17:58 -0700 (PDT) X-Received: by 2002:a24:f945:: with SMTP id l66-v6mr1946385ith.6.1534522678858; Fri, 17 Aug 2018 09:17:58 -0700 (PDT) MIME-Version: 1.0 Reply-To: cem@freebsd.org Received: by 2002:a02:b472:0:0:0:0:0 with HTTP; Fri, 17 Aug 2018 09:17:58 -0700 (PDT) In-Reply-To: References: <201808170023.w7H0Np0H027296@repo.freebsd.org> <201808170503.w7H53GR9023607@slippy.cwsent.com> From: Conrad Meyer Date: Fri, 17 Aug 2018 09:17:58 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r337936 - in head/sys/contrib/libsodium: . builds builds/msvc builds/msvc/build builds/msvc/properties builds/msvc/vs2010 builds/msvc/vs2010/libsodium builds/msvc/vs2012 builds/msvc/vs2... To: Warner Losh Cc: src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset="UTF-8" X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 17 Aug 2018 16:18:06 -0000 On Fri, Aug 17, 2018 at 9:12 AM, Warner Losh wrote: > > On Fri, Aug 17, 2018, 10:05 AM Conrad Meyer wrote: >> We don't intend[sic] on tailoring it at all. > > We don't document such an exception... history tells me this belief may be > optimistic.. I think it is a generally understood convention re: contrib code. I called out intent in the commit message for the directory, and anyway it is generally frowned upon in the project to modify contrib code for non-abandoned upstreams. E.g., there was quite a bit of resistance modifying top(1) until it was deemed dead upstream and moved out of contrib. Hope that helps, Conrad