Date: Tue, 18 Apr 2023 14:38:58 +0100
From: Nuno Teixeira <eduardo@freebsd.org>
To: Felix Palmen <zirias@freebsd.org>
Cc: ports@freebsd.org
Subject: Re: Get ${OSREL} at install time
Message-ID: <CAFDf7U%2BwjCzDXWM%2BwetgnMNyRgvn8=gBu9jd6HDx19jH6x-ABw@mail.gmail.com>
In-Reply-To: <plmv6w7gqn5zeyibyakqu5obtvnm627v323yuk374gkba77las@s6dhc2peqeif>
References: <CAFDf7UK=-R6o2Q5o2ihsiD%2Bue_4L2j1tXEu2LiJSVp%2Br=uEwww@mail.gmail.com> <CAFDf7U%2BaV5rVQgcWz96v80tPWFH-9RXRmMbnrqEjv93xx9rvuw@mail.gmail.com> <CAFDf7ULnDW2w8O9WD%2BDMdT2ku0DtH9OWDBidfejJQ9BEhJHOUg@mail.gmail.com> <3gizlmiaz2h3qwk6xe64iik42vr6mtxyex4d2hjaymazz5nngt@3wm6jdrdxslm> <zrc4espwpzkt2ssauiz7gxz2zo6vzh2ms5j2kmqzbidoub4nc2@7yn7b6w25nkt> <CAFDf7UKS8LW6xJtaN%2Bud7-tGjxKQrSyMsnpy2ytCki7CKpOimg@mail.gmail.com> <2su26bpfemilo52atij5i2focesm4iejrkrjry5dr7w4xlxe55@5rjqkjv3tzyk> <CAFDf7UL7C2K%2BtmrPHsbedOT36Wm4SaQzfDRQg02sZhxYvd%2BdYQ@mail.gmail.com> <qg6dyvhltcxeoqq3s6njx6fu7dw2mynbuakxfvyg5c6htwzoha@fiycyd4pxcdd> <CAFDf7UK9qzbfPz-P8CnRgzoVV5J69U29Cf-fc10j4%2BsnhuBUmw@mail.gmail.com> <plmv6w7gqn5zeyibyakqu5obtvnm627v323yuk374gkba77las@s6dhc2peqeif>
next in thread | previous in thread | raw e-mail | index | archive | help
--000000000000a1331d05f99c6eb8 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Ok, I will continue testing. BTW, I've openned a PR at https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D270911 Please test :) Thanks all Felix Palmen <zirias@freebsd.org> escreveu no dia ter=C3=A7a, 18/04/2023 = =C3=A0(s) 14:13: > * Nuno Teixeira <eduardo@freebsd.org> [20230418 13:45]: > > I will do further tests and open an PR so other people try it (I hope). > > I would suggest a final improvement: You should probably sanity-check > what you get from freebsd-version (and in case it isn't sane, stick to > the compile-time defaults). That's because it's perfectly possible to > install packages with "pkg -r" into a prefix that doesn't even have base > installed (so, also no freebsd-version available there). > > -- > Felix Palmen <zirias@FreeBSD.org> {private} felix@palmen-it.de > -- ports committer (mentee) -- {web} http://palmen-it.de > {pgp public key} http://palmen-it.de/pub.txt > {pgp fingerprint} 6936 13D5 5BBF 4837 B212 3ACC 54AD E006 9879 F231 > --=20 Nuno Teixeira FreeBSD Committer (ports) --000000000000a1331d05f99c6eb8 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable <div dir=3D"ltr"><div>Ok, I will continue testing.</div><div><br></div><div= >BTW, I've openned a PR at <a href=3D"https://bugs.freebsd.org/bugzilla= /show_bug.cgi?id=3D270911">https://bugs.freebsd.org/bugzilla/show_bug.cgi?i= d=3D270911</a></div><div><br></div><div>Please test :)</div><div><br></div>= <div>Thanks all<br></div></div><br><div class=3D"gmail_quote"><div dir=3D"l= tr" class=3D"gmail_attr">Felix Palmen <<a href=3D"mailto:zirias@freebsd.= org">zirias@freebsd.org</a>> escreveu no dia ter=C3=A7a, 18/04/2023 =C3= =A0(s) 14:13:<br></div><blockquote class=3D"gmail_quote" style=3D"margin:0p= x 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">* = Nuno Teixeira <<a href=3D"mailto:eduardo@freebsd.org" target=3D"_blank">= eduardo@freebsd.org</a>> [20230418 13:45]:<br> > I will do further tests and open an PR so other people try it (I hope)= .<br> <br> I would suggest a final improvement: You should probably sanity-check<br> what you get from freebsd-version (and in case it isn't sane, stick to<= br> the compile-time defaults). That's because it's perfectly possible = to<br> install packages with "pkg -r" into a prefix that doesn't eve= n have base<br> installed (so, also no freebsd-version available there).<br> <br> -- <br> =C2=A0Felix Palmen <zirias@FreeBSD.org>=C2=A0 =C2=A0 =C2=A0{private}= =C2=A0 =C2=A0<a href=3D"mailto:felix@palmen-it.de" target=3D"_blank">felix@= palmen-it.de</a><br> =C2=A0-- ports committer (mentee) --=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 {web}=C2=A0 <a href=3D"http://palmen-it.de" rel=3D"noreferrer" target= =3D"_blank">http://palmen-it.de</a><br>; =C2=A0{pgp public key}=C2=A0 <a href=3D"http://palmen-it.de/pub.txt" rel=3D= "noreferrer" target=3D"_blank">http://palmen-it.de/pub.txt</a><br>; =C2=A0{pgp fingerprint} 6936 13D5 5BBF 4837 B212=C2=A0 3ACC 54AD E006 9879 = F231<br> </blockquote></div><br clear=3D"all"><br><span class=3D"gmail_signature_pre= fix">-- </span><br><div dir=3D"ltr" class=3D"gmail_signature"><div dir=3D"l= tr"><span style=3D"color:rgb(102,102,102)">Nuno Teixeira<br>FreeBSD Committ= er (ports)</span></div></div> --000000000000a1331d05f99c6eb8--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAFDf7U%2BwjCzDXWM%2BwetgnMNyRgvn8=gBu9jd6HDx19jH6x-ABw>