From owner-freebsd-net@FreeBSD.ORG Thu Aug 20 17:08:10 2009 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 0FD4F106568F for ; Thu, 20 Aug 2009 17:08:10 +0000 (UTC) (envelope-from jfvogel@gmail.com) Received: from mail-yx0-f181.google.com (mail-yx0-f181.google.com [209.85.210.181]) by mx1.freebsd.org (Postfix) with ESMTP id B78D28FC55 for ; Thu, 20 Aug 2009 17:08:09 +0000 (UTC) Received: by yxe11 with SMTP id 11so52319yxe.3 for ; Thu, 20 Aug 2009 10:08:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :date:message-id:subject:from:to:cc:content-type; bh=xnstFKBzqVtXbvrpEOYAFAAvJIhTx/B6RL8NIYo2J1w=; b=G+MeHOepfLmJHrzgt+zpzbT5JvsY2Pl1ac1D16amTJCIWDaza8O9QD7oXYy7XoQSAz +cL0U5JJnkj8seh/ul5eldHPmdQu7UPXl4SfyprVN4so+n56OS+9tmyDZi2GzR2wTA+u iIHNBmHDVSDjRwOrygwKngXNKOgvBaaXFFihs= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; b=vGuBC/erAxlrvMEFxUi8Y6iYvUo5HFp5CMSwz4pkKrgLDkxkUx6erA6jwZeFyounox k8vG4ydBDLXDOKFo3K8eE7oTqgCcINsSG3V9Gy+11ennd9W3PEum4EBG1vw6dusXSdbv mhKjeplOEsvugCNXTWEbeCxyenYqJahbLV634= MIME-Version: 1.0 Received: by 10.100.76.8 with SMTP id y8mr61863ana.34.1250788089117; Thu, 20 Aug 2009 10:08:09 -0700 (PDT) In-Reply-To: <5bc218350908200953p630d99c6u1538999b308c55f9@mail.gmail.com> References: <5bc218350908191146j2a22f8dcrdecb0b67eedce5c2@mail.gmail.com> <435336.24858.qm@web63908.mail.re1.yahoo.com> <5bc218350908200953p630d99c6u1538999b308c55f9@mail.gmail.com> Date: Thu, 20 Aug 2009 10:08:09 -0700 Message-ID: <2a41acea0908201008y6e8f160dx27b406db7d3081b7@mail.gmail.com> From: Jack Vogel To: Manish Vachharajani Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Content-Filtered-By: Mailman/MimeDel 2.1.5 Cc: Barney Cordoba , freebsd-net@freebsd.org Subject: Re: Dropped vs. missed packets in the ixgbe driver X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 20 Aug 2009 17:08:10 -0000 I've been looking at the code due to another problem of bogus flow control numbers, and there are some changes needed, things that should be 82599 vs 82598 and were not seperated properly. Will be forthcoming. Not sure if it has any relevance to this, but its possible. Jack On Thu, Aug 20, 2009 at 9:53 AM, Manish Vachharajani < manishv@lineratesystems.com> wrote: > Oh whoops, sorry didn't see that. So the plot thickens. Why don't > these errors show up in the netstat output I forwarded originally? > Ierrs was 0 but the dmesg output clearly shows missed packets. Any > thoughts on what is going on? Looking at the code, missed_rx should > certainly get counted in the ierrors field as you said. > > Is the Ierrs in the netstat output some other counter? If so, how do > I get the if_ierrors variable from the command line? > > Manish > > On Thu, Aug 20, 2009 at 6:49 AM, Barney Cordoba > wrote: > > > > > > --- On Wed, 8/19/09, Manish Vachharajani > wrote: > > > >> From: Manish Vachharajani > >> Subject: Re: Dropped vs. missed packets in the ixgbe driver > >> To: "Barney Cordoba" > >> Cc: freebsd-net@freebsd.org > >> Date: Wednesday, August 19, 2009, 2:46 PM > >> Agreed, the errors are reported but > >> missed packets are not. The > >> question is, is the correct fix to just add stats.mpc[0] to > >> if_ierrors > >> in that line or to add it to if_iqdrops. The fix is > >> easy once we > >> agree on what the correct behavior is. > >> > >> Manish > >> > >> > Barney wrote: > >> > > >> > if you look in ixgbe_update_stats_counters at the > >> bottom: > >> > > >> > ifp->if_ierrors = missed_rx + > >> adapter->stats.crcerrs + > >> > adapter->stats.rlec; > >> > > >> > the errors are added in. > >> > > >> > BC > > > > Huh? missed_rx are the missed packets. So they are counted. > > > > BC > > > > > > > > > > > > > > -- > Manish Vachharajani > Founder > LineRate Systems > manishv@lineratesystems.com > (609)635-9531 M > _______________________________________________ > freebsd-net@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-net > To unsubscribe, send any mail to "freebsd-net-unsubscribe@freebsd.org" >