From owner-svn-src-projects@FreeBSD.ORG Sat Oct 27 16:44:07 2012 Return-Path: Delivered-To: svn-src-projects@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 346678F; Sat, 27 Oct 2012 16:44:07 +0000 (UTC) (envelope-from neelnatu@gmail.com) Received: from mail-pa0-f54.google.com (mail-pa0-f54.google.com [209.85.220.54]) by mx1.freebsd.org (Postfix) with ESMTP id DF4A88FC0A; Sat, 27 Oct 2012 16:44:06 +0000 (UTC) Received: by mail-pa0-f54.google.com with SMTP id bi1so2694162pad.13 for ; Sat, 27 Oct 2012 09:44:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=references:in-reply-to:mime-version:content-transfer-encoding :content-type:message-id:cc:x-mailer:from:subject:date:to; bh=2A7rETx8Z0aKu2dEWx+gyHDkWZk+LygU2a6zO/ej0NA=; b=JGpXeXyU1cD+vgvAB08143iXK9y+5hFyh6HW9n40StXn3Hfm8PgD0zcMfC/5MBVFnH w/qVLZGJgSP7avHMZfG2tLJ5uMZFn35g/BJVhyQSgbfoKLhDEG2u/g7TS0u/g9INcNwu BT9PpBsDIr6ntXXB+NjvRQUC7IHjRLe4zpSOjOOfBct6ADpwxwPEk3tyfVns/dEUuqf9 wSJYAhedG5GTGEVD3J80r+i3WoOjhquSFTHwBjxPe+p2IH97VQxk7ZNf1eK7OG0Ipr0d A8vmOgmc60E7xSAdTXqVTuRufI+0emFsaCZchItZSirtINECaP/nMz0NEj9Kb/50xQQu PXUw== Received: by 10.68.136.100 with SMTP id pz4mr78950695pbb.135.1351356246671; Sat, 27 Oct 2012 09:44:06 -0700 (PDT) Received: from [192.168.0.104] (c-69-181-126-139.hsd1.ca.comcast.net. [69.181.126.139]) by mx.google.com with ESMTPS id ko10sm3036451pbc.1.2012.10.27.09.44.03 (version=TLSv1/SSLv3 cipher=OTHER); Sat, 27 Oct 2012 09:44:04 -0700 (PDT) References: <201210270239.q9R2d8Kv064997@svn.freebsd.org> In-Reply-To: Mime-Version: 1.0 (1.0) Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii Message-Id: <4F77FDF1-BA5A-4D9D-9AD6-0812FB027315@gmail.com> X-Mailer: iPhone Mail (9B206) From: Neel Natu Subject: Re: svn commit: r242170 - projects/bhyve/usr.sbin/bhyve Date: Sat, 27 Oct 2012 09:43:38 -0700 To: Eitan Adler Cc: "svn-src-projects@freebsd.org" , "src-committers@freebsd.org" , Neel Natu X-BeenThere: svn-src-projects@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "SVN commit messages for the src " projects" tree" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 27 Oct 2012 16:44:07 -0000 Hi Eitan, On Oct 27, 2012, at 8:52 AM, Eitan Adler wrote: > On 26 October 2012 22:39, Neel Natu wrote: >> Author: neel >> Date: Sat Oct 27 02:39:08 2012 >> New Revision: 242170 >> URL: http://svn.freebsd.org/changeset/base/242170 >>=20 >> Log: >> Ignore PCI configuration accesses to all bus numbers other than PCI bus 0= . >=20 > I'm sorry this is a silly question, but why? >=20 At the moment all the emulated PCI devices are on bus 0. We don't present a PCI device tree hierarchy to the guest with bridges and e= nd-point devices, so everything hangs off bus 0. Prior to this change any access to a PCI bus !=3D 0 got aliased to devices o= n bus 0 which is obviously wrong and tripped up drivers like the QPI driver w= hich start probing backwards from bus 255. Best Neel >=20 > --=20 > Eitan Adler > Source, Ports, Doc committer > Bugmeister, Ports Security teams