From owner-cvs-src-old@FreeBSD.ORG Sat Dec 18 14:24:40 2010 Return-Path: Delivered-To: cvs-src-old@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 583B51065673 for ; Sat, 18 Dec 2010 14:24:40 +0000 (UTC) (envelope-from tijl@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 45D868FC23 for ; Sat, 18 Dec 2010 14:24:40 +0000 (UTC) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.4/8.14.4) with ESMTP id oBIEOeMv098941 for ; Sat, 18 Dec 2010 14:24:40 GMT (envelope-from tijl@repoman.freebsd.org) Received: (from svn2cvs@localhost) by repoman.freebsd.org (8.14.4/8.14.4/Submit) id oBIEOe3p098940 for cvs-src-old@freebsd.org; Sat, 18 Dec 2010 14:24:40 GMT (envelope-from tijl@repoman.freebsd.org) Message-Id: <201012181424.oBIEOe3p098940@repoman.freebsd.org> X-Authentication-Warning: repoman.freebsd.org: svn2cvs set sender to tijl@repoman.freebsd.org using -f From: Tijl Coosemans Date: Sat, 18 Dec 2010 14:24:24 +0000 (UTC) To: cvs-src-old@freebsd.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/dev/hifn hifn7751.c X-BeenThere: cvs-src-old@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: **OBSOLETE** CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 18 Dec 2010 14:24:40 -0000 tijl 2010-12-18 14:24:24 UTC FreeBSD src repository Modified files: sys/dev/hifn hifn7751.c Log: SVN rev 216519 on 2010-12-18 14:24:24Z by tijl No need to zero the softc. It's allocated with M_ZERO. Use pci_enable_busmaster instead of setting PCIM_CMD_BUSMASTEREN directly. There's no need to set PCIM_CMD_MEMEN. The bit is set when a SYS_RES_MEMORY resource is activated. Remove redundant pci_* function calls from suspend/resume methods. The bus driver already saves and restores the PCI configuration. Write 1 byte instead of 4 when setting the HIFN_TRDY_TIMEOUT register. It is only 1 byte according to the specification. Reviewed by: jhb Approved by: kib (mentor) Revision Changes Path 1.44 +3 -27 src/sys/dev/hifn/hifn7751.c