From owner-freebsd-current@FreeBSD.ORG Mon Jan 3 17:55:44 2011 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 5D8A1106566B; Mon, 3 Jan 2011 17:55:44 +0000 (UTC) (envelope-from yanegomi@gmail.com) Received: from mail-yx0-f182.google.com (mail-yx0-f182.google.com [209.85.213.182]) by mx1.freebsd.org (Postfix) with ESMTP id F37898FC12; Mon, 3 Jan 2011 17:55:43 +0000 (UTC) Received: by yxh35 with SMTP id 35so5799677yxh.13 for ; Mon, 03 Jan 2011 09:55:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:references:in-reply-to :mime-version:content-transfer-encoding:content-type:message-id:cc :x-mailer:from:subject:date:to; bh=YIN61CkhhF8g/wnh6gKownGUdjYAQkeevuZvTei6vTU=; b=oLnMFFAiWFP+/ASKVCdITWeEw+A8PF3bywtU0/ejDZ29df1xhebz88ib8OoKIktT8m tZduQrEFBHQalGA9g6GIZ+Ohpb8NgAETMJpbIPqqrWRw6rRRhgE8l6rpn03BuOUePj+w ELBS1+KGISAMlyMR5AQgyc+VIeXCy7DEVcKN8= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=references:in-reply-to:mime-version:content-transfer-encoding :content-type:message-id:cc:x-mailer:from:subject:date:to; b=QluNZ6z+o7L54gwVNx9PxOBR3eKM2SezXc9xDywthpMvKn50hYggI1E24GVpD2WGAU CJA2khmGW0hUReIQ27s3siyORg6tlt1KMGN8kFtgKG+kwgTmB/aWwLWCUayD2B/gPAWV FcqdL/zF0h796ARe0EBCSF703rIwA7UFusOMY= Received: by 10.236.111.39 with SMTP id v27mr26895239yhg.20.1294077343223; Mon, 03 Jan 2011 09:55:43 -0800 (PST) Received: from [192.168.20.8] (c-24-130-151-210.hsd1.ca.comcast.net [24.130.151.210]) by mx.google.com with ESMTPS id n67sm12443212yha.26.2011.01.03.09.55.39 (version=TLSv1/SSLv3 cipher=RC4-MD5); Mon, 03 Jan 2011 09:55:41 -0800 (PST) References: <4D1B0E41.40405@gmail.com> <4D21CC35.5060803@gmx.de> <20110103141830.GC3140@deviant.kiev.zoral.com.ua> <47B52F19-AB6B-4116-9F5E-219B26519115@FreeBSD.org> In-Reply-To: <47B52F19-AB6B-4116-9F5E-219B26519115@FreeBSD.org> Mime-Version: 1.0 (iPhone Mail 8C148) Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 Message-Id: X-Mailer: iPhone Mail (8C148) From: Garrett Cooper Date: Mon, 3 Jan 2011 09:55:30 -0800 To: =?utf-8?Q?Edward_Tomasz_Napiera=C5=82a?= Cc: Kostik Belousov , Matthias Andree , "freebsd-current@freebsd.org" Subject: Re: No human readable message with g_vfs X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 03 Jan 2011 17:55:44 -0000 On Jan 3, 2011, at 8:33 AM, Edward Tomasz Napiera=C5=82a = wrote: > Wiadomo=C5=9B=C4=87 napisana przez Kostik Belousov w dniu 2011-01-03, o go= dz. 15:18: >> On Mon, Jan 03, 2011 at 02:16:37PM +0100, Matthias Andree wrote: >>> Am 03.01.2011 14:14, schrieb Ivan Voras: >>>> On 12/29/10 11:32, David Demelier wrote: >>>>> /var/log/messages.5.bz2:Nov 29 16:36:52 Abricot kernel: >>>>> g_vfs_done():ufs/public[READ(offset=3D232718991360, length=3D131072)]e= rror >>>>> =3D 5 >>>>>=20 >>>>> I think for a lambda user these are absolutely not understandable. I >>>>=20 >>>> Would a better message be "WRITE error on da0, offset=3D34590720. >>>> length=3D65536, errno=3D5"? >>>=20 >>> nah, strerror(errno) isn't that much of an effort >> In kernel ? There is no strerror, and there is no great need to import th= e >> sys_errlist. >=20 > I had code that adds strerror() to the kernel in one of my old p4 branches= . > Error messages like the one above look much better this way, but I didn't > have time to push it into the tree, and there is a risk of yet another i18= n > discussion. If someone is interested - let me know; I'll try to find it. Some thoughts: - It's a pain to parse (before I just had to scan for an int -- now it's a s= tring?!?) - It slows down printing (slow kernel -> dog slow system). - Fills up logs quicker if a subsystem or piece of hardware is going south a= nd these messages slam syslog, which means I have to scan more logs looking f= or useful data, the likelihood of messages being lost in various buffers is h= igher, etc. Why not just provide a more standard sensical printout for the messages and p= rovide a secret decoder ring in userland or something for interested parties= the don't know that error is an errno value (eg my mom and dad because they= 're unix illiterate), or just copyout all of the error data via an ioctl, pr= int out the ioctl failures, and skip the kernel level printing altogether? Thanks! -Garrett=