From nobody Wed Apr 5 16:59:15 2023 X-Original-To: dev-commits-ports-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Ps9pJ6NPnz43ls5; Wed, 5 Apr 2023 16:59:20 +0000 (UTC) (envelope-from bofh@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Ps9pJ5w65z445l; Wed, 5 Apr 2023 16:59:20 +0000 (UTC) (envelope-from bofh@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1680713960; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=E0zbEi1OWDdJp7+ZvqRr3GAkjxC0tEBQnNpsElRVTno=; b=rHUsNYLUUq4lcN1lJH1ORFP5F2bGsaRQjki4u9NBgZoAzfNK2qTIzJs60uOhsIccY7EC+n JfasWmPXJipOF2gLDPZNzdAg7dzOYU27J8Cd2K78VTk/kKmfo4em7TcyHQi2A4uGVycyPB kMIVtBpuucTSiUmnzQXse9KW32SBVYH7GAtt0/LFA38VgLv3HkvlWLYneTKL3Wq2/tMYVq 0kW3I+WW4kIDXn5rE8Cti0mOx1Z3QGGJmgZxhH7ToJ+FntRixVFTFtXtAqvuIiaExLGdOL HzP7Pzb1sspi/wM5TJuSHajc0KExGdJBQlhu3jyVYapeax58rJBd6RBldwk6/Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1680713960; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=E0zbEi1OWDdJp7+ZvqRr3GAkjxC0tEBQnNpsElRVTno=; b=nlwFbnrSQjogwTeSPg6Wqm5/9GIiTIOKoEoq6KzWdnjgIpfcghDwg3LhC/aQHBbW+/cFVA iMrVTNMyA3rljMRNASrrV3oRl2SGoeTGJMxtKsjLEOmgM5IXs57uMJhNCa5EXzTVPl/L7c WMKxhNOMrZZabjKP/ssbGr+dJ9DG/xjkLRLy/dnWO4+DStzi+1O7SLnenGZUKOMvI1+Y3T pM4YS29kdSNGo/lH8HMd434PIx+XETscVJQdgK1Mv84qNzSUf0oA/kcZzw/iBVnKa3ii0U C7FiMbU8Xf1sjMz5vXnbIPYiGuKjBY0g6IYUIIgDwgkhbJg/CqsVS3+IvDx1Eg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1680713960; a=rsa-sha256; cv=none; b=ZCHqNnVmq2Atlv931k0HH8eNLlZSTrmrLtv+vE5Jclif/OG6/I+e60Jq7GZPijO4muSzcD NOTFgQQwdPQSWn9z3ZNJeu4ETMHh6pMCnjDcbgKCnoTglqV0OoF6MmMl5tF2cM8ZEkPAN7 28FFwAulq8cpwsfcwoje2A5eQP6xDjBDS8ZsJ4gkCRBPgHJRLGfj9CHDjMsSk3SBLMlr1+ BDjyRXBeeshHLVQdZq6XwkFRXOuLvCCv8tHAoFK9/s1A1nwnSoMC1OqB3WVKt2JB9JT6U3 mcsmFj2ivmQmdax/vJFTxzW6PRrAPL+aDuAA9q+8cTdDWFlbiIxmZ5W6sy4mNg== Received: from mx.bofh.network (mx.bofh.network [IPv6:2a01:4f8:261:25de::227]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature ECDSA (P-256) client-digest SHA256) (Client CN "mx.bofh.network", Issuer "R3" (verified OK)) (Authenticated sender: bofh/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 4Ps9pJ0qzXz1SKg; Wed, 5 Apr 2023 16:59:20 +0000 (UTC) (envelope-from bofh@freebsd.org) Received: from smtpclient.apple (gw.office.cyso.net [95.97.78.194]) by mx.bofh.network (OpenSMTPD) with ESMTPSA id 417ce7e7 (TLSv1.2:ECDHE-ECDSA-AES256-GCM-SHA384:256:NO); Wed, 5 Apr 2023 16:59:16 +0000 (UTC) From: Moin Rahman Message-Id: Content-Type: multipart/alternative; boundary="Apple-Mail=_CF25581C-DE0E-479A-B8C9-E65368372BE5" List-Id: Commits to the main branch of the FreeBSD ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-main@freebsd.org X-BeenThere: dev-commits-ports-main@freebsd.org Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.1\)) Subject: Re: git: 4cda17ab1458 - main - */*: Refactor java/openjdk7 removal Date: Wed, 5 Apr 2023 18:59:15 +0200 In-Reply-To: Cc: ports-committers , dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org To: Alexey Dokuchaev References: <202304041811.334IB93k074119@gitrepo.freebsd.org> X-Mailer: Apple Mail (2.3696.120.41.1.1) X-ThisMailContainsUnwantedMimeParts: N --Apple-Mail=_CF25581C-DE0E-479A-B8C9-E65368372BE5 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii > On Apr 5, 2023, at 5:48 PM, Alexey Dokuchaev = wrote: >=20 > On Tue, Apr 04, 2023 at 06:11:09PM +0000, Muhammad Moinur Rahman = wrote: >> commit 4cda17ab14588e6e4fdac7f697e246554ce82af3 >>=20 >> Refactor java/openjdk7 removal >>=20 >> - Since the introduction of jdk version 18 it looks like similar = with >> jdk version 8(java version string 1.8). This is prone to error as = it >> looks similar and is only seperated by a '.'. Remove using >> JAVA_VERSION with dotted fomat of java version string and update = all >> consumers to utilize version 8 instead of 1.8. >>=20 >> @@ -17,7 +17,7 @@ NO_WRKSUBDIR=3D yes >>=20 >> USES=3D zip:infozip >> USE_JAVA=3D yes >> -JAVA_VERSION=3D 1.8+ >> +JAVA_VERSION=3D 8+ >=20 > Perhaps we should drop JAVA_VERSION as USE_JAVA accepts versions = similar > to USE_GCC; separate JAVA_VERSION is just a needless cognitive burden. >=20 > ./danfe You speak my mind; but one step at a time. That is planned in step 2 and = in step 3 I am going to convert this into USES=3Djava. Kind regards, Moin= --Apple-Mail=_CF25581C-DE0E-479A-B8C9-E65368372BE5 Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset=us-ascii

On Apr 5, 2023, at 5:48 PM, Alexey Dokuchaev <danfe@FreeBSD.org> = wrote:

On Tue, Apr 04, 2023 at 06:11:09PM +0000, Muhammad Moinur = Rahman wrote:
commit = 4cda17ab14588e6e4fdac7f697e246554ce82af3

=  Refactor java/openjdk7 removal

=  - Since the introduction of jdk version 18 it looks like similar = with
   jdk version 8(java version string = 1.8). This is prone to error as it
=    looks similar and is only seperated by a '.'. Remove = using
   JAVA_VERSION with dotted fomat of = java version string and update all
=    consumers to utilize version 8 instead of 1.8.

@@ -17,7 +17,7 @@ NO_WRKSUBDIR=3D yes

USES=3D zip:infozip
= USE_JAVA=3D = yes
-JAVA_VERSION=3D 1.8+
+JAVA_VERSION=3D 8+

Perhaps we should drop JAVA_VERSION as USE_JAVA accepts = versions similar
to USE_GCC; separate JAVA_VERSION is just = a needless cognitive burden.

./danfe

You speak my mind; but one step at a time. That is planned in = step 2 and in step 3 I am going to convert this into = USES=3Djava.

Kind regards,
Moin
= --Apple-Mail=_CF25581C-DE0E-479A-B8C9-E65368372BE5--