Date: Sat, 23 Nov 2019 14:55:24 +0000 From: Alexey Dokuchaev <danfe@freebsd.org> To: Adriaan de Groot <adridg@freebsd.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r518243 - head/x11-toolkits/qt5-gui Message-ID: <20191123145524.GA84936@FreeBSD.org> In-Reply-To: <201911231446.xANEkdSZ075924@repo.freebsd.org> References: <201911231446.xANEkdSZ075924@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, Nov 23, 2019 at 02:46:39PM +0000, Adriaan de Groot wrote: > New Revision: 518243 > URL: https://svnweb.freebsd.org/changeset/ports/518243 > > Log: > Add Vulkan headers to the run-depends of x11-toolkits/qt5-gui > > This was already added to the build-deps; however now users of qt5-gui > run into Vulkan problems, in particular sysutils/qt5-qtdiag, which is > now fixed with this build-depends. > > @@ -25,7 +25,8 @@ LIB_DEPENDS= libdbus-1.so:devel/dbus \ > libxcb-render-util.so:x11/xcb-util-renderutil \ > libxcb-icccm.so:x11/xcb-util-wm \ > libxkbcommon.so:x11/libxkbcommon > -RUN_DEPENDS= xdg-open:devel/xdg-utils > +RUN_DEPENDS= xdg-open:devel/xdg-utils \ > + ${LOCALBASE}/include/vulkan/vulkan.h:devel/vulkan-headers Commit log does not really explain how come a *header file* is needed at runtime. If the problem is with `sysutils/qt5-qtdiag', shouldn't it be fixed instead? Also, previously when Vulkan headers were only a bdep I didn't raise the question about why it was not made OPTIONal, but I do now. There are plenty of Qt5 users who would likely never want to have any Vulkan bits on their systems. ./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20191123145524.GA84936>