From owner-svn-ports-head@freebsd.org  Sat Nov 23 14:55:25 2019
Return-Path: <owner-svn-ports-head@freebsd.org>
Delivered-To: svn-ports-head@mailman.nyi.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.nyi.freebsd.org (Postfix) with ESMTP id 025B21B7C93;
 Sat, 23 Nov 2019 14:55:25 +0000 (UTC)
 (envelope-from danfe@freebsd.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
 [IPv6:2610:1c1:1:6074::16:84])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 server-signature RSA-PSS (4096 bits)
 client-signature RSA-PSS (4096 bits) client-digest SHA256)
 (Client CN "freefall.freebsd.org",
 Issuer "Let's Encrypt Authority X3" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 47KxDX6Cb5z48b7;
 Sat, 23 Nov 2019 14:55:24 +0000 (UTC)
 (envelope-from danfe@freebsd.org)
Received: by freefall.freebsd.org (Postfix, from userid 1033)
 id CE3D211DD5; Sat, 23 Nov 2019 14:55:24 +0000 (UTC)
Date: Sat, 23 Nov 2019 14:55:24 +0000
From: Alexey Dokuchaev <danfe@freebsd.org>
To: Adriaan de Groot <adridg@freebsd.org>
Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org,
 svn-ports-head@freebsd.org
Subject: Re: svn commit: r518243 - head/x11-toolkits/qt5-gui
Message-ID: <20191123145524.GA84936@FreeBSD.org>
References: <201911231446.xANEkdSZ075924@repo.freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <201911231446.xANEkdSZ075924@repo.freebsd.org>
User-Agent: Mutt/1.11.4 (2019-03-13)
X-BeenThere: svn-ports-head@freebsd.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: SVN commit messages for the ports tree for head
 <svn-ports-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-ports-head>, 
 <mailto:svn-ports-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-head/>
List-Post: <mailto:svn-ports-head@freebsd.org>
List-Help: <mailto:svn-ports-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 23 Nov 2019 14:55:25 -0000

On Sat, Nov 23, 2019 at 02:46:39PM +0000, Adriaan de Groot wrote:
> New Revision: 518243
> URL: https://svnweb.freebsd.org/changeset/ports/518243
> 
> Log:
>   Add Vulkan headers to the run-depends of x11-toolkits/qt5-gui
>   
>   This was already added to the build-deps; however now users of qt5-gui
>   run into Vulkan problems, in particular sysutils/qt5-qtdiag, which is
>   now fixed with this build-depends.
> 
> @@ -25,7 +25,8 @@ LIB_DEPENDS=	libdbus-1.so:devel/dbus \
>  		libxcb-render-util.so:x11/xcb-util-renderutil \
>  		libxcb-icccm.so:x11/xcb-util-wm \
>  		libxkbcommon.so:x11/libxkbcommon
> -RUN_DEPENDS=	xdg-open:devel/xdg-utils
> +RUN_DEPENDS=	xdg-open:devel/xdg-utils \
> +		${LOCALBASE}/include/vulkan/vulkan.h:devel/vulkan-headers

Commit log does not really explain how come a *header file* is needed
at runtime.  If the problem is with `sysutils/qt5-qtdiag', shouldn't it
be fixed instead?

Also, previously when Vulkan headers were only a bdep I didn't raise
the question about why it was not made OPTIONal, but I do now.  There
are plenty of Qt5 users who would likely never want to have any Vulkan
bits on their systems.

./danfe