From owner-freebsd-current@freebsd.org Wed May 27 23:45:51 2020 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id CBAFB2F331C for ; Wed, 27 May 2020 23:45:51 +0000 (UTC) (envelope-from ianfreislich@gmail.com) Received: from mailman.nyi.freebsd.org (mailman.nyi.freebsd.org [IPv6:2610:1c1:1:606c::50:13]) by mx1.freebsd.org (Postfix) with ESMTP id 49XSBl4DWjz4N5M for ; Wed, 27 May 2020 23:45:51 +0000 (UTC) (envelope-from ianfreislich@gmail.com) Received: by mailman.nyi.freebsd.org (Postfix) id 8F6CB2F331B; Wed, 27 May 2020 23:45:51 +0000 (UTC) Delivered-To: current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 8F3292F349E for ; Wed, 27 May 2020 23:45:51 +0000 (UTC) (envelope-from ianfreislich@gmail.com) Received: from mail-qv1-xf34.google.com (mail-qv1-xf34.google.com [IPv6:2607:f8b0:4864:20::f34]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 49XSBk4czzz4N0T for ; Wed, 27 May 2020 23:45:50 +0000 (UTC) (envelope-from ianfreislich@gmail.com) Received: by mail-qv1-xf34.google.com with SMTP id g7so1575692qvx.11 for ; Wed, 27 May 2020 16:45:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-transfer-encoding:content-language; bh=lvfVU3G+C/RD/naoGgS25WBHDUpwCASHYkcL+v7CpSk=; b=m6sTQjHxqcAB6qK5QdRiPIFs7dikVjm60mLo+tt8VUhJzzRnWynK4GRfcB13Ix51ZI Q4V29EQEos95+S+yTIX93vRfk/alXjNXa/RwDasqCxlhBwijUd3KDoYbSDyDe54VBzBY HfMY5GFVPvDxzJL4c1+APbAmjJeH2F5CrM3vJw6kz/AwGvNCsNQG5+4LWzTvuW9ZptT6 EYmlG71V4OUyLZLn/D7Q1WUfRPpYI+qDvA51UkFuWtxK8xkObqFQrKelKbwmP7pOWII/ UNJfa//8hJVx+iXn5YHVuATKP/18FC70B3wLDc9k4udP7Sr1AAMz9ZmM3KZR8vMg5b8+ qfBA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=lvfVU3G+C/RD/naoGgS25WBHDUpwCASHYkcL+v7CpSk=; b=Wvu3olyk0l/xc5F80x8+B0Miafvkvc4zYGDIpzsnQamMWqQiSn7bj+5vR5rUySEhm+ 6O0P3jDF824UI6D44ff4SWoH/WSgWhtm3edRmN/a/zMD2oU5pF1EMhQOCAGXNNDgScXv KNSYPpEwaDlWaNIwwE0zefdBHzvn1GxTmo6e+3dPPWntIY7r+vl4EI+/ZWbucSDo7xHR TnwGELVsSyU4AOgHjmMpr6RpieVw0tlqH5D3q3DXEqX2TsGGsuSxaec0uRwziNMnRXep rJPUw4abX0aZtaizv66B9bZbzm16/Kr6nA/2XiW8cfDobznivn+mKXCWwswrx+75Loej Q+3A== X-Gm-Message-State: AOAM532EG8nDnrPcUWomTAbPofm2uBvGffIDK38SwXDVhJYp0yDy8+vV 8cuK6jGiCoflA2xC6smZi9A9oixlSRnt7A== X-Google-Smtp-Source: ABdhPJxk8C9xhNbrf6Bo8L58Qiwdl+HpavgLx6Hag8nOOxD8t85ksl9FRjoIQ719GJUS2p3xgni/fw== X-Received: by 2002:a0c:83a6:: with SMTP id k35mr469212qva.251.1590623149253; Wed, 27 May 2020 16:45:49 -0700 (PDT) Received: from [10.0.0.140] (c-73-20-244-53.hsd1.ga.comcast.net. [73.20.244.53]) by smtp.gmail.com with ESMTPSA id v14sm4094494qtj.31.2020.05.27.16.45.48 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 27 May 2020 16:45:48 -0700 (PDT) Subject: Re: r360902 breaks VLAN interface on if_em (82579LM) To: current@freebsd.org References: <88004d48-4434-875a-5a36-0627b00c2f38@gmail.com> <1906251966.36777.1590562439792.JavaMail.open-xchange@opme11oxm03aub.bagnolet.francetelecom.fr> From: Ian FREISLICH Message-ID: <997c1389-5e18-b07e-d342-c787c841a4c4@gmail.com> Date: Wed, 27 May 2020 19:45:48 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: <1906251966.36777.1590562439792.JavaMail.open-xchange@opme11oxm03aub.bagnolet.francetelecom.fr> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-Rspamd-Queue-Id: 49XSBk4czzz4N0T X-Spamd-Bar: --- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20161025 header.b=m6sTQjHx; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (mx1.freebsd.org: domain of ianfreislich@gmail.com designates 2607:f8b0:4864:20::f34 as permitted sender) smtp.mailfrom=ianfreislich@gmail.com X-Spamd-Result: default: False [-3.34 / 15.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; FREEMAIL_FROM(0.00)[gmail.com]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4000::/36]; TO_DN_NONE(0.00)[]; RCVD_COUNT_THREE(0.00)[3]; DKIM_TRACE(0.00)[gmail.com:+]; DMARC_POLICY_ALLOW(-0.50)[gmail.com,none]; NEURAL_HAM_SHORT(-0.35)[-0.351]; RECEIVED_SPAMHAUS_PBL(0.00)[73.20.244.53:received]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; MID_RHS_MATCH_FROM(0.00)[]; DWL_DNSWL_NONE(0.00)[gmail.com:dkim]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-0.99)[-0.989]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20161025]; FROM_HAS_DN(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; NEURAL_HAM_LONG(-1.00)[-0.996]; MIME_GOOD(-0.10)[text/plain]; PREVIOUSLY_DELIVERED(0.00)[current@freebsd.org]; RCPT_COUNT_ONE(0.00)[1]; RCVD_IN_DNSWL_NONE(0.00)[2607:f8b0:4864:20::f34:from]; RCVD_TLS_ALL(0.00)[] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 27 May 2020 23:45:51 -0000 Hi I'm told the content was stripped from my emails... I noticed that my VLAN interfaces stopped working after a recent build.  tcpdump showed traffic leaving leaving and entering the interface but no host on the network actually received any packets from this host.  A binary search led me to r360902 and indeed the following change fixed the issue for me: Index: sys/dev/e1000/if_em.c =================================================================== --- sys/dev/e1000/if_em.c       (revision 361538) +++ sys/dev/e1000/if_em.c       (working copy) @@ -4054,7 +4054,7 @@  {         switch (event) {         case IFLIB_RESTART_VLAN_CONFIG: -               return (false); +               return (true);         default:                 return (true);         } Hardware according to pciconf is: em0@pci0:0:25:0:        class=0x020000 rev=0x04 hdr=0x00 vendor=0x8086 device=0x1502 subvendor=0x103c subdevice=0x1495     vendor     = 'Intel Corporation'     device     = '82579LM Gigabit Network Connection (Lewisville)'     class      = network     subclass   = ethernet     cap 01[c8] = powerspec 2  supports D0 D3  current D0     cap 05[d0] = MSI supports 1 message, 64 bit enabled with 1 message     cap 13[e0] = PCI Advanced Features: FLR TP Ian -- Ian Freislich