From owner-freebsd-current@freebsd.org Wed Nov 14 02:42:07 2018 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 1CB3D1105B7E for ; Wed, 14 Nov 2018 02:42:07 +0000 (UTC) (envelope-from cse.cem@gmail.com) Received: from mail-it1-f196.google.com (mail-it1-f196.google.com [209.85.166.196]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 85EB4886AA; Wed, 14 Nov 2018 02:42:06 +0000 (UTC) (envelope-from cse.cem@gmail.com) Received: by mail-it1-f196.google.com with SMTP id o19so12498172itg.5; Tue, 13 Nov 2018 18:42:06 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:reply-to :from:date:message-id:subject:to:cc; bh=yEMa7DzaNWJ1F0ndGfjBlTK54EGcGTuZbsmqWfOTdJY=; b=p8TJk7SigLQgFdq5ACtCM2l8KTc34dGPxt/DT2PVOw4wyT2qYORl//GwXdH2R2BFQF FxLFJcJFRVNZq1GJ8yDKMO8udpLJVoXN8EjnMCo/QlMjYsTyYdhtVP/7eerp1k9h63Op NvKzUpVrTnRH8GXZY33PiumlAvPi09s/o2KqHqYs9SjQvBu+o3i+8l1FuvuJ6n4ZQrA8 IAKNjtbwfcSx20klA7vIs1hNfbbYtTErbirFGcijO7Taers85pk9dBHKEZBse2VSxrHS jdkn0mszoY8vLgozZceJKOwBpH5iSPSvvWsRM8pbb+iXgV3tl7CtnH12oiRTLCA3WCX1 oDTA== X-Gm-Message-State: AGRZ1gJIsIIPi/9RFYrUdWQujY8aUyEVCvZXXOuw4+4wm9t9rmu6t5qr c5SNqjem6AAj/PgSq4+GsZv5PXcK X-Google-Smtp-Source: AJdET5eArnRfsO28Ju+0fzGV0W4JQN8FZ9ucYkRDj+94ABvEONZ+NTtcj9ExwE31uyogmI8zgqmZYw== X-Received: by 2002:a02:5e04:: with SMTP id h4-v6mr64821jab.99.1542163319798; Tue, 13 Nov 2018 18:41:59 -0800 (PST) Received: from mail-io1-f54.google.com (mail-io1-f54.google.com. [209.85.166.54]) by smtp.gmail.com with ESMTPSA id p10-v6sm6956148ioh.20.2018.11.13.18.41.59 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 13 Nov 2018 18:41:59 -0800 (PST) Received: by mail-io1-f54.google.com with SMTP id m19so4936333ioh.3; Tue, 13 Nov 2018 18:41:59 -0800 (PST) X-Received: by 2002:a6b:3ad5:: with SMTP id h204-v6mr85795ioa.124.1542163318844; Tue, 13 Nov 2018 18:41:58 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: Reply-To: cem@freebsd.org From: Conrad Meyer Date: Tue, 13 Nov 2018 18:41:47 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: No amdtemp sysctls, acpi errors, AMD Ryzen 5 2400G To: Daniel Eischen Cc: freebsd-current Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 85EB4886AA X-Spamd-Result: default: False [-4.06 / 200.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; HAS_REPLYTO(0.00)[cem@freebsd.org]; R_SPF_ALLOW(-0.20)[+ip4:209.85.128.0/17]; REPLYTO_ADDR_EQ_FROM(0.00)[]; RCVD_COUNT_THREE(0.00)[4]; TO_DN_ALL(0.00)[]; MX_GOOD(-0.01)[cached: alt3.gmail-smtp-in.l.google.com]; RCPT_COUNT_TWO(0.00)[2]; NEURAL_HAM_SHORT(-0.98)[-0.981,0]; FORGED_SENDER(0.30)[cem@freebsd.org,csecem@gmail.com]; RCVD_TLS_LAST(0.00)[]; R_DKIM_NA(0.00)[]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US]; TAGGED_FROM(0.00)[]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; FROM_NEQ_ENVFROM(0.00)[cem@freebsd.org,csecem@gmail.com]; FROM_HAS_DN(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[freebsd.org]; IP_SCORE(-1.07)[ipnet: 209.85.128.0/17(-3.41), asn: 15169(-1.85), country: US(-0.09)]; RCVD_IN_DNSWL_NONE(0.00)[196.166.85.209.list.dnswl.org : 127.0.5.0]; RWL_MAILSPIKE_POSSIBLE(0.00)[196.166.85.209.rep.mailspike.net : 127.0.0.17] X-Rspamd-Server: mx1.freebsd.org X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Nov 2018 02:42:07 -0000 On Tue, Nov 13, 2018 at 6:26 PM Daniel Eischen wrote: > I've attached it. If it gets filtered by the mail list, I'll > make it http accessible. Thanks Daniel. It looks like your hostbridge zero device has a different device id than in my first generation Ryzen system. Would you please try the following patch and see if it attaches on your system? I don't actually have documentation for Ryzen 2, unfortunately, so I'm not totally sure if the SMN is accessed in the same way for the new hostbridge device id. The change below should at least attempt attaching to hostb0 on your system. diff --git a/sys/dev/amdsmn/amdsmn.c b/sys/dev/amdsmn/amdsmn.c index 17792dd922cd..6fe36b4cc4da 100644 --- a/sys/dev/amdsmn/amdsmn.c +++ b/sys/dev/amdsmn/amdsmn.c @@ -60,7 +60,8 @@ struct amdsmn_softc { static struct pciid { uint32_t device_id; } amdsmn_ids[] = { - { 0x14501022 }, + { 0x14501022 }, /* Ryzen */ + { 0x15d01022 }, /* Ryzen 2 */ }; /* diff --git a/sys/dev/amdtemp/amdtemp.c b/sys/dev/amdtemp/amdtemp.c index 2463212c25f5..765e660a8461 100644 --- a/sys/dev/amdtemp/amdtemp.c +++ b/sys/dev/amdtemp/amdtemp.c @@ -102,6 +102,7 @@ static struct amdtemp_product { { VENDORID_AMD, DEVICEID_AMD_MISC16_M30H }, { VENDORID_AMD, DEVICEID_AMD_MISC17 }, { VENDORID_AMD, DEVICEID_AMD_HOSTB17H }, + { VENDORID_AMD, 0x15d0 }, }; /* Thanks, Conrad