From owner-freebsd-commit Wed Apr 12 16:56:33 1995 Return-Path: commit-owner Received: (from majordom@localhost) by freefall.cdrom.com (8.6.10/8.6.6) id QAA01137 for commit-outgoing; Wed, 12 Apr 1995 16:56:33 -0700 Received: (from majordom@localhost) by freefall.cdrom.com (8.6.10/8.6.6) id QAA01054 for cvs-sys-outgoing; Wed, 12 Apr 1995 16:55:07 -0700 Received: from trout.sri.MT.net (trout.sri.MT.net [204.182.243.12]) by freefall.cdrom.com (8.6.10/8.6.6) with ESMTP id QAA01006 ; Wed, 12 Apr 1995 16:54:08 -0700 Received: (from nate@localhost) by trout.sri.MT.net (8.6.11/8.6.11) id RAA15739; Wed, 12 Apr 1995 17:46:37 -0600 Date: Wed, 12 Apr 1995 17:46:37 -0600 From: Nate Williams Message-Id: <199504122346.RAA15739@trout.sri.MT.net> In-Reply-To: Poul-Henning Kamp "Re: cvs commit: src/sys/i386/isa sio.c" (Apr 12, 4:31pm) X-Mailer: Mail User's Shell (7.2.5 10/14/92) To: Poul-Henning Kamp , bde@zeta.org.au (Bruce Evans) Subject: Re: cvs commit: src/sys/i386/isa sio.c Cc: CVS-commiters@freefall.cdrom.com, cvs-sys@freefall.cdrom.com Sender: commit-owner@FreeBSD.org Precedence: bulk > > > Dropping into the debugger when a break comes down the serial line is a > > > >MISFEATURE (1st class)< and has been put under it's own #ifdef. This > > > should be a magic sequence of chars instead. > > > > A magic sequence of chars would be a misfeature, as it would be for > > syscons. The escape should be out of bounds (perhaps it should optionally > > be break && some combination of the modem status lines). > > No, we want something you can send on a modem... Why is break a bad thing? Any magic sequence of chars is *worse* since there is no guarantee that something might not send it to the console and therefore drop into a debugger. Break is good because it is out-of-bound AND can be sent from modem's and other serial devices w/out special hardware. Nate