From nobody Tue Dec 9 15:54:32 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4dQk1h6WN7z6Kpqy for ; Tue, 09 Dec 2025 15:54:32 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4dQk1h33Mdz44Z5 for ; Tue, 09 Dec 2025 15:54:32 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1765295672; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=AFdUztDBUPcYbPFrHQ9ZZFr+kl2+ujNcJB0O5TZI5po=; b=ssBml4CRpmL4bDN5fK4BBsD3FV7kCDbVbhG2I3/hMq3R18hnSolLP5SGebfognviFQbdBw 5JR4lUfjxadbiG44KM9AWbVlk3Gr2MP27bwJTISRHBJCQozs34nFePZSUSTjBaJsm/CpZi IA31CjiEISzYl/Iq82JW/6H2mJS2hv0EeMjfR/CunwoqKnJmA+oHjlNON5+Oqh//kAZ2AY 5OCz/ofIzsBQ3CGRuAaDZj9kqfeNA7qLQjZ6/R6mCHWv5GB6iPclhvTHk6q8NA0/PFPjCt +EElWjqnzohYMlvL/fkfUuhiu2EvYnmaOZhiGsgOfQR5bmgVsB4i2Sl3JpsJQA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1765295672; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=AFdUztDBUPcYbPFrHQ9ZZFr+kl2+ujNcJB0O5TZI5po=; b=K1JwyLVTBuBDWpe3m2oyHtbYEb8IO1hXqjqM8AQU8W0XK7kLimmAHDq3YrWCBc0S8NV9kt 3uUB2iyQIeqppzkrKwBSZxisPMvVAhcKO0EGZErVCOmMVfZEFEu6Op9NjPuGqPtE9Qm5KD Ksne94wjVUylugK9RomZt/ncWZid5+70eRVpKRfgSrjD6rVJWAmHW2+YW/GaFetPKsjyZR XzBwPf6S/AaAROaB4dcoZJHPdoydkWALMQsF7Fe88c39xp6Uayzl1BRd8QTzkZ0YmRX/0e WbOQrhcHp5dwQgJ/kXCWGdJLpXI399s52R3t6pbWlTmsQ9EPMg0DGyD3HCZHhQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1765295672; a=rsa-sha256; cv=none; b=quvUnccEYIYjkDzgXzEUBfZ+r2dZyogzeNkNy545QDPezrcOmmFETL+Y3VbjuXqAbG2KvF YMRHvwQgG74ThBd7+W6S060AElWctmzkGBmByNjsiCcb4xQjYkS7tNG9zZTObMN9Hkw4gZ GS94S57ei2K1l/gvOqnUbj6eFs+KsXQAkYVoNOK9se1dvvLJMronkXD/rkxeS0Nr/2qTTG M/8jDdehGDrp18I1dM8xF2TuAV/7CG4Z5LMQbuDN2jtDhPd1ijTv6zDFelqgrX5XZNpbw1 I0581iLlAIG/zrjmW9rDzfL4NGM2eWnUbmx0BrpdTQRI/YnuC2jBZa0iVz4NgA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4dQk1h2byhz1566 for ; Tue, 09 Dec 2025 15:54:32 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 35291 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Tue, 09 Dec 2025 15:54:32 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: John Baldwin Subject: git: bc2b10a59314 - main - cxgbe: Stop using bus_space_tag/handle directly List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: jhb X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: bc2b10a5931442bb39653cd8d5712b2d7195cf46 Auto-Submitted: auto-generated Date: Tue, 09 Dec 2025 15:54:32 +0000 Message-Id: <69384638.35291.72c2c01b@gitrepo.freebsd.org> The branch main has been updated by jhb: URL: https://cgit.FreeBSD.org/src/commit/?id=bc2b10a5931442bb39653cd8d5712b2d7195cf46 commit bc2b10a5931442bb39653cd8d5712b2d7195cf46 Author: John Baldwin AuthorDate: 2025-12-09 15:46:55 +0000 Commit: John Baldwin CommitDate: 2025-12-09 15:47:35 +0000 cxgbe: Stop using bus_space_tag/handle directly Reviewed by: np, imp Sponsored by: Chelsio Communications Differential Revision: https://reviews.freebsd.org/D53030 --- sys/dev/cxgbe/adapter.h | 18 ++++++++---------- sys/dev/cxgbe/t4_iov.c | 6 +----- sys/dev/cxgbe/t4_main.c | 6 ++---- 3 files changed, 11 insertions(+), 19 deletions(-) diff --git a/sys/dev/cxgbe/adapter.h b/sys/dev/cxgbe/adapter.h index 38875b535067..24a482b74dfb 100644 --- a/sys/dev/cxgbe/adapter.h +++ b/sys/dev/cxgbe/adapter.h @@ -963,8 +963,6 @@ struct adapter { struct resource *regs_res; int msix_rid; struct resource *msix_res; - bus_space_handle_t bh; - bus_space_tag_t bt; bus_size_t mmio_len; int udbs_rid; struct resource *udbs_res; @@ -1276,7 +1274,7 @@ t4_read_reg(struct adapter *sc, uint32_t reg) { if (hw_off_limits(sc)) MPASS(curthread == sc->reset_thread); - return bus_space_read_4(sc->bt, sc->bh, reg); + return bus_read_4(sc->regs_res, reg); } static inline void @@ -1284,7 +1282,7 @@ t4_write_reg(struct adapter *sc, uint32_t reg, uint32_t val) { if (hw_off_limits(sc)) MPASS(curthread == sc->reset_thread); - bus_space_write_4(sc->bt, sc->bh, reg, val); + bus_write_4(sc->regs_res, reg, val); } static inline uint64_t @@ -1293,10 +1291,10 @@ t4_read_reg64(struct adapter *sc, uint32_t reg) if (hw_off_limits(sc)) MPASS(curthread == sc->reset_thread); #ifdef __LP64__ - return bus_space_read_8(sc->bt, sc->bh, reg); + return bus_read_8(sc->regs_res, reg); #else - return (uint64_t)bus_space_read_4(sc->bt, sc->bh, reg) + - ((uint64_t)bus_space_read_4(sc->bt, sc->bh, reg + 4) << 32); + return (uint64_t)bus_read_4(sc->regs_res, reg) + + ((uint64_t)bus_read_4(sc->regs_res, reg + 4) << 32); #endif } @@ -1307,10 +1305,10 @@ t4_write_reg64(struct adapter *sc, uint32_t reg, uint64_t val) if (hw_off_limits(sc)) MPASS(curthread == sc->reset_thread); #ifdef __LP64__ - bus_space_write_8(sc->bt, sc->bh, reg, val); + bus_write_8(sc->regs_res, reg, val); #else - bus_space_write_4(sc->bt, sc->bh, reg, val); - bus_space_write_4(sc->bt, sc->bh, reg + 4, val>> 32); + bus_write_4(sc->regs_res, reg, val); + bus_write_4(sc->regs_res, reg + 4, val>> 32); #endif } diff --git a/sys/dev/cxgbe/t4_iov.c b/sys/dev/cxgbe/t4_iov.c index 452ebaaf0172..9ccf63fd6516 100644 --- a/sys/dev/cxgbe/t4_iov.c +++ b/sys/dev/cxgbe/t4_iov.c @@ -54,8 +54,6 @@ struct t4iov_softc { int pf; int regs_rid; struct resource *regs_res; - bus_space_handle_t bh; - bus_space_tag_t bt; }; struct { @@ -147,7 +145,7 @@ static inline uint32_t t4iov_read_reg(struct t4iov_softc *sc, uint32_t reg) { - return bus_space_read_4(sc->bt, sc->bh, reg); + return bus_read_4(sc->regs_res, reg); } static int t4iov_attach_child(device_t dev); @@ -249,8 +247,6 @@ t4iov_attach(device_t dev) device_printf(dev, "cannot map registers.\n"); return (ENXIO); } - sc->bt = rman_get_bustag(sc->regs_res); - sc->bh = rman_get_bushandle(sc->regs_res); pl_rev = t4iov_read_reg(sc, A_PL_REV); whoami = t4iov_read_reg(sc, A_PL_WHOAMI); diff --git a/sys/dev/cxgbe/t4_main.c b/sys/dev/cxgbe/t4_main.c index 5e02b47da8d9..3237c6649713 100644 --- a/sys/dev/cxgbe/t4_main.c +++ b/sys/dev/cxgbe/t4_main.c @@ -2660,8 +2660,8 @@ reset_adapter_with_pl_rst(struct adapter *sc) { /* This is a t4_write_reg without the hw_off_limits check. */ MPASS(sc->error_flags & HW_OFF_LIMITS); - bus_space_write_4(sc->bt, sc->bh, A_PL_RST, - F_PIORSTMODE | F_PIORST | F_AUTOPCIEPAUSE); + bus_write_4(sc->regs_res, A_PL_RST, + F_PIORSTMODE | F_PIORST | F_AUTOPCIEPAUSE); pause("pl_rst", 1 * hz); /* Wait 1s for reset */ return (0); } @@ -3997,8 +3997,6 @@ t4_map_bars_0_and_4(struct adapter *sc) device_printf(sc->dev, "cannot map registers.\n"); return (ENXIO); } - sc->bt = rman_get_bustag(sc->regs_res); - sc->bh = rman_get_bushandle(sc->regs_res); sc->mmio_len = rman_get_size(sc->regs_res); setbit(&sc->doorbells, DOORBELL_KDB);