Date: Tue, 6 Jan 2015 16:10:49 -0700 From: Jason Wolfe <nitroboost@gmail.com> To: Hans Petter Selasky <hps@selasky.org> Cc: Adrian Chadd <adrian@freebsd.org>, FreeBSD Current <freebsd-current@freebsd.org>, "freebsd-arch@freebsd.org" <freebsd-arch@freebsd.org> Subject: Re: [RFC] kern/kern_timeout.c rewrite in progress Message-ID: <CAAAm0r39Sv3TCvwaCiNQ1Y9iBVtY_nb0A_iNOC41bgxqXmt%2B4w@mail.gmail.com> In-Reply-To: <54A9A71E.70609@selasky.org> References: <54A1B38C.1000709@selasky.org> <20150101005613.4f788b0c@nonamehost.local> <54A49CA5.2060801@selasky.org> <54A4A002.8010802@selasky.org> <54A53F4F.2000003@selasky.org> <54A92ED1.2070906@selasky.org> <CAJ-Vmo=tc-hqykhyc5bQW8qd_34PZU6yfGY8wziByA0xnR3ANQ@mail.gmail.com> <54A9A71E.70609@selasky.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, Jan 4, 2015 at 1:48 PM, Hans Petter Selasky <hps@selasky.org> wrote: > On 01/04/15 19:58, Adrian Chadd wrote: >> >> Hi! >> >> Can you throw this into reviews.freebsd.org please? This is something >> that should be very closely reviewed and tested. >> >> (I'm going to go over this quite closely as it related to a lot of the >> random crap I do ..) >> > > Hi Adrian, > > Here you go: > > https://reviews.freebsd.org/D1438 > > Thank you for your time to review this! > > > --HPS Hans, We've been running into 'spin lock held too long' panics in the kernel idle threads on 10-STABLE over the past 6 months, so I was interested to see your work here in the callout code. I went ahead and brought this patch back to a recent 10.1-STABLE base without much issue, kern_timeout.c was actually the only piece with some easily resolvable rejections. I've had a box running stable under load with this patch for a few days, and 10 more have just been added to the rotation. Anyway just figured you might be interested in the some feedback while the changes are reviewed. Thanks! Jason
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAAAm0r39Sv3TCvwaCiNQ1Y9iBVtY_nb0A_iNOC41bgxqXmt%2B4w>