From owner-svn-src-all@FreeBSD.ORG Mon Jan 10 21:19:15 2011 Return-Path: Delivered-To: svn-src-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id BC94810656A4; Mon, 10 Jan 2011 21:19:15 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from harmony.bsdimp.com (bsdimp.com [199.45.160.85]) by mx1.freebsd.org (Postfix) with ESMTP id 7C57A8FC26; Mon, 10 Jan 2011 21:19:15 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by harmony.bsdimp.com (8.14.3/8.14.1) with ESMTP id p0ALDFS2000421; Mon, 10 Jan 2011 14:13:15 -0700 (MST) (envelope-from imp@bsdimp.com) Message-ID: <4D2B7669.5030601@bsdimp.com> Date: Mon, 10 Jan 2011 14:13:13 -0700 From: Warner Losh User-Agent: Mozilla/5.0 (X11; U; FreeBSD amd64; en-US; rv:1.9.2.12) Gecko/20101029 Thunderbird/3.1.6 MIME-Version: 1.0 To: John Baldwin References: <201101092347.p09NlB4M060802@svn.freebsd.org> <201101101433.18847.jhb@freebsd.org> In-Reply-To: <201101101433.18847.jhb@freebsd.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, Doug Barton , src-committers@FreeBSD.org Subject: Re: svn commit: r217213 - head/lib/bind X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 10 Jan 2011 21:19:15 -0000 On 01/10/2011 12:33, John Baldwin wrote: > On Sunday, January 09, 2011 6:47:11 pm Doug Barton wrote: >> Author: dougb >> Date: Sun Jan 9 23:47:11 2011 >> New Revision: 217213 >> URL: http://svn.freebsd.org/changeset/base/217213 >> >> Log: >> Revert part of r217071 so that us mere mortals can clearly see >> what this bit of code is intended to do. :) >> >> Approved by: imp >> >> Modified: >> head/lib/bind/config.mk >> >> Modified: head/lib/bind/config.mk >> > ============================================================================== >> --- head/lib/bind/config.mk Sun Jan 9 23:46:24 2011 (r217212) >> +++ head/lib/bind/config.mk Sun Jan 9 23:47:11 2011 (r217213) >> @@ -65,7 +65,11 @@ CFLAGS+= -I${LIB_BIND_DIR} >> .endif >> >> # Use the right version of the atomic.h file from lib/isc >> -ISC_ATOMIC_ARCH=${MACHINE_CPUARCH:S/i386/x86_32/:S/amd64/x86_32/} >> +.if ${MACHINE_ARCH} == "amd64" || ${MACHINE_ARCH} == "i386" > This should use MACHINE_CPUARCH instead of MACHINE_ARCH? To be pedantically correct, yes. Practically, it currently makes no difference. Warner