Date: Fri, 4 Sep 2015 11:36:58 +0200 From: Baptiste Daroussin <bapt@FreeBSD.org> To: Bryan Drewery <bdrewery@FreeBSD.org> Cc: Mathieu Arnold <mat@FreeBSD.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r394508 - in head: . Mk Tools/scripts audio/amarok-kde4 audio/jack audio/lua51-mpd audio/py-mpd2 biology/ruby-bio chinese/joe chinese/phpbb3-tw databases/jdbm2 databases/luasql-mysql da... Message-ID: <20150904093658.GM61752@ivaldir.etoilebsd.net> In-Reply-To: <55E8DDC8.6030809@FreeBSD.org> References: <201508171420.t7HEKfgZ044105@repo.freebsd.org> <55E8DDC8.6030809@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--SgT04PEqo/+yUDw3 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Sep 03, 2015 at 04:54:48PM -0700, Bryan Drewery wrote: > On 8/17/15 7:20 AM, Mathieu Arnold wrote: > > Author: mat > > Date: Mon Aug 17 14:20:40 2015 > > New Revision: 394508 > > URL: https://svnweb.freebsd.org/changeset/ports/394508 > >=20 > > Log: > > Remove UNIQUENAME and LATEST_LINK. > > =20 > > UNIQUENAME was never unique, it was only used by USE_LDCONFIG and now, > > we won't have conflicts there. > > =20 > > Use PKGBASE instead of LATEST_LINK in PKGLATESTFILE, the *only* consu= mer > > is pkg-devel, and it works just fine without LATEST_LINK as pkg-devel > > has the correct PKGNAME anyway. > > =20 > > Now that UNIQUENAME is gone, OPTIONSFILE is too. (it's been called > > OPTIONS_FILE now.) >=20 > Please restore handling for OPTIONSFILE. It was there for backwards > compat and now breaks POLA. >=20 > I had options in a OPTIONSFILE that unset things that now are coming back. >=20 > For example I have a /var/db/ports/gpgme/options that had > OPTIONS_UNSET+=3D UISERVER, but I have no > /var/db/ports/security_gpgme/options. So now I get the defaults. >=20 This is weird because the ports tree should have automatically moved those = to security_gpgme during the last years except if set using poudriere options /me hates poudriere options :) Maybe poudriere should check the sanity of the options dir when running but= that is another subject. That said I agree that 2 things should be restored: OPTIONSFILE=3D and the <name>_SET But we should absolutely not readd UNIQUENAME, so both should be based on PKGBASE. If OPTIONSILE is found a warning should be send to the users. with a deprec= ation notice. Best regards, Bapt --SgT04PEqo/+yUDw3 Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAlXpZjoACgkQ8kTtMUmk6EwsUACfQ756QByL7FHZKbqAXmYtBRFf WX0An0uxXZmbyw3DIOgHRInawb1tgAcO =73mX -----END PGP SIGNATURE----- --SgT04PEqo/+yUDw3--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20150904093658.GM61752>