From owner-freebsd-current@FreeBSD.ORG  Tue Jan 20 22:04:12 2009
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 70B3710657B1;
	Tue, 20 Jan 2009 22:04:12 +0000 (UTC)
	(envelope-from keramida@freebsd.org)
Received: from igloo.linux.gr (igloo.linux.gr [62.1.205.36])
	by mx1.freebsd.org (Postfix) with ESMTP id A33338FC16;
	Tue, 20 Jan 2009 22:04:11 +0000 (UTC)
	(envelope-from keramida@freebsd.org)
Received: from kobe.laptop (adsl189-242.kln.forthnet.gr [79.103.2.242])
	(authenticated bits=128)
	by igloo.linux.gr (8.14.3/8.14.3/Debian-5) with ESMTP id n0KM41S4016515
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT);
	Wed, 21 Jan 2009 00:04:08 +0200
Received: from kobe.laptop (kobe.laptop [127.0.0.1])
	by kobe.laptop (8.14.3/8.14.3) with ESMTP id n0KM41Bg099588;
	Wed, 21 Jan 2009 00:04:01 +0200 (EET)
	(envelope-from keramida@freebsd.org)
Received: (from keramida@localhost)
	by kobe.laptop (8.14.3/8.14.3/Submit) id n0KM4001099587;
	Wed, 21 Jan 2009 00:04:00 +0200 (EET)
	(envelope-from keramida@freebsd.org)
From: Giorgos Keramidas <keramida@freebsd.org>
To: Christoph Mallon <christoph.mallon@gmx.de>
References: <87skndg0cv.fsf@kobe.laptop> <497641FC.30209@gmx.de>
Date: Wed, 21 Jan 2009 00:04:00 +0200
In-Reply-To: <497641FC.30209@gmx.de> (Christoph Mallon's message of "Tue, 20
	Jan 2009 22:28:28 +0100")
Message-ID: <87d4eh8wj3.fsf@kobe.laptop>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (berkeley-unix)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
X-MailScanner-ID: n0KM41S4016515
X-Hellug-MailScanner: Found to be clean
X-Hellug-MailScanner-SpamCheck: not spam, SpamAssassin (not cached,
	score=-4.156, required 5, autolearn=not spam, ALL_TRUSTED -1.80,
	AWL 0.24, BAYES_00 -2.60)
X-Hellug-MailScanner-From: keramida@freebsd.org
X-Spam-Status: No
Cc: Tim Kientzle <kientzle@freebsd.org>, freebsd-current@freebsd.org
Subject: Re: [PATCH] bsdcpio core dump
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 20 Jan 2009 22:04:17 -0000

On Tue, 20 Jan 2009 22:28:28 +0100, Christoph Mallon <christoph.mallon@gmx.de> wrote:
> Giorgos Keramidas schrieb:
>> diff -r cb9a95f8dfb3 usr.bin/cpio/cpio.c
>> --- a/usr.bin/cpio/cpio.c	Tue Jan 20 21:45:52 2009 +0200
>> +++ b/usr.bin/cpio/cpio.c	Tue Jan 20 22:56:48 2009 +0200
>> @@ -623,12 +623,12 @@
>>  	r = archive_write_header(cpio->archive, entry);
>>   	if (r != ARCHIVE_OK)
>> -		cpio_warnc(archive_errno(cpio->archive),
>> +		cpio_warnc(0,
>>  		    "%s: %s",
>> -		    destpath,
>> +		    srcpath,
>>  		    archive_error_string(cpio->archive));
>
> Wouldn't it be better to remove the manually appended error string,
> i.e. ": %s" ... archive_error_string(), instead of circumventing the
> generic error reporting magic provided by cpio_warnc()?

That's probably better.   It's why I split the patch in two parts, so
Tim can review them separately and pick whatever is nicer :)

It might be better to use:

        cpio_warnc(archive_errno(cpio->archive),
            "%s", srcpath);