From owner-freebsd-bugs@freebsd.org Wed Jul 11 06:49:05 2018 Return-Path: Delivered-To: freebsd-bugs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 87494103CD03 for ; Wed, 11 Jul 2018 06:49:05 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id 1C78180F51 for ; Wed, 11 Jul 2018 06:49:05 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.ysv.freebsd.org (Postfix) id C6356103CCFB; Wed, 11 Jul 2018 06:49:04 +0000 (UTC) Delivered-To: bugs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id A1BE9103CCFA for ; Wed, 11 Jul 2018 06:49:04 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.ysv.freebsd.org (mxrelay.ysv.freebsd.org [IPv6:2001:1900:2254:206a::19:3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mxrelay.ysv.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 3101780F50 for ; Wed, 11 Jul 2018 06:49:04 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.ysv.freebsd.org (Postfix) with ESMTPS id 67D93181ED for ; Wed, 11 Jul 2018 06:49:03 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id w6B6n3kV034323 for ; Wed, 11 Jul 2018 06:49:03 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id w6B6n3K4034322 for bugs@FreeBSD.org; Wed, 11 Jul 2018 06:49:03 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 229689] freebsd-update shouldn't add system breaking comments to config files Date: Wed, 11 Jul 2018 06:49:03 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: conf X-Bugzilla-Version: 11.2-RELEASE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: allcoms@gmail.com X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 11 Jul 2018 06:49:05 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D229689 Bug ID: 229689 Summary: freebsd-update shouldn't add system breaking comments to config files Product: Base System Version: 11.2-RELEASE Hardware: Any OS: Any Status: New Severity: Affects Only Me Priority: --- Component: conf Assignee: bugs@FreeBSD.org Reporter: allcoms@gmail.com Yesterday I used freebsd-update to upgrade from 11.1 to 11.2. I probably should've waited until the weekend or a time when I wasn't as tired or in a hurry because it was past my bedtime on a school night and so after it had downloaded all the patches and it was asking me to evaluate the changes in various config files I just said "Yeah whatever" and blindly accepted all of the suggested changes, presuming that freebsd-update or any of the update scripts wouldn't do anything stupid but unfortunately it did make some brea= king changes to my config files to prevented me logging in after the upgrade. I'm unsure of the full extent of the damage but the main ones I'm aware of = were a couple of 'uncommented comments' added to /etc/ssh/sshd_config. freebsd-update added these two lines: <<<<<<< current version >>>>>>> 11.2-RELEASE Because there was no hash sign at the beginning of either line, sshd choked= on these two lines and I couldn't log into my server via ssh. I then had to sp= end 30 minutes digging out a VGA cable and hooking up a monitor to fix my ssh config file. Thankfully the server is in my house and wasn't doing anything important at the time but I can see this biting others harder and in a more expensive way. I can guarantee I won't be the only person who blindly accep= ts the suggested modifications during an upgrade. --=20 You are receiving this mail because: You are the assignee for the bug.=