From owner-freebsd-stable@FreeBSD.ORG Sun Jul 26 01:06:40 2009 Return-Path: Delivered-To: freebsd-stable@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 7FB0C1065670; Sun, 26 Jul 2009 01:06:40 +0000 (UTC) (envelope-from imb@protected-networks.net) Received: from sarah.protected-networks.net (sarah.protected-networks.net [IPv6:2001:470:1f07:4e1::1]) by mx1.freebsd.org (Postfix) with ESMTP id 39A888FC12; Sun, 26 Jul 2009 01:06:40 +0000 (UTC) (envelope-from imb@protected-networks.net) Received: from toshi.auburn.protected-networks.net (toshi.auburn.protected-networks.net [IPv6:2001:470:1f07:4e1::4]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "Iain Michael Butler", Issuer "Protected Networks Certificate Authority" (verified OK)) (Authenticated sender: imb) by sarah.protected-networks.net (Postfix) with ESMTPSA id 089C0617A; Sat, 25 Jul 2009 21:06:38 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=protected-networks.net; s=200705; t=1248570399; bh=gel6MwE7eDP4SquVMl6fqLEYf0w9i58J8xuxHxJ9CI0=; h=Message-ID:Date:From:MIME-Version:To:CC:Subject:References: In-Reply-To:Content-Type:Content-Transfer-Encoding; b=qB9Fes6GClE8Th6GYj9Z6XNCSnFiG6rN/6uRroJFmB9gLsBDysVqdsDS/ZftiW54y GLz7or2qcJYZXYQrSjAiMrqAXdNroW8oNhUTEisvKGle5hKiITP3WB6UCIG12rY DomainKey-Signature: a=rsa-sha1; s=200509; d=protected-networks.net; c=nofws; q=dns; h=message-id:date:from:user-agent:mime-version:to:cc:subject: references:in-reply-to:x-enigmail-version:openpgp:content-type:content-transfer-encoding; b=LhYp2sRIOMZvgNqHXvl81c4uzwXGpGomH4E80FMSdacRb6ZVMFef2ACyv+EHu6O00 F6o046R72xxkl6EiNgPbBQB8ZClJGBeokIVL5iDQWlJH1iCOak/qT1+H1cjqvWu Message-ID: <4A6BAC1A.5080303@protected-networks.net> Date: Sat, 25 Jul 2009 21:06:34 -0400 From: Michael Butler User-Agent: Thunderbird 2.0.0.22 (X11/20090723) MIME-Version: 1.0 To: Jamie Gritton References: <4A6B0BD3.6040206@protected-networks.net> <4A6B9A60.90302@FreeBSD.org> In-Reply-To: <4A6B9A60.90302@FreeBSD.org> X-Enigmail-Version: 0.96.0 OpenPGP: id=0442D492 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: freebsd-stable Subject: Re: regression with jexec? X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 26 Jul 2009 01:06:40 -0000 -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Jamie Gritton wrote: > Michael Butler wrote: >> imb@aaron:/home/imb> sudo jexec 5 tcsh >> jexec: Unable to parse jail ID.: No such file or directory > > The symptom in jexec can be fixed by this little patch: > > Index: usr.sbin/jexec/jexec.c > =================================================================== > --- usr.sbin/jexec/jexec.c (revision 195879) > +++ usr.sbin/jexec/jexec.c (working copy) > @@ -248,6 +248,7 @@ > if (argc < 2) > usage(); > if (strlen(argv[0]) > 0) { > + errno = 0; > jid = (int)strtol(argv[0], NULL, 10); > if (errno) > err(1, "Unable to parse jail ID."); Thanks - this certainly cures the effect. > But the broader problem is malloc. It's leaving errno set to > ENOENT when /etc/malloc.conf doesn't exist. This seems like > wrong behavior to me. Seems like a POLA violation to me, imb -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (FreeBSD) iEYEARECAAYFAkprrBoACgkQQv9rrgRC1JIImwCdG2hjH00hKOzMRUHEqfXwu8FS O6UAoJL/2iZf/Nz0Pp84q0p+RDkNIM+1 =iBx1 -----END PGP SIGNATURE-----