From nobody Wed Sep 20 02:10:32 2023 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Rr27F0btBz4tMml; Wed, 20 Sep 2023 02:10:33 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Rr27D6z83z4Yl9; Wed, 20 Sep 2023 02:10:32 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1695175833; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=9QzCIHQ9D16OpJqbT0596AXc+7mYhfgVt1UI2QinHe8=; b=TBfszTPxrPM0ff0SDpC7WkMlhFap9w8un7LvCD9mvQECWcxmMHk5Tn9Pe9C7lgU47lBDNT ONYqlY0azVkEpzWqmk7d5nxpDDTZrWVYzlD7aqVA7+6MwUWxERAQyj8+I8MVcI1N7zb3LE +bi7+a0hjxTCJM3Du8nzfWjBL4RwYYpSakkhUsZLJ5MWbqKjw4pObum140u5ILnZ6K+Dk6 LsWslNfKARhdchiUV8tQIM6UA17JICZ+csxHcUveYvnyMgQXBl+PKr4T2NqL1yOJyxMYoL dhQRQMi8S08JjSsqvEdv++mARJcEAPaKik9ngLtiN+F5jHYi2vs/S97p42VQtg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1695175833; a=rsa-sha256; cv=none; b=Q3ABbQOe22Xaj6o47l3oOaaiQVMdMdRkJyDu0ZtAM/3DEzwcKVRvNG4QflWq3Xvv0ysYDR 7RV6fnGQ4jx5Z7YK5+0Z8ChlEZ1/CXWASVCg6dE3S6yMFRjAqQihHBCbiDTlZ8IZjC4wd0 wsfoARh/2E/uMRBYkl7MGj5bd6uDQnljjgfKS2eL/fL6FdO0qpDXU/YhnQxxgS/CwkxeOr 5g3idfuP6gvoA4Pj5JaD9ekWMpGuoPJafCVPn8uf+I5MihG2bK2Kx5y7IkNZ8uZLECj/vG j2F1qIyoTg9e+DDvmjLPyb6YIxxe9McTzNIrzFtZnhQK6nYINQtEsO1edu+DFQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1695175833; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=9QzCIHQ9D16OpJqbT0596AXc+7mYhfgVt1UI2QinHe8=; b=ePuwVbCivm5hZMARNE2bsyOiyCOQnrCt9+4mwEMCazTZTBm0oyCAp+9iJoHaCNGfdz26+h gLncY7j6MhypKZLYQww9YWlAGsGge5cooDrGAxwUmnuDf0jND1b270vPooyLnhOS2J7ley 40muUs28sXyN7Ffg7H0Qq0jNFp4M1uxYCnUoNoITMIzwB0MAQm9H1fpH/Ue46ZerCm58Lv 5CzyfRaA3UVW3m4qvMfi78exlcLNZTHO81G5DOVCGDZ5hKPEcEYhISOPgbxEyEpe0s6E6s HZelE6Uff+X7JMUkwHbP2LBeU2iyPqgYCPmSTLu9pPOKMKbiNpf8ium0tt+M7w== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4Rr27D64PCzdCl; Wed, 20 Sep 2023 02:10:32 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.17.1/8.17.1) with ESMTP id 38K2AWr8063960; Wed, 20 Sep 2023 02:10:32 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.17.1/8.17.1/Submit) id 38K2AWj7063957; Wed, 20 Sep 2023 02:10:32 GMT (envelope-from git) Date: Wed, 20 Sep 2023 02:10:32 GMT Message-Id: <202309200210.38K2AWj7063957@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Doug Moore Subject: git: a4c7a3f7f56a - stable/14 - powerpc pmap: initialize kernel pmap radix trie List-Id: Commits to the stable branches of the FreeBSD src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-branches@freebsd.org X-BeenThere: dev-commits-src-branches@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: dougm X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: a4c7a3f7f56a131a74b78ac48f6533feb8ef5aae Auto-Submitted: auto-generated The branch stable/14 has been updated by dougm: URL: https://cgit.FreeBSD.org/src/commit/?id=a4c7a3f7f56a131a74b78ac48f6533feb8ef5aae commit a4c7a3f7f56a131a74b78ac48f6533feb8ef5aae Author: Doug Moore AuthorDate: 2023-09-13 18:17:57 +0000 Commit: Doug Moore CommitDate: 2023-09-20 02:09:37 +0000 powerpc pmap: initialize kernel pmap radix trie Commit 2d2bcba7ba70141388729ed49674b36fd01146c5 changed radix trie implementation and made it necessary that radix tries be initialized with vm_radix_init. @dbaio reports that in some configurations, there is a powerpc boot panic and that this commit introduced the problem. In powerpc/aim/mmu_radix.c, the radix trie in kernel_pmap is initialized by zeroing all its fields. Add a call to vm_radix_init to properly initialize kernel_pmap->pm_radix. Reported by: dbaio Reviewed by: alc, jhibbits Fixes: 2d2bcba7ba drop NULL check from radix trie search MFC after: 1 week Differential Revision: https://reviews.freebsd.org/D41846 (cherry picked from commit 8763b9862f90dc3bdbbc5e3c2664890be7c1f0c4) --- sys/powerpc/aim/mmu_radix.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sys/powerpc/aim/mmu_radix.c b/sys/powerpc/aim/mmu_radix.c index 32d08d2d7026..b904978e042c 100644 --- a/sys/powerpc/aim/mmu_radix.c +++ b/sys/powerpc/aim/mmu_radix.c @@ -1843,6 +1843,7 @@ mmu_radix_setup_pagetables(vm_size_t hwphyssz) bzero(kernel_pmap, sizeof(struct pmap)); PMAP_LOCK_INIT(kernel_pmap); + vm_radix_init(&kernel_pmap->pm_radix); ptpages = allocpages(3); l1phys = moea64_bootstrap_alloc(RADIX_PGD_SIZE, RADIX_PGD_SIZE);